Integrated: 8336401: Remove the option onjcmd from the jdwp agent

2024-10-18 Thread Johannes Bechberger
On Mon, 7 Oct 2024 11:47:12 GMT, Johannes Bechberger wrote: > Remove the support for on-demand debugging via the onjcmd option. This pull request has now been integrated. Changeset: 309b9291 Author:Johannes Bechberger URL: https://git.openjdk.org/jdk/commit/309b929147e7dddfa27879ff

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Tue, 15 Oct 2024 22:14:00 GMT, Sean Mullan wrote: >> src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java >> line 225: >> >>> 223: */ >>> 224: public static JMXConnector connect(JMXServiceURL serviceURL) >>> 225: throws IOException { >> >>

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Kevin Walls
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-18 Thread Robert Toyonaga
On Sat, 12 Oct 2024 18:42:34 GMT, Afshin Zafari wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning

2024-10-18 Thread Patricio Chilano Mateo
On Fri, 18 Oct 2024 00:09:59 GMT, David Holmes wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the changes have been

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Wed, 16 Oct 2024 20:42:11 GMT, Sean Mullan wrote: >> The description for the SecurityException thrown by these methods were >> adjusted to "if access to the screen is denied by desktop environment". If >> you bring back the paragraphs that were removed then you might have to >> adjust the w

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Thu, 17 Oct 2024 17:59:20 GMT, Sean Mullan wrote: >> All JGSS permission classes follow the same style: >> >> In `javax.security.auth.kerberos.DelegationPermission`: >> >> * This class is used to restrict the usage of the Kerberos >> * delegation model, ie: forwardable and proxiable ticket

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread David M . Lloyd
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Tue, 15 Oct 2024 14:50:54 GMT, Daniel Fuchs wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 97 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Change apiNote to d

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Tue, 15 Oct 2024 17:01:59 GMT, Sean Mullan wrote: >>> While making `LogManager.checkAccess` be a no-op might be more convenient, >>> it could unconditionally permit operations that formerly required a >>> permission check: clearly a bad idea. Always throwing a `SecurityException` >>> is the

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
On Thu, 17 Oct 2024 05:54:24 GMT, Alan Bateman wrote: >> Ok, I'll also add an API note to `getClassContext()` to use `StackWalker` >> instead. > > Okay, it already has `@see StackWalker`. My guess is that anything extending > SM to call getClassContext is very old code. If that old code is comp

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning

2024-10-18 Thread David Holmes
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo wrote: > This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes hav

RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning

2024-10-18 Thread Patricio Chilano Mateo
This is the implementation of JEP 491: Synchronize Virtual Threads without Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for further details. In order to make the code review easier the changes have been split into the following initial 4 commits: - Changes to allow unmou

Integrated: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning

2024-10-18 Thread Serguei Spitsyn
On Fri, 11 Oct 2024 08:39:42 GMT, Serguei Spitsyn wrote: > There is a race between JVMTI NotifyFramePop function and FramePop event > posting code. > The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with > depth 0 is requested by NotifyFramePop at the time when the target fr

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-18 Thread Sean Mullan
> This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main changes in the JEP and also includes an apidiff of the specif

Re: RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v9]

2024-10-18 Thread Serguei Spitsyn
On Fri, 18 Oct 2024 01:11:32 GMT, Serguei Spitsyn wrote: >> There is a race between JVMTI NotifyFramePop function and FramePop event >> posting code. >> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with >> depth 0 is requested by NotifyFramePop at the time when the targe

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v4]

2024-10-18 Thread William Kemper
> This PR merges JEP 404, a generational mode for the Shenandoah garbage > collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would > like to target JDK24 with this PR. William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull r

Re: RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v9]

2024-10-18 Thread Alex Menkov
On Fri, 18 Oct 2024 01:11:32 GMT, Serguei Spitsyn wrote: >> There is a race between JVMTI NotifyFramePop function and FramePop event >> posting code. >> The fix is to return JVMTI_ERROR_OPAQUE_FRAME if if a FramePop event with >> depth 0 is requested by NotifyFramePop at the time when the targe

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v6]

2024-10-18 Thread Alan Bateman
On Fri, 18 Oct 2024 00:53:37 GMT, Serguei Spitsyn wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - M

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v4]

2024-10-18 Thread Stefan Karlsson
On Fri, 18 Oct 2024 06:46:22 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request