Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v19]

2024-10-12 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-12 Thread Afshin Zafari
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v18]

2024-10-12 Thread Simon Tooke
> This PR changes the status of realpath() from a Posix-specific API to a > globally available API, i.e. adding it to the "Hotspot Porting API". Code > would refer to os::realpath() instead of os::Posix::realpath(). > > This requires a Windows implementation of realpath(), using Windows > _ful

Re: RFR: 8339289: Parameter size mismatch between client and VM sides of the Attach API - Windows

2024-10-12 Thread Serguei Spitsyn
On Fri, 30 Aug 2024 00:07:50 GMT, Alex Menkov wrote: > The fix improves Attch API protocol and implements updated protocol on > windows; shared code is ready to implement updated protocol support on other > platforms. > More detailed explanations on the 1st comment. > > Testing: tier1,tier2,ti