Re: RFR: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run

2024-10-03 Thread Sebastian Lövdahl
On Thu, 3 Oct 2024 19:13:46 GMT, Sebastian Lövdahl wrote: > The fix is twofold. > > 1. Stop the main container after an iteration is done. The main container is > started with its runtime defined as 120 seconds, which means that each > iteration takes 120 seconds. In reality, one iteration tak

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v29]

2024-10-03 Thread Coleen Phillimore
On Wed, 2 Oct 2024 15:37:40 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8341295: Add some useful debugging APIs to the debug agent [v2]

2024-10-03 Thread Chris Plummer
On Wed, 2 Oct 2024 02:20:48 GMT, Chris Plummer wrote: >> The following APIs are useful when debugging the debug agent. Calls to them >> can be added to the code as needed (temporarily) to aid in debugging issues. >> They were taken from `test/lib/jdk/test/lib/jvmti/jvmti_common.hpp` and >> mod

Re: RFR: 8341482: Attach API access to /proc filesystem should use doPrivileged [v2]

2024-10-03 Thread Larry Cable
On Wed, 2 Oct 2024 21:15:11 GMT, Larry Cable wrote: >> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114 >> >> to resolve an issue detected in: >> >> https://bugs.openjdk.org/browse/JDK-8341246 >> >> /proc/**/* file accesses should be performed as "privileged" actions to >> avoi

Integrated: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently

2024-10-03 Thread Alan Bateman
On Wed, 2 Oct 2024 18:34:53 GMT, Alan Bateman wrote: > This is a test only change. > VirtualThreadSchedulerMXBeanTest.testReduceParallelism can fail when > getMountedVirtualThreadCount over estimates the number of mounted virtual > threads. > > The test is changed from using getMountedVirtual

Integrated: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114)

2024-10-03 Thread Severin Gehwolf
On Tue, 1 Oct 2024 16:16:36 GMT, Severin Gehwolf wrote: > The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) also > increased test coverage. In particular, the `TestJcmdWithSideCar.java` test > got enhanced to cover these cases (prior to > [JDK-8327114](https://bugs.openj

Re: RFR: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114) [v3]

2024-10-03 Thread Severin Gehwolf
On Wed, 2 Oct 2024 18:46:07 GMT, Severin Gehwolf wrote: >> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) >> also increased test coverage. In particular, the `TestJcmdWithSideCar.java` >> test got enhanced to cover these cases (prior to >> [JDK-8327114](https://bugs.o

Re: RFR: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114) [v3]

2024-10-03 Thread Kevin Walls
On Wed, 2 Oct 2024 18:46:07 GMT, Severin Gehwolf wrote: >> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) >> also increased test coverage. In particular, the `TestJcmdWithSideCar.java` >> test got enhanced to cover these cases (prior to >> [JDK-8327114](https://bugs.o

Re: RFR: 8341310: Test TestJcmdWithSideCar.java should skip ACCESS_TMP_VIA_PROC_ROOT (after JDK-8327114) [v3]

2024-10-03 Thread Severin Gehwolf
On Thu, 3 Oct 2024 10:43:56 GMT, Kevin Walls wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Improve runtime of test" >> >>This reverts commit 5b2f646c73b747f6fff364347031074d24e49822. >> - Re

Re: RFR: 8341310: Test containers/docker/TestJcmdWithSideCar.java fails after JDK-8327114 [v3]

2024-10-03 Thread Kevin Walls
On Wed, 2 Oct 2024 18:46:07 GMT, Severin Gehwolf wrote: >> The change of [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114) >> also increased test coverage. In particular, the `TestJcmdWithSideCar.java` >> test got enhanced to cover these cases (prior to >> [JDK-8327114](https://bugs.o

Re: RFR: 8341310: Test containers/docker/TestJcmdWithSideCar.java fails after JDK-8327114

2024-10-03 Thread Severin Gehwolf
On Tue, 1 Oct 2024 16:56:11 GMT, Kevin Walls wrote: > I can check our testing with this change... @kevinjwalls Any update on this? Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/21289#issuecomment-2391044188

Re: RFR: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently [v2]

2024-10-03 Thread Kevin Walls
On Thu, 3 Oct 2024 09:03:06 GMT, Alan Bateman wrote: >> This is a test only change. >> VirtualThreadSchedulerMXBeanTest.testReduceParallelism can fail when >> getMountedVirtualThreadCount over estimates the number of mounted virtual >> threads. >> >> The test is changed from using getMountedV

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v2]

2024-10-03 Thread Severin Gehwolf
On Wed, 2 Oct 2024 21:15:11 GMT, Larry Cable wrote: >> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114 >> >> to resolve an issue detected in: >> >> https://bugs.openjdk.org/browse/JDK-8341246 >> >> /proc/**/* file accesses should be performed as "privileged" actions to >> avoi

Re: RFR: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently [v2]

2024-10-03 Thread Alan Bateman
> This is a test only change. > VirtualThreadSchedulerMXBeanTest.testReduceParallelism can fail when > getMountedVirtualThreadCount over estimates the number of mounted virtual > threads. > > The test is changed from using getMountedVirtualThreadCount to sample the > result until it reads the

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v2]

2024-10-03 Thread Kevin Walls
On Wed, 2 Oct 2024 21:15:11 GMT, Larry Cable wrote: >> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114 >> >> to resolve an issue detected in: >> >> https://bugs.openjdk.org/browse/JDK-8341246 >> >> /proc/**/* file accesses should be performed as "privileged" actions to >> avoi

Re: RFR: 8341310: Test containers/docker/TestJcmdWithSideCar.java fails after JDK-8327114 [v2]

2024-10-03 Thread Severin Gehwolf
On Thu, 3 Oct 2024 05:27:33 GMT, Sebastian Lövdahl wrote: > > Filed https://bugs.openjdk.org/browse/JDK-8341436 to track this separate > > issue. > > Do you intend to look into this yourself? If not, I would be happy to pick it > up. Please go ahead and have a go at this. - PR C

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container)

2024-10-03 Thread Severin Gehwolf
On Wed, 2 Oct 2024 19:59:31 GMT, Larry Cable wrote: >> this is a fix to: https://bugs.openjdk.org/browse/JDK-8327114 >> >> to resolve an issue detected in: >> >> https://bugs.openjdk.org/browse/JDK-8341246 >> >> /proc/**/* file accesses should be performed as "privileged" actions to >> avoi