Re: RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

2024-07-28 Thread David Holmes
On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls wrote: > CmdLine::is_executable() looks wrong, surely an empty line is not executable. > > With this change, in DCmd::parse_and_execute() we will avoid needlessly > entering the code block to try and execute the command. > > DCmd tests all good: > m

Re: RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

2024-07-28 Thread David Holmes
On Sun, 28 Jul 2024 09:48:21 GMT, Johan Sjölen wrote: >> CmdLine::is_executable() looks wrong, surely an empty line is not executable. >> >> With this change, in DCmd::parse_and_execute() we will avoid needlessly >> entering the code block to try and execute the command. >> >> DCmd tests all g

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-28 Thread David Holmes
On Fri, 26 Jul 2024 21:02:32 GMT, Alex Menkov wrote: > "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios

Re: RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

2024-07-28 Thread Johan Sjölen
On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls wrote: > CmdLine::is_executable() looks wrong, surely an empty line is not executable. > > With this change, in DCmd::parse_and_execute() we will avoid needlessly > entering the code block to try and execute the command. > > DCmd tests all good: > m