On Fri, 26 Jul 2024 11:39:02 GMT, Kevin Walls wrote:
> One more thing that's troubling me. (Apologies it's now and not last week.)
>
> I was looking at the _filename.value().get() usage and finding it
> uncomfortable, compared to the previous simple _filename.value() 8-) Harder
> to remember a
On Fri, 26 Jul 2024 18:21:05 GMT, Ashutosh Mehra wrote:
>> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 242:
>>
>>> 240: for (int tag = 0; tag < Arena::tag_count(); tag++) {
>>> 241: st->print_cr(" " LEGEND_KEY_FMT ": %s", Arena::tag_name[tag],
>>> Arena::tag_desc[t
On Fri, 26 Jul 2024 18:18:45 GMT, Ashutosh Mehra wrote:
>> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 204:
>>
>>> 202: size_t _total;
>>> 203: // usage per arena tag when total peaked
>>> 204: size_t _tags_size_at_peak[Arena::tag_count()];
>>
>> Can you please make sur
JVMTI has a somewhat unique event called DataDumpRequest. One way it is
triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the
DataDumpRequest event to all agents that have registered for the event
callback. The agent is free to do pretty much what it wants during the
callbac
On Sat, 27 Jul 2024 01:55:23 GMT, Chris Plummer wrote:
> The test is setting breakpoints on the wrong line numbers, which causes
> setting up the breakpoint to fail, but the test also has buggy error
> checking, so the test doesn't detect the failures and still passes. I fixed
> the breakpoint
The test is setting breakpoints on the wrong line numbers, which causes setting
up the breakpoint to fail, but the test also has buggy error checking, so the
test doesn't detect the failures and still passes. I fixed the breakpoint line
numbers and the error checking. More details in the first c
On Fri, 26 Jul 2024 17:56:27 GMT, Alex Menkov wrote:
> We skip (do not process) invisible annotations
Okay, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/20315#issuecomment-2253694697
On Mon, 22 Jul 2024 20:32:35 GMT, Chris Plummer wrote:
> Fix deadlock with debug agent callbackLock. Details in first comment.
>
> Tested by running all jdi, jdwp, and jdb tests with and without virtual
> threads about 40 times. The testing was initially done with my hack to force
> the self s
"Attach fails" scenarios (debuggee starts listening and debugger is expected to
fail trying to attach) sometimes interfere with other JDI tests (so
JdwpNetProps.java test or other JDI test or both fail).
The fix disables the scenarios to remove noise in the CI.
-
Commit messages:
-
On Fri, 26 Jul 2024 06:08:03 GMT, Thomas Stuefe wrote:
>> Some minor improvements to CompilationMemoryStatistic. More details are in
>> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031)
>>
>> Testing:
>> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java
>>
>> test/
On Wed, 24 Jul 2024 18:01:15 GMT, Alex Menkov wrote:
> Obsolete PreserveAllAnnotations flag which was deprecated in JDK 23.
>
> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
This pull request has now been integrated.
Changeset: abc4ca5a
Author:Alex Menkov
URL:
https://git.openjdk.o
On Fri, 26 Jul 2024 10:39:28 GMT, Serguei Spitsyn wrote:
> Looks good. Really nice simplification. Do I understand it right that all
> annotations are visible now, or we just do not parse/process invisible ones?
> If all annotations are visible then can we get rid of the suffix `_visible'?
We
On Fri, 26 Jul 2024 12:44:31 GMT, Johan Sjölen wrote:
>> Hi,
>>
>> Today the GrowableArray has a set index type of `int`, this PR makes it so
>> that you can set your own index type through a template parameter.
>>
>> This opens up for a few new design choices:
>>
>> - Do you know that you ha
On Fri, 5 Jul 2024 07:38:12 GMT, Glavo wrote:
>> Johan Sjölen has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Fix
>> - Apparently this(!)
>> - This?
>> - Use COMMA
>
> src/hotspot/share/classfile/classFileParser.hpp line 46:
>
>>
On Thu, 4 Jul 2024 13:35:36 GMT, Johan Sjölen wrote:
>> Hi,
>>
>> Today the GrowableArray has a set index type of `int`, this PR makes it so
>> that you can set your own index type through a template parameter.
>>
>> This opens up for a few new design choices:
>>
>> - Do you know that you hav
On Thu, 4 Jul 2024 14:07:57 GMT, Thomas Stuefe wrote:
> If this is for src/hotspot/share/nmt/arrayWithFreeList.hpp, would it not be a
> lot simpler to just implement it there, and give it another backing store?
>
> In particular because after doing all this work it still won't even support
> t
> Hi,
>
> Today the GrowableArray has a set index type of `int`, this PR makes it so
> that you can set your own index type through a template parameter.
>
> This opens up for a few new design choices:
>
> - Do you know that you have a very small array? Use an `uint8_t` for len and
> cap, each
On Thu, 4 Jul 2024 13:35:36 GMT, Johan Sjölen wrote:
>> Hi,
>>
>> Today the GrowableArray has a set index type of `int`, this PR makes it so
>> that you can set your own index type through a template parameter.
>>
>> This opens up for a few new design choices:
>>
>> - Do you know that you hav
On Thu, 25 Jul 2024 15:31:05 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
>> enabling jcmd diagnostic commands that issue an output file to accept the
>> `%p` pattern in the file name and substitute it for the PID.
On Mon, 22 Jul 2024 20:32:35 GMT, Chris Plummer wrote:
> Fix deadlock with debug agent callbackLock. Details in first comment.
>
> Tested by running all jdi, jdwp, and jdb tests with and without virtual
> threads about 40 times. The testing was initially done with my hack to force
> the self s
On Thu, 25 Jul 2024 01:53:13 GMT, Alex Menkov wrote:
>> Obsolete PreserveAllAnnotations flag which was deprecated in JDK 23.
>>
>> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
21 matches
Mail list logo
