Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v4]

2024-06-13 Thread Chris Plummer
On Fri, 14 Jun 2024 03:51:28 GMT, Leonid Mesnik wrote: >> The nsk.share.Log has 3 parameters that might be configured by tests or >> using command-line: >> - verbose, traceLevel and timestamp >> >> The main purpose of these modes was to minimize output and use command-line >> arguments to e

Re: RFR: 8333962: Obsolete OldSize

2024-06-13 Thread David Holmes
On Tue, 11 Jun 2024 08:17:02 GMT, Albert Mingkun Yang wrote: > Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Al seems reasonable. Thanks. src/hotspot/share/runtime/arguments.cpp line 543: > 541: { "UseNeon",

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v4]

2024-06-13 Thread Leonid Mesnik
> The nsk.share.Log has 3 parameters that might be configured by tests or > using command-line: > - verbose, traceLevel and timestamp > > The main purpose of these modes was to minimize output and use command-line > arguments to enable them during bug reproducing/debugging for vmTestbase when

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v3]

2024-06-13 Thread Leonid Mesnik
On Fri, 14 Jun 2024 03:09:26 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reverted traceLevel > > test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 226: > >> 224: if (!verbose) {

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v3]

2024-06-13 Thread Chris Plummer
On Fri, 14 Jun 2024 00:49:28 GMT, Leonid Mesnik wrote: >> The nsk.share.Log has 3 parameters that might be configured by tests or >> using command-line: >> - verbose, traceLevel and timestamp >> >> The main purpose of these modes was to minimize output and use command-line >> arguments to e

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v3]

2024-06-13 Thread Serguei Spitsyn
On Fri, 14 Jun 2024 00:49:28 GMT, Leonid Mesnik wrote: >> The nsk.share.Log has 3 parameters that might be configured by tests or >> using command-line: >> - verbose, traceLevel and timestamp >> >> The main purpose of these modes was to minimize output and use command-line >> arguments to e

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v3]

2024-06-13 Thread Leonid Mesnik
On Fri, 14 Jun 2024 00:31:41 GMT, Chris Plummer wrote: >> The intention is to print always all logged messages. So we should set the >> highest tracing level for the logger to work in debug mode. > > I'm not so sure I agree with this. Do we have examples of debug logging? I > think in general v

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v3]

2024-06-13 Thread Leonid Mesnik
> The nsk.share.Log has 3 parameters that might be configured by tests or > using command-line: > - verbose, traceLevel and timestamp > > The main purpose of these modes was to minimize output and use command-line > arguments to enable them during bug reproducing/debugging for vmTestbase when

Re: RFR: 8332113: Update nsk.share.Log to be always verbose [v2]

2024-06-13 Thread Chris Plummer
On Fri, 14 Jun 2024 00:03:32 GMT, Leonid Mesnik wrote: >> test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 130: >> >>> 128: * Default value is 0 a.k.a. >>> TraceLevel.INFO; >>> 129: */ >>> 130: private final int traceLevel = TraceLevel.TRACE_DEBUG + 1; >> >> Can you explain

[jdk23] Integrated: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Naoto Sato
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Justin Lu
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

[jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
Hi all, This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was rev

Integrated: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translati

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-13 Thread Kevin Walls
On Tue, 11 Jun 2024 19:01:45 GMT, Weijun Wang wrote: >> Thanks I'll go through the above comments and update - some of the changes I >> see are unnecessary and from when I was trying migrating to callAs, and >> doPrivileged, and yes they can be simpler. >> >> On the allowSecurityMananger check

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v10]

2024-06-13 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-13 Thread Inigo Mediavilla Saiz
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unn

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-13 Thread Alan Bateman
On Thu, 13 Jun 2024 14:37:45 GMT, Inigo Mediavilla Saiz wrote: > Would you mind explaining why unparking the main (virtual) thread can end up > with the main thread observing the dummy thread in transition ? The unpark of main requires queueing the task for main. This can trigger a new FJP wo

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-13 Thread Inigo Mediavilla Saiz
On Thu, 13 Jun 2024 10:28:06 GMT, Alan Bateman wrote: >> Inigo Mediavilla Saiz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unneeded line > > I've created [JDK-8334215](https://bugs.openjdk.org/browse/JDK-8334215) with > issue

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v9]

2024-06-13 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v6]

2024-06-13 Thread Kevin Walls
On Wed, 12 Jun 2024 16:41:36 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >>Undo test policy updates > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java >

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v8]

2024-06-13 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v7]

2024-06-13 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-13 Thread Alan Bateman
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unn

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v6]

2024-06-13 Thread Kevin Walls
On Wed, 12 Jun 2024 20:42:27 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >>Undo test policy updates > > src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessControll