Re: RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-06 Thread Thomas Stuefe
On Thu, 6 Jun 2024 21:21:23 GMT, David Holmes wrote: >> ### Summary >> This change ensures we don't get undefined behavior when >> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). >> `isspace` accepts an `int` argument that "the application shall ensu

Re: RFR: 8333130: MakeJAR2.sh uses hard-coded JDK version [v3]

2024-06-06 Thread Jaikiran Pai
On Tue, 4 Jun 2024 01:30:55 GMT, Jaikiran Pai wrote: >> test/jdk/java/lang/instrument/RetransformApp.java line 81: >> >>> 79: final OutputAnalyzer oa = ProcessTools.executeTestJava( >>> 80: "--enable-preview", // due to usage of ClassFile API >>> PreviewFeature in the ag

Re: RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-06 Thread David Holmes
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote: > ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "the application shall ensur

Re: RFR: 8333566: Remove unused methods

2024-06-06 Thread Vladimir Kozlov
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote: > Please, consider this patch to remove unused methods from the code base. To > the best of my knowledge, these methods are only defined but never used. > > Here is a list with names of delete methods: > https://gist.github.com/JohnTor

Re: RFR: 8333566: Remove unused methods

2024-06-06 Thread Amit Kumar
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote: > Please, consider this patch to remove unused methods from the code base. To > the best of my knowledge, these methods are only defined but never used. > > Here is a list with names of delete methods: > https://gist.github.com/JohnTor

Re: RFR: 8333566: Remove unused methods

2024-06-06 Thread Cesar Soares Lucas
On Thu, 6 Jun 2024 01:28:00 GMT, Amit Kumar wrote: >> Please, consider this patch to remove unused methods from the code base. To >> the best of my knowledge, these methods are only defined but never used. >> >> Here is a list with names of delete methods: >> https://gist.github.com/JohnTortug

Re: RFR: 8333566: Remove unused methods

2024-06-06 Thread Amit Kumar
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote: > Please, consider this patch to remove unused methods from the code base. To > the best of my knowledge, these methods are only defined but never used. > > Here is a list with names of delete methods: > https://gist.github.com/JohnTor

RFR: 8333566: Remove unused methods

2024-06-06 Thread Cesar Soares Lucas
Please, consider this patch to remove unused methods from the code base. To the best of my knowledge, these methods are only defined but never used. Here is a list with names of delete methods: https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874 Tested with Linux x86_64 tier1-4

Re: RFR: 8333477: Delete extra empty spaces in Makefiles

2024-06-06 Thread Chen Liang
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. Changes requested by liach (Author). test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1: > 1:

RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-06 Thread Robert Toyonaga
### Summary This change ensures we don't get undefined behavior when calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). `isspace` accepts an `int` argument that "the application shall ensure is a character representable as an unsigned char or equal to th

Re: RFR: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

2024-06-06 Thread Chris Plummer
On Thu, 6 Jun 2024 02:12:11 GMT, Alex Menkov wrote: > The fix updates com/sun/tools/attach/BasicTests.java to listen and connect > using loopback addresses > > Testing: run the test on all Oracle-supported platforms Actually it looks like .jcheck/conf in master has not been updated to 24 yet.

Re: RFR: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

2024-06-06 Thread Chris Plummer
On Thu, 6 Jun 2024 02:12:11 GMT, Alex Menkov wrote: > The fix updates com/sun/tools/attach/BasicTests.java to listen and connect > using loopback addresses > > Testing: run the test on all Oracle-supported platforms You have an interesting warning about the fixVersion being 24 but .jcheck/conf

Re: RFR: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"

2024-06-06 Thread Kevin Walls
On Thu, 6 Jun 2024 02:12:11 GMT, Alex Menkov wrote: > The fix updates com/sun/tools/attach/BasicTests.java to listen and connect > using loopback addresses > > Testing: run the test on all Oracle-supported platforms Marked as reviewed by kevinw (Reviewer). - PR Review: https://gi

Integrated: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

2024-06-06 Thread Matthias Baesken
On Wed, 5 Jun 2024 13:04:03 GMT, Matthias Baesken wrote: > With ubsan enabled binaries we run into the following issue in HS :tier4 > tests : > e.g. > vmTestbase/nsk/jvmti/unit/FollowReferences/followref006/TestDescription.jtr > > /jdk/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.

Re: RFR: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

2024-06-06 Thread Matthias Baesken
On Wed, 5 Jun 2024 13:04:03 GMT, Matthias Baesken wrote: > With ubsan enabled binaries we run into the following issue in HS :tier4 > tests : > e.g. > vmTestbase/nsk/jvmti/unit/FollowReferences/followref006/TestDescription.jtr > > /jdk/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.

Integrated: 8332070: Convert package.html files in `java.management` to package-info.java

2024-06-06 Thread Nizar Benalla
On Fri, 24 May 2024 18:11:18 GMT, Nizar Benalla wrote: > This is a simple noreg cleanup. The motivation was that I noticed javac > doesn't recognise package.html files well. > > Some of the contents of the `package.html` files (and code in the package) > may be outdated, but I think it is out