On Thu, 30 May 2024 01:13:20 GMT, SendaoYan wrote:
>> Hi all,
>> ObjectMonitorUsage.java failed with `unexpected waiter_count` after
>> [JDK-8328083](https://bugs.openjdk.org/browse/JDK-8328083) on linux x86_32.
>> There are two changes in this PR:
>> 1. In `JvmtiEnvBase::get_object_monitor_
On Thu, 30 May 2024 06:36:09 GMT, SendaoYan wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change from java_lang_VirtualThread::is_instance(thread_oop) to
>> hread_oop->is_a(vmClasses::BaseVirtualThread_klass()) in
On Sat, 1 Jun 2024 01:18:35 GMT, Jaikiran Pai wrote:
> Hello Alex, what you suggest seems interesting and like you note much more
> simpler. I'll try it out and if that will work fine with the use of
> `--release` for the `asmlib/Instrumentor.java`.
Actually I think you don't need to specify `
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Thu, 30 May 2024 02:41:39 GMT, Serguei Spitsyn wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp
>> line 201:
>>
>>> 199:
>>> 200: // need to reset this value after the breakpoint_hit1
>>> 201: received_method_exit_event = JNI_FALSE;
>>
>> T
On Fri, 31 May 2024 23:55:20 GMT, Serguei Spitsyn wrote:
>> Please, review the following `interp-only` issue related to carrier threads.
>> There are 3 problems fixed here:
>> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
>> `JvmtiThreadState` with the `jt->jvmti_thread_state()`
On Fri, 31 May 2024 21:04:41 GMT, Daniel D. Daugherty
wrote:
> Ping @sspitsyn - who handles JLI/JPLIS reviews for the Serviceability team?
Sorry for the latency. Will start reviewing it today. Also, I see Alex is
reviewing it.
-
PR Comment: https://git.openjdk.org/jdk/pull/19495#
On Thu, 30 May 2024 18:59:10 GMT, Patricio Chilano Mateo
wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: addressed nits in new test
>
> src/hotspot/share/prims/jvmtiThreadState.cpp line 674:
>
>> 672:
> Please, review the following `interp-only` issue related to carrier threads.
> There are 3 problems fixed here:
> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
> `JvmtiThreadState` with the `jt->jvmti_thread_state()` which is incorrect
> when we have a deal with a carrier threa
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Thu, 30 May 2024 06:36:09 GMT, SendaoYan wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change from java_lang_VirtualThread::is_instance(thread_oop) to
>> hread_oop->is_a(vmClasses::BaseVirtualThread_klass()) in
On Fri, 31 May 2024 18:22:47 GMT, Leonid Mesnik wrote:
> The fix removes finalization cleanup from vmTestbase.
> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
> debuggee process. So the DebugeeProc
The fix removes finalization cleanup from vmTestbase.
The last to classes that use it are: DebugeeBinder and SocketIOPipe.
The DebugeeBinder is used in jdi and jdwp tests and is always linked with
debuggee process. So the DebugeeProcess.waitFor() is the good place to close
binder and free all it'
On Fri, 31 May 2024 12:29:59 GMT, SendaoYan wrote:
> Hi all,
> This trivial fix, delete the extra empty line before `getOopMaps` function
> in `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java`
> file.
> No risk.
Marked as reviewed by lmesnik (Reviewer).
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote:
> The fix updates HeapMerger to use writer buffer (no need to copy memory, also
> writer buffer is 1MB instead of 4KB).
> Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of
> `size_t` is a typo, the argument should
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` w
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
On Fri, 31 May 2024 16:30:55 GMT, Chris Plummer wrote:
> Approved and trivial.
Thanks for the review and approved.
-
PR Comment: https://git.openjdk.org/jdk/pull/19499#issuecomment-2142650762
On Fri, 2024-05-31 at 14:44 +0200, Maksim Zuev wrote:
> Dear Sir/Madam,
>
> I encountered a problem while debugging the code. I am attaching the
> reproducer to this email in the Main.java file.
>
> When running it with the debugger without stepping, the application
> runs in less than a second (se
On Fri, 31 May 2024 12:29:59 GMT, SendaoYan wrote:
> Hi all,
> This trivial fix, delete the extra empty line before `getOopMaps` function
> in `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java`
> file.
> No risk.
Approved and trivial.
-
Marked as reviewe
On 5/31/24 7:25 AM, Severin Gehwolf wrote:
On Fri, 2024-05-31 at 14:44 +0200, Maksim Zuev wrote:
Dear Sir/Madam,
I encountered a problem while debugging the code. I am attaching the
reproducer to this email in the Main.java file.
When running it with the debugger without stepping, the applic
On Fri, 31 May 2024 12:29:59 GMT, SendaoYan wrote:
> Hi all,
> This trivial fix, delete the extra empty line before `getOopMaps` function
> in `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java`
> file.
> No risk.
The GHA test runner report a failure
`serviceability/j
> Hi folks,
>
> This PR addresses [8332785](https://bugs.openjdk.org/browse/JDK-8332785)
> replacing all naked uses for ```UseSharedSpaces``` with
> ```CDSConfig::is_using_archive```.
>
> Testing:
> - [x] Tier 1 with GHA.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull requ
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
On Fri, 2024-05-31 at 14:44 +0200, Maksim Zuev wrote:
> Dear Sir/Madam,
>
> I encountered a problem while debugging the code. I am attaching the
> reproducer to this email in the Main.java file.
>
> When running it with the debugger without stepping, the application
> runs in less than a second
Dear Sir/Madam,
I encountered a problem while debugging the code. I am attaching the
reproducer to this email in the* Main.java file*.
When running it with the debugger without stepping, the application runs in
less than a second (see jdb output in the *jdb_run.txt *file). However,
after performi
On Fri, 31 May 2024 02:07:25 GMT, David Holmes wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> I'd probably give preference to the stack of the virtual thread, as the stack
> of the carrier when a vthread is mounted is generally quite uninte
Hi all,
This trivial fix, delete the extra empty line before `getOopMaps` function in
`src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java` file.
No risk.
-
Commit messages:
- 853: Delete extra empty line in CodeBlob.java
Changes: https://git.openjdk.org/
On Thu, 30 May 2024 16:39:03 GMT, Alan Bateman wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Thanks for take this one. Here's the result with the changes in 1a75277e.
>
> "ForkJoinPool-1-worker-1" #25 [33795] daemon prio=5 os_prio=31 cpu=4
> Can I please get a review of this test-only change which addresses
> https://bugs.openjdk.org/browse/JDK-8333130?
>
> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
> under `test/jdk/java/lang/instrument/` which launch the app/test with a
> `-javaagent:` pointing to
On Fri, 31 May 2024 09:01:27 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which addresses
> https://bugs.openjdk.org/browse/JDK-8333130?
>
> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
> under `test/jdk/java/lang/instrument/` which
Can I please get a review of this test-only change which addresses
https://bugs.openjdk.org/browse/JDK-8333130?
There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp` under
`test/jdk/java/lang/instrument/` which launch the app/test with a
`-javaagent:` pointing to a test spec
On Fri, 31 May 2024 01:41:17 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>> age
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents can be developed in C or C++.
> This update is to make it cle
36 matches
Mail list logo