Integrated: 8329418: Replace pointers to tables with offsets in relocation bitmap

2024-05-09 Thread Matias Saavedra Silva
On Mon, 6 May 2024 17:05:47 GMT, Matias Saavedra Silva wrote: > The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tab

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v2]

2024-05-09 Thread Matias Saavedra Silva
On Tue, 7 May 2024 21:39:04 GMT, Chris Plummer wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Chris comments and cleanup > > SA changes look good. Thanks for taking care of this. Thanks for the reviews @

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which

Re: RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all [v2]

2024-05-09 Thread SendaoYan
On Thu, 9 May 2024 21:26:07 GMT, Daniel D. Daugherty wrote: > I've updated the bug's sysnopsis: > > s/macos-aarch64/generic-all/ > > The fastest way to update the PR's title is with `/issue JDK-8331466` @dcubed-ojdk Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/19033#is

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v6]

2024-05-09 Thread David Holmes
On Mon, 6 May 2024 21:42:10 GMT, Chris Plummer wrote: >> I don't see how that helps. Access to the field is not protected. > > I guess there could be a race if one thread is destroying this monitor while > another is trying to use it. Thus a thread could be doing something like a > RawMonitorEn

Re: RFR: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on macos-aarch64 [v2]

2024-05-09 Thread Daniel D . Daugherty
On Wed, 8 May 2024 01:19:05 GMT, SendaoYan wrote: >> Hi, >> GHA >> [runner](https://github.com/sendaoYan/jdk-ysd/actions/runs/8881868940/job/24386063136) >> shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent >> fail on macos-aarch64. The testcase has been problemlisted o

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v4]

2024-05-09 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all th

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v3]

2024-05-09 Thread Ioi Lam
On Thu, 9 May 2024 18:31:24 GMT, Matias Saavedra Silva wrote: >> The beginning of the RW region contains pointers to c++ vtables which are >> always located at a fixed offset from the shared base address at runtime. >> This offset can be calculated at dumptime and stored with the read-only >>

Re: RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap [v3]

2024-05-09 Thread Matias Saavedra Silva
> The beginning of the RW region contains pointers to c++ vtables which are > always located at a fixed offset from the shared base address at runtime. > This offset can be calculated at dumptime and stored with the read-only > tables at the top of the RO region. As a further improvement, all th

Integrated: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
On Wed, 8 May 2024 17:05:30 GMT, Kevin Walls wrote: > Remove from zgc problemlists. > Trivial fix. > > This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was > integrated. > > I see the tests passing, including with ZGC. Just ran my own batch of tests > in addition, and it inc

Re: RFR: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
On Wed, 8 May 2024 17:05:30 GMT, Kevin Walls wrote: > Remove from zgc problemlists. > Trivial fix. > > This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was > integrated. > > I see the tests passing, including with ZGC. Just ran my own batch of tests > in addition, and it inc

Re: RFR: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Serguei Spitsyn
On Wed, 8 May 2024 17:05:30 GMT, Kevin Walls wrote: > Remove from zgc problemlists. > Trivial fix. > > This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was > integrated. > > I see the tests passing, including with ZGC. Just ran my own batch of tests > in addition, and it inc

Integrated: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

2024-05-09 Thread Serguei Spitsyn
On Thu, 2 May 2024 10:07:35 GMT, Serguei Spitsyn wrote: > Any event posting code except CFLH, ClassPrepare and ClassLoad events has a > conditional return in case if the event is posted during a VTMS transition. > The CFLH, ClassPrepare and ClassLoad event posting code has just an assert > in

Re: RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

2024-05-09 Thread Serguei Spitsyn
On Thu, 2 May 2024 10:07:35 GMT, Serguei Spitsyn wrote: > Any event posting code except CFLH, ClassPrepare and ClassLoad events has a > conditional return in case if the event is posted during a VTMS transition. > The CFLH, ClassPrepare and ClassLoad event posting code has just an assert > in

Re: RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

2024-05-09 Thread Kevin Walls
On Thu, 2 May 2024 10:07:35 GMT, Serguei Spitsyn wrote: > Any event posting code except CFLH, ClassPrepare and ClassLoad events has a > conditional return in case if the event is posted during a VTMS transition. > The CFLH, ClassPrepare and ClassLoad event posting code has just an assert > in

Re: RFR: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

2024-05-09 Thread Serguei Spitsyn
On Thu, 2 May 2024 10:07:35 GMT, Serguei Spitsyn wrote: > Any event posting code except CFLH, ClassPrepare and ClassLoad events has a > conditional return in case if the event is posted during a VTMS transition. > The CFLH, ClassPrepare and ClassLoad event posting code has just an assert > in

Re: RFR: 8328866: Add raw monitor rank support to the debug agent. [v4]

2024-05-09 Thread Serguei Spitsyn
On Thu, 9 May 2024 01:00:52 GMT, Chris Plummer wrote: >> Okay, thanks. Please, let me list the variants with some analysis. >> We have 3 variants: >> 1. Both monitors are leaf: Entering any monitor while a leaf monitor has >> been entered is a violation (`LEAF RULE` violation). The order does n

RFR: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists

2024-05-09 Thread Kevin Walls
Remove from zgc problemlists. This was omitted when https://bugs.openjdk.org/browse/JDK-8303136 was integrated. I see the tests passing, including with ZGC. Just ran my own batch of tests in addition, and it includes passes with e.g. -XX:+UseZGC -XX:+ZGenerational - Commit messag

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-09 Thread David Holmes
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. I think we may have to restore this to a standalone start-of-release change done after the other start-of-rel

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis [v2]

2024-05-09 Thread Julian Waters
> WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > distributions are supported is still to be clarified, as se

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which