Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v15]

2024-04-08 Thread David Holmes
On Mon, 8 Apr 2024 15:54:30 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is not

Re: RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v3]

2024-04-08 Thread SendaoYan
On Tue, 23 Jan 2024 13:04:43 GMT, SendaoYan wrote: >> 8323640: [TESTBUG]testMemoryFailCount in >> jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail >> because OOM killed > > SendaoYan has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8329432: PopFrame and ForceEarlyReturn functions should use JvmtiHandshake

2024-04-08 Thread Leonid Mesnik
On Tue, 2 Apr 2024 00:22:28 GMT, Serguei Spitsyn wrote: > The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` > classes were introduced in the JDK 22 to unify/simplify the JVM TI functions > supporting implementation of the virtual threads. This enhancement is to > refactor

Re: RFR: 8329491: GetThreadListStackTraces function should use JvmtiHandshake [v2]

2024-04-08 Thread Leonid Mesnik
On Tue, 2 Apr 2024 23:52:33 GMT, Serguei Spitsyn wrote: >> The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` >> classes were introduced in the JDK 22 to unify/simplify the JVM TI functions >> supporting implementation of the virtual threads. This enhancement is to >> refac

Re: RFR: 8329629: GC interfaces should work directly against nmethod instead of CodeBlob

2024-04-08 Thread Erik Ă–sterlund
On Fri, 5 Apr 2024 12:32:30 GMT, Stefan Karlsson wrote: > The GCs scan and handles nmethods and ignores CodeBlobs of other kinds. The I > propose that we stop sending in CodeBlobs to the GCs and make sure to only > give them nmethods. > > I removed `void CodeCache::blobs_do(CodeBlobClosure* f)

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v15]

2024-04-08 Thread Serguei Spitsyn
On Mon, 8 Apr 2024 15:54:30 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is not

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v15]

2024-04-08 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose customer-facing tool. Kevin Walls ha

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v14]

2024-04-08 Thread Kevin Walls
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object > information. > > Not recommended for live production use. Requires UnlockDiagnosticVMOptions > and not included in jcmd help output, to remind us this is not a > general-purpose customer-facing tool. Kevin Walls ha

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v13]

2024-04-08 Thread Kevin Walls
On Thu, 4 Apr 2024 12:46:26 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object >> information. >> >> Not recommended for live production use. Requires UnlockDiagnosticVMOptions >> and not included in jcmd help output, to remind us this is not

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-04-08 Thread Kevin Walls
On Mon, 8 Apr 2024 13:20:03 GMT, Thomas Stuefe wrote: > Thank you for answering our questions. No problem, thanks Thomas and Andrew. 8-) - PR Comment: https://git.openjdk.org/jdk/pull/17655#issuecomment-2043005639

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-04-08 Thread Thomas Stuefe
On Thu, 28 Mar 2024 17:15:26 GMT, Kevin Walls wrote: >>> In my opinion, UnlockDiagnosticVMOptions is not a good enough safeguard >>> since it guards a whole swathe of switches that we may instruct the >>> customer to enable. Once enabled, my experience is that >>> UnlockDiagnosticVMOptions oft

Re: RFR: 8329629: GC interfaces should work directly against nmethod instead of CodeBlob

2024-04-08 Thread Albert Mingkun Yang
On Fri, 5 Apr 2024 12:32:30 GMT, Stefan Karlsson wrote: > The GCs scan and handles nmethods and ignores CodeBlobs of other kinds. The I > propose that we stop sending in CodeBlobs to the GCs and make sure to only > give them nmethods. > > I removed `void CodeCache::blobs_do(CodeBlobClosure* f)

Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v10]

2024-04-08 Thread Matthias Baesken
On Mon, 8 Apr 2024 06:47:09 GMT, Matthias Baesken wrote: > If (3) has defaults, why (4) and (maybe) (5) don't have the same defaults? I could open a separate JBS issue (or issues) for scenario 4 and 5 , if this is desired. - PR Comment: https://git.openjdk.org/jdk/pull/18190#issue