On Thu, 21 Mar 2024 22:25:23 GMT, Alex Menkov wrote:
> The change fixes 3 nsk JDI tests.
> Root cause in all 3 tests is the same - the tests requests JDI event with
> SUSPEND_ALL policy, but event handler thread stops handle incoming event and
> this causes debuggee to hang (suspended by JDI ev
The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes
were introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
implementation of the virtual threads. This enhancement is to refactor JVM TI
`GetCurrentContendedMonitor` function on the base of `Jvmti
On Fri, 15 Mar 2024 20:14:22 GMT, Serguei Spitsyn wrote:
> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were
> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
> implementation of the virtual threads. This enhancement is to refactor JVM TI
> function
On Fri, 8 Mar 2024 20:33:37 GMT, Leonid Mesnik wrote:
> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee.
> There is not need to start debugger in the separate process for each test.
> Also, no need to run it with "-Xcomp" because the main goal is to test
> debugee behavior with
The change fixes 3 nsk JDI tests.
Root cause in all 3 tests is the same - the tests requests JDI event with
SUSPEND_ALL policy, but event handler thread stops handle incoming event and
this causes debuggee to hang (suspended by JDI event).
All 3 tests are updated to exit event handler thread aft
On Thu, 21 Mar 2024 05:02:17 GMT, Serguei Spitsyn wrote:
>> Instrumentation.retransformClasses logic can be described by the following
>> pseudo-code:
>>
>> byte[] newClassBytes = JvmtiClassFileReconstituter.reconstitute(klass);
>> for (Transformer tr = firstTransformer(); tr != null; tr = tr->
On Thu, 21 Mar 2024 18:10:49 GMT, Alex Menkov wrote:
>> RecordComponent class has _attributes_count field.
>> The only user of the field is JvmtiClassFileReconstituter. Incorrect value
>> of the field causes producing incorrect data for Record attribute.
>> Parsing Record attribute ClassFilePars
> RecordComponent class has _attributes_count field.
> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of
> the field causes producing incorrect data for Record attribute.
> Parsing Record attribute ClassFileParser skips unknown attributes and may
> skip RuntimeInvisibl
On Thu, 21 Mar 2024 15:10:14 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: updated test with one more call to notifyAtBreakpoint to reset the
>> native state
>
> test/hotspot/jtreg/
> This PR fixes a synchronization issue in the test:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
>
> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it
> has not reached an expected breakpoint yet.
> The fix is to add a call to the method `ensureAt
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumu
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
> accumulation of unnecessary files in the default temporary direc
On Sat, 9 Mar 2024 05:27:43 GMT, Leonid Mesnik wrote:
>> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee.
>> There is not need to start debugger in the separate process for each test.
>> Also, no need to run it with "-Xcomp" because the main goal is to test
>> debugee behavior w
On Thu, 21 Mar 2024 15:06:58 GMT, Jaikiran Pai wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments
>
> test/jdk/java/util/zip/ZipFile/ZeroDate.java line 95:
>
>> 93:
>> 94: // ensure
On Thu, 21 Mar 2024 14:41:36 GMT, Jaikiran Pai wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java line 57:
>
>> 55:
On Thu, 21 Mar 2024 16:32:09 GMT, Matthias Baesken wrote:
> Hi Andreas , thanks for the details .
> Chris, is this understable for you? We indeed had quite a few user complains
> by cloud env users, that the HeapDumpPath is currently not evaluated in the
> jcmd case/scenario .
I'm still somewh
On Fri, 15 Mar 2024 11:24:53 GMT, Matthias Baesken wrote:
>> Currently jcmd command GC.heap_dump only works with an additionally provided
>> file name.
>> Syntax : GC.heap_dump [options]
>>
>> In case the JVM has the XX - flag HeapDumpPath set, we should support an
>> additional mode where th
On Thu, 21 Mar 2024 01:09:52 GMT, Serguei Spitsyn wrote:
>> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were
>> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
>> implementation of the virtual threads. This enhancement is to refactor JVM
>> TI func
On Thu, 21 Mar 2024 07:11:33 GMT, Serguei Spitsyn wrote:
> This PR fixes a synchronization issue in the test:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
>
> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it
> has not reached an expected breakpo
On Tue, 19 Mar 2024 17:58:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumu
On Tue, 19 Mar 2024 17:58:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumu
On Tue, 19 Mar 2024 17:58:46 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumu
On Tue, 12 Mar 2024 15:05:00 GMT, Richard Reingruber wrote:
> Updated (2024-03-20):
>
> This PR adds switching to `WXWrite` mode before entering the vm where it is
> missing.
>
> With the changes the following jtreg tests succeed with AssertWXAtThreadSync
> enabled.
>
> * hotspot tier 1-4
>
On Wed, 20 Mar 2024 14:06:04 GMT, Richard Reingruber wrote:
>> Updated (2024-03-20):
>>
>> This PR adds switching to `WXWrite` mode before entering the vm where it is
>> missing.
>>
>> With the changes the following jtreg tests succeed with AssertWXAtThreadSync
>> enabled.
>>
>> * hotspot ti
On Thu, 21 Mar 2024 01:09:52 GMT, Serguei Spitsyn wrote:
>> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were
>> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
>> implementation of the virtual threads. This enhancement is to refactor JVM
>> TI func
On Thu, 21 Mar 2024 08:38:34 GMT, Aleksey Shipilev wrote:
>> See the bug for symptoms. The tests are failing because hprof test library
>> is confused about non-compact strings.
>>
>> Additional testing:
>> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now
>> pass
>>
On Wed, 20 Mar 2024 09:53:36 GMT, Aleksey Shipilev wrote:
> See the bug for symptoms. The tests are failing because hprof test library is
> confused about non-compact strings.
>
> Additional testing:
> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now
> pass
> - [x]
On Tue, 19 Mar 2024 16:23:27 GMT, Kevin Walls wrote:
> Client.java has a fixed 30-second timeout on the CountDownLatch to wait for
> 10 notifications.
>
> If it fails, you can't tell if CountDownLatch.await threw, or returned false
> and the app threw InterruptedException, due to the way Clien
> See the bug for symptoms. The tests are failing because hprof test library is
> confused about non-compact strings.
>
> Additional testing:
> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now
> pass
> - [x] `serviceability/HeapDump lib-test:all` with `-XX:+CompactS
This PR fixes a synchronization issue in the test:
`test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it has
not reached an expected breakpoint yet.
The fix is to add a call to the method `ensureAtBreakpoint()
30 matches
Mail list logo
