Re: RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm [v3]

2024-03-08 Thread Leonid Mesnik
> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee. > There is not need to start debugger in the separate process for each test. > Also, no need to run it with "-Xcomp" because the main goal is to test > debugee behavior with different VM flags. > This fix updates tests to run debu

Re: RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm [v2]

2024-03-08 Thread Leonid Mesnik
On Sat, 9 Mar 2024 02:29:13 GMT, Chris Plummer wrote: > If you missed removing a System.exit(), what would the symptoms be if called? > > Can you give us examples of before and after failure modes? The test which is executed as driver and call System.exit() fails with following message: Debug

Re: RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE

2024-03-08 Thread Guoxiong Li
On Fri, 8 Mar 2024 02:54:49 GMT, Alex Menkov wrote: > RecordComponent class has _attributes_count field. > The only user of the field is JvmtiClassFileReconstituter. Incorrect value of > the field causes producing incorrect data for Record attribute. > Parsing Record attribute ClassFileParser sk

Re: RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm [v2]

2024-03-08 Thread Chris Plummer
On Fri, 8 Mar 2024 22:59:46 GMT, Leonid Mesnik wrote: >> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee. >> There is not need to start debugger in the separate process for each test. >> Also, no need to run it with "-Xcomp" because the main goal is to test >> debugee behavior w

Re: RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm [v2]

2024-03-08 Thread Leonid Mesnik
> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee. > There is not need to start debugger in the separate process for each test. > Also, no need to run it with "-Xcomp" because the main goal is to test > debugee behavior with different VM flags. > This fix updates tests to run debu

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v6]

2024-03-08 Thread Weijun Wang
On Thu, 7 Mar 2024 22:00:13 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with three additional > commits since the

RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm

2024-03-08 Thread Leonid Mesnik
vmtestbase nsk/jdi tests run 2 processes: debugger and debugee. There is not need to start debugger in the separate process for each test. Also, no need to run it with "-Xcomp" because the main goal is to test debugee behavior with different VM flags. This fix updates tests to run debugger as dr

Integrated: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly

2024-03-08 Thread Serguei Spitsyn
On Wed, 21 Feb 2024 10:28:49 GMT, Serguei Spitsyn wrote: > The implementation of the JVM TI `GetCurrentContendedMonitor()` does not > match the spec. It can sometimes return an incorrect information about the > contended monitor. Such a behavior does not match the function spec. > With this up

Re: RFR: 8327645: Serial heap dump should not consume double amount of disk space [v2]

2024-03-08 Thread Alex Menkov
On Fri, 8 Mar 2024 02:35:08 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this fix to make serial heap dump only write to a single >> file? >> We highly appreciate the work in >> https://bugs.openjdk.org/browse/JDK-8306441. However, many of our customers >> still need to use serial

Re: RFR: 8308745: ObjArrayKlass::allocate_objArray_klass may call into java while holding a lock [v3]

2024-03-08 Thread Coleen Phillimore
On Fri, 8 Mar 2024 06:17:06 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Missed a word. >> - David's comment fixes. > > src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp line 121: > >>

Integrated: 8308745: ObjArrayKlass::allocate_objArray_klass may call into java while holding a lock

2024-03-08 Thread Coleen Phillimore
On Tue, 6 Feb 2024 22:59:04 GMT, Coleen Phillimore wrote: > This change creates a new sort of native recursive lock that can be held > during JNI and Java calls, which can be used for synchronization while > creating objArrayKlasses at runtime. > > Passes tier1-7. This pull request has now be

Re: RFR: 8308745: ObjArrayKlass::allocate_objArray_klass may call into java while holding a lock [v3]

2024-03-08 Thread Coleen Phillimore
On Thu, 7 Mar 2024 13:21:09 GMT, Coleen Phillimore wrote: >> This change creates a new sort of native recursive lock that can be held >> during JNI and Java calls, which can be used for synchronization while >> creating objArrayKlasses at runtime. >> >> Passes tier1-7. > > Coleen Phillimore ha

Re: RFR: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is [v8]

2024-03-08 Thread Serguei Spitsyn
On Fri, 8 Mar 2024 07:09:53 GMT, Alan Bateman wrote: > Can you look at it again? That test has a copy of `Object.java` so needs to > be updated every time we touch `Object.java`. It's an annoying tax and I hope > there is a JBS issue to replace that test. In this case, it will be benign > beca

Re: RFR: JDK-8327468: Do not restart close if errno is EINTR [macOS/linux]

2024-03-08 Thread Matthias Baesken
On Fri, 8 Mar 2024 10:24:54 GMT, Alan Bateman wrote: >> There are a number of places remaining in the linux/macOS native JDK >> codebase where we use the RESTARTABLE macro with close, but this is unwanted >> on Linux/macOS. > > src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c line 200

Re: RFR: JDK-8327468: Do not restart close if errno is EINTR [macOS/linux]

2024-03-08 Thread Alan Bateman
On Fri, 8 Mar 2024 10:12:06 GMT, Matthias Baesken wrote: > There are a number of places remaining in the linux/macOS native JDK codebase > where we use the RESTARTABLE macro with close, but this is unwanted on > Linux/macOS. src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c line 200:

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-08 Thread Kevin Walls
On Thu, 7 Mar 2024 19:58:35 GMT, Sean Mullan wrote: > Is there any value in keeping `SubjectDelegationPermission` after this > change? If so, I would mark that API deprecated for removal, so that it can > be removed in the next release or two. No, nothing uses SubjectDelegationPermission. Tha

RFR: JDK-8327468: Do not restart close if errno is EINTR [macOS/linux]

2024-03-08 Thread Matthias Baesken
There are a number of places remaining in the linux/macOS native JDK codebase where we use the RESTARTABLE macro with close, but this is unwanted on Linux/macOS. - Commit messages: - JDK-8327468 Changes: https://git.openjdk.org/jdk/pull/18164/files Webrev: https://webrevs.openjdk

Re: RFR: 8327645: Serial heap dump should not consume double amount of disk space [v2]

2024-03-08 Thread Man Cao
On Fri, 8 Mar 2024 03:35:16 GMT, Alex Menkov wrote: >> Man Cao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix failure under -XX:+UseSerialGC > > Heap dumper was switched to always use segments by > [JDK-8299426](https://bugs.openjd

Integrated: JDK-8327444: simplify RESTARTABLE macro usage in JDK codebase

2024-03-08 Thread Matthias Baesken
On Wed, 6 Mar 2024 09:26:25 GMT, Matthias Baesken wrote: > We define the RESTARTABLE macro again and again at a lot of places in the JDK > native codebase. This could be centralized to avoid repeating it again and > again ! This pull request has now been integrated. Changeset: fb4610e6 Author