Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Serguei Spitsyn
On Wed, 21 Feb 2024 22:33:51 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: addressed minor issue with use of []; corrected the test >> desctiption > > test/hotspot/jtreg/vmTestbase/

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Serguei Spitsyn
On Wed, 21 Feb 2024 22:34:19 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: addressed minor issue with use of []; corrected the test >> desctiption > > test/hotspot/jtreg/serviceabil

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Serguei Spitsyn
On Wed, 21 Feb 2024 22:36:31 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: addressed minor issue with use of []; corrected the test >> desctiption > > test/hotspot/jtreg/serviceabil

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Serguei Spitsyn
On Wed, 21 Feb 2024 22:23:27 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: addressed minor issue with use of []; corrected the test >> desctiption > > test/hotspot/jtreg/serviceabil

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Serguei Spitsyn
On Tue, 20 Feb 2024 23:48:06 GMT, Serguei Spitsyn wrote: >> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the >> spec. >> The function returns the following structure: >> >> >> typedef struct { >> jthread owner; >> jint entry_count; >> jint waiter_count; >

Re: RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

2024-02-21 Thread Leonid Mesnik
On Tue, 20 Feb 2024 23:48:06 GMT, Serguei Spitsyn wrote: >> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the >> spec. >> The function returns the following structure: >> >> >> typedef struct { >> jthread owner; >> jint entry_count; >> jint waiter_count; >

Re: RFR: JDK-8325530: Vague error message when com.sun.tools.attach.VirtualMachine fails to load agent library [v2]

2024-02-21 Thread Alex Menkov
> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with > AgentLoadException in 2 cases: > - attach listener returns error; in the case the exception is thrown from > HotSpotVirtualMachine.processCompletionStatus (called from > HotSpotVirtualMachine.execute); > - attach listener returns su

Re: RFR: JDK-8325530: Vague error message when com.sun.tools.attach.VirtualMachine fails to load agent library

2024-02-21 Thread Alex Menkov
On Wed, 21 Feb 2024 21:16:46 GMT, Alex Menkov wrote: >> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with >> AgentLoadException in 2 cases: >> - attach listener returns error; in the case the exception is thrown from >> HotSpotVirtualMachine.processCompletionStatus (called from >> Ho

RFR: JDK-8325530: Vague error message when com.sun.tools.attach.VirtualMachine fails to load agent library

2024-02-21 Thread Alex Menkov
VirtualMachine.loadAgentPath/loadAgentLibrary can fail with AgentLoadException in 2 cases: - attach listener returns error; in the case the exception is thrown from HotSpotVirtualMachine.processCompletionStatus (called from HotSpotVirtualMachine.execute); - attach listener returns success, but r

Re: RFR: JDK-8325530: Vague error message when com.sun.tools.attach.VirtualMachine fails to load agent library

2024-02-21 Thread Alex Menkov
On Wed, 21 Feb 2024 21:13:36 GMT, Alex Menkov wrote: > VirtualMachine.loadAgentPath/loadAgentLibrary can fail with > AgentLoadException in 2 cases: > - attach listener returns error; in the case the exception is thrown from > HotSpotVirtualMachine.processCompletionStatus (called from > HotSpot

Re: RFR: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly

2024-02-21 Thread Alan Bateman
On Wed, 21 Feb 2024 10:28:49 GMT, Serguei Spitsyn wrote: > The implementation of the JVM TI `GetCurrentContendedMonitor` does not match > the spec. It can sometimes return an incorrect information about the > contended monitor. Such a behavior does not match the function spec. > With this upda

RFR: 8256314: JVM TI GetCurrentContendedMonitor is implemented incorrectly

2024-02-21 Thread Serguei Spitsyn
The implementation of the JVM TI `GetCurrentContendedMonitor` does not match the spec. It can sometimes return an incorrect information about the contended monitor. Such a behavior does not match the function spec. With this update the `GetCurrentContendedMonitor` is returning the monitor only

Some JTREG tests crashing on linux-x86 in C2 code

2024-02-21 Thread Jaroslav BachorĂ­k
Hello, I have noticed that some of the JFR and SVC tests are crashing in C2 code with # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (x86_32.ad:1317), pid=5714, tid=5738 # Error: Unimplemented() # # JRE version: OpenJDK Runtime Environment (23.0) (build