On Mon, 12 Feb 2024 18:04:21 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Sat, 10 Feb 2024 04:06:37 GMT, Serguei Spitsyn wrote:
>> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
>> spec.
>> The function returns the following structure:
>>
>>
>> typedef struct {
>> jthread owner;
>> jint entry_count;
>> jint waiter_count;
>
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
> jthread
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Fri, 9 Feb 2024 13:46:06 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious tra
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
On Mon, 12 Feb 2024 17:21:55 GMT, Suchismith Roy wrote:
> > > > The trailing whitespace errors must get fixed (integration blocker).
> > >
> > >
> > > I am unable to resolve this. The spaces seem fine as i see it in the
> > > terminal. Could it be some other error ?
> >
> >
> > Strange. I do
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a f
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a f
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a f
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a f
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Thu, 8 Feb 2024 14:39:24 GMT, Martin Doerr wrote:
> > > The trailing whitespace errors must get fixed (integration blocker).
> >
> >
> > I am unable to resolve this. The spaces seem fine as i see it in the
> > terminal. Could it be some other error ?
>
> Strange. I don't see any whitespace
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
There are several places in hotspot where an internal function should have been
declared static, but isn't.
These were discovered by trying to use the gcc option `-Wmissing-declarations`
and the corresponding clang option `-Wmissing-prototypes`. These warnings check
that a function either:
a)
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a f
On Fri, 9 Feb 2024 18:40:04 GMT, Sebastian Lövdahl wrote:
> One more question, can I do anything to help getting this backported to e.g.
> 21 and 17?
First, I suggest to wait a few weeks in order to see if there are any follow-up
bugs which show up in testing in mainline. Then start backportin
On Thu, 8 Feb 2024 14:47:26 GMT, Joachim Kern wrote:
>> And also `#define statvfs statvfs64` is not necessary with the same
>> explanation as for the `opendir` defines above -- sorry again.
>> The very only difference between statvfs and statvfs64 is that the
>> filesystem ID field in statvfs
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Upda
On Fri, 9 Feb 2024 18:09:11 GMT, Naoto Sato wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious trailing wh
On Mon, 12 Feb 2024 08:01:23 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request with a
On Tue, 23 Jan 2024 15:42:55 GMT, Magnus Ihse Bursie wrote:
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
This pull request has now been integrated.
Changeset: e5cb7
On Thu, 8 Feb 2024 14:47:26 GMT, Joachim Kern wrote:
>> And also `#define statvfs statvfs64` is not necessary with the same
>> explanation as for the `opendir` defines above -- sorry again.
>> The very only difference between statvfs and statvfs64 is that the
>> filesystem ID field in statvfs
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request with a new target base due to a
merge or a rebase. The pull request now c
27 matches
Mail list logo
