Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-18 Thread Chris Plummer
On Fri, 19 Jan 2024 05:40:02 GMT, David Holmes wrote: > I also wonder if we should be looking at a different way to track j.u.c lock > usage, as searching the full heap does not seem at all reasonable. Good question. It looks like bin/jstack does the same, but there is much less cost to doing

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-18 Thread David Holmes
On Thu, 18 Jan 2024 16:19:38 GMT, Chris Plummer wrote: >> I noticed that "clhsdb jstack" seemed to hang when I attached to process >> with a somewhat large heap. It had taken over 10 minutes when I finally >> decided to have a look at the SA process (using bin/jstack), which came up >> with th

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-18 Thread Chris Plummer
On Fri, 19 Jan 2024 02:59:19 GMT, David Holmes wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update clhsdb docs >> - update clhsdb docs > > This seems to be a change that will impact the end user of these too

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-18 Thread David Holmes
On Thu, 18 Jan 2024 16:19:38 GMT, Chris Plummer wrote: >> I noticed that "clhsdb jstack" seemed to hang when I attached to process >> with a somewhat large heap. It had taken over 10 minutes when I finally >> decided to have a look at the SA process (using bin/jstack), which came up >> with th

Re: RFR: 8323546: Cleanup jcmd docs for Compiler.perfmap and VM.cds filename parameter [v6]

2024-01-18 Thread David Holmes
On Wed, 17 Jan 2024 02:26:22 GMT, Chris Plummer wrote: >> The jcmd docs for Compiler.perfmap currently say: >> >> - *filename*: (Optional) The name of the map file (STRING, no default >> value) >> >> However, there is a default, so not only should that be made more clear in >> the above,

Re: RFR: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-01-18 Thread Jiangli Zhou
On Fri, 19 Jan 2024 01:57:58 GMT, David Holmes wrote: > > It seems that we may be converging on using hotspot namespace? > > Based on previous discussions I had been expecting to see a JEP on this after > last US summer. I was surprised to see this PR pop up in this form. Ah, I see. Thanks for

Re: RFR: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-01-18 Thread David Holmes
On Thu, 18 Jan 2024 18:56:23 GMT, Jiangli Zhou wrote: > It seems that we may be converging on using hotspot namespace? Based on previous discussions I had been expecting to see a JEP on this after last US summer. I was surprised to see this PR pop up in this form. - PR Comment: ht

RFR: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB

2024-01-18 Thread Chris Plummer
In PointerFinder.java we have some code to determine if a pointer is in a TLAB, but it only executes for the SerialGC. It should work for all GCs, so I moved the code out of the SerialGC block. I also cleaned up the printing in PointerLocation. java a bit so when not using verbose mode not as m

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v23]

2024-01-18 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

Re: RFR: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-01-18 Thread Jiangli Zhou
On Wed, 17 Jan 2024 23:06:19 GMT, Coleen Phillimore wrote: >> Please review this PR with a simple solution for resolving duplicate >> `Thread` symbol issue. In https://github.com/openjdk/jdk/pull/14808 >> comments, there was an alternative suggestion to redefine the symbol at >> build time, su

Re: RFR: 8324066: "clhsdb jstack" should not by default scan for j.u.c locks because it can be very slow [v2]

2024-01-18 Thread Chris Plummer
> I noticed that "clhsdb jstack" seemed to hang when I attached to process with > a somewhat large heap. It had taken over 10 minutes when I finally decided to > have a look at the SA process (using bin/jstack), which came up with the > following in the stack: > > > at > sun.jvm.hotspot.oops.

Re: RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Chris Plummer
On Thu, 18 Jan 2024 13:14:19 GMT, Daniel D. Daugherty wrote: > It is only with extremely high > stress levels that we see these slowdebug timeouts. I would have considered this as a reason to be using timeoutfactor and not increase the timeouts. Although I don't think what to use as the defaul

[jdk22] Integrated: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 15:22:19 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. This pull request has now been integrated. Changeset: 79c3d47c Author:Daniel D. Daugherty URL: https://git.ope

Re: [jdk22] RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 15:36:29 GMT, Albert Mingkun Yang wrote: >> Trivial fixes to adjust more monitoring test timeouts. >> >> See the bug report for the gory timeout details. > > Marked as reviewed by ayang (Reviewer). @albertnetymk and @kevinjwalls - Thanks for the fast reviews! -

Re: [jdk22] RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Kevin Walls
On Thu, 18 Jan 2024 15:22:19 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. Marked as reviewed by kevinw (Committer). - PR Review: https://git.openjdk.org/jdk22/pull/92#pullrequestrevie

Re: [jdk22] RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Albert Mingkun Yang
On Thu, 18 Jan 2024 15:22:19 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. Marked as reviewed by ayang (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/92#pullrequestreview-

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v22]

2024-01-18 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

[jdk22] RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Daniel D . Daugherty
Trivial fixes to adjust more monitoring test timeouts. See the bug report for the gory timeout details. - Commit messages: - Backport 806ffb108572236cb9908ad6f93d7b09dfc6a600 Changes: https://git.openjdk.org/jdk22/pull/92/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=92

Re: RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 05:16:33 GMT, Chris Plummer wrote: >> Trivial fixes to adjust more monitoring test timeouts. >> >> See the bug report for the gory timeout details. > > Shouldn't we use a larger timeoutfactor for slowdebug builds? @plummercj, @kevinjwalls and @sspitsyn - Thanks for the revi

Integrated: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 01:28:09 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. This pull request has now been integrated. Changeset: 806ffb10 Author:Daniel D. Daugherty URL: https://git.ope

Re: RFR: 8324082: more monitoring test timeout adjustments [v2]

2024-01-18 Thread Daniel D . Daugherty
> Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Update copyright years. - Changes: - all: https://gi

Re: RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Serguei Spitsyn
On Thu, 18 Jan 2024 01:28:09 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. Looks good. - Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17478#p

Re: RFR: 8324082: more monitoring test timeout adjustments

2024-01-18 Thread Kevin Walls
On Thu, 18 Jan 2024 01:28:09 GMT, Daniel D. Daugherty wrote: > Trivial fixes to adjust more monitoring test timeouts. > > See the bug report for the gory timeout details. Looks good. Maybe we could be cleverer with different timeout for different builds, but I like the simple update... 8-)

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2024-01-18 Thread Taizo Kurashige
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote: >> Thank you for telling me about how to jcmd.1 nroff file is managed. >> I will split this change into separate subtasks. Then if one of the Oracle >> engineers finds that subtask, will he/she work on it like any other bug? > > Yes it will b