On Tue, 16 Jan 2024 02:25:32 GMT, Chris Plummer wrote:
> Sorry I missed your response, although I still honestly don't know when/where
> it was.
No I'm sorry, I can't find it either. I must have forgotten to click the right
button at some point. :( My concern was that once we were changing fu
On Tue, 16 Jan 2024 02:21:56 GMT, Chris Plummer wrote:
>> But that only works if `init_value` is never called, else `is_set` will be
>> true. This seems a rather fragile way to have the "default string" available
>> for the help command, but avoiding actually using it as a default value.
>>
>>
On Mon, 15 Jan 2024 01:31:33 GMT, David Holmes wrote:
> > > And I still think the VM.CDS change show have its own issue (if not PR).
> >
> >
> > Yes, and I asked why that is the case. The VM.cds changes are very much
> > related to the Compiler.perfmap changes. I think it's actually correct to
On Tue, 16 Jan 2024 01:47:51 GMT, David Holmes wrote:
>> My suggestion is to be used in combination with this change:
>>
>>
>> _filename("filename", "Name of the map file", "STRING", false,
>> DEFAULT_PERFMAP_FILENAME)
>>
>>
>> So the help message will be printed as:
>>
>>
>> *filename*:
On Mon, 15 Jan 2024 08:13:10 GMT, Ioi Lam wrote:
>> @iklam but IIUC that does not address the issue of updationg the help output.
>
> My suggestion is to be used in combination with this change:
>
>
> _filename("filename", "Name of the map file", "STRING", false,
> DEFAULT_PERFMAP_FILENAME)
>
On Thu, 21 Sep 2023 11:46:19 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Classfile object update
>> - Merge branch 'master' into invoke-test-classfile
>> - Merge bra
> The changes for JDK-8287061 didn't update the SA decoding logic and there are
> other places where the decoding has gotten out of sync with HotSpot. Some of
> them can't be tested because they are part of JVMCI but I've added a directed
> test for the JDK-8287061 code and a more brute force t
On Wed, 25 Oct 2023 17:02:03 GMT, Kevin Walls wrote:
> Remove the MLet feature and its tests.
>
> Some tests use MLet classes but are not testing MLets. These are updated, to
> use another test MBean or an MBean which is a URLClassLoader, e.g.
> test/jdk/javax/management/MBeanServer/PostExcept
On Thu, 11 Jan 2024 20:59:05 GMT, Kevin Walls wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/PostE
On Fri, 12 Jan 2024 14:31:54 GMT, Lei Zaakjyu wrote:
> follow up 8234502.
This pull request has now been integrated.
Changeset: e66a76f5
Author:Lei Zaakjyu
Committer: Albert Mingkun Yang
URL:
https://git.openjdk.org/jdk/commit/e66a76f52410d8a4d6aadbd424679409650da9ae
Stats: 57
On Fri, 12 Jan 2024 21:22:35 GMT, Alex Menkov wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> following proposals of alexmenkov
>
> src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 400:
>
>> 398
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Mon, 15 Jan 2024 07:32:31 GMT, David Holmes wrote:
>> This check is problematic:
>>
>>
>> if (strncmp(filename, DEFAULT_PERFMAP_FILENAME,
>> strlen(DEFAULT_PERFMAP_FILENAME)) == 0)
>>
>>
>> Because it cannot tell whether `filename` was explicitly given by the user.
>> As a result, if the
13 matches
Mail list logo
