see 'https://github.com/openjdk/jdk/pull/17398#pullrequestreview-1819022919'
-
Commit messages:
- update copyright
Changes: https://git.openjdk.org/jdk/pull/17412/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17412&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17398#issuec
On Fri, 12 Jan 2024 20:49:47 GMT, Chris Plummer wrote:
> SA change looks good. But...
>
> It looks like all the copyright updates to 2024 are missing from this PR and
> the previous PR. We may need another PR for that. Also, the two new files in
> that PR should have a copyright that just says
On Fri, 12 Jan 2024 21:26:36 GMT, Tom Rodriguez wrote:
> The changes for JDK-8287061 didn't update the SA decoding logic and there are
> other places where the decoding has gotten out of sync with HotSpot. Some of
> them can't be tested because they are part of JVMCI but I've added a directed
The changes for JDK-8287061 didn't update the SA decoding logic and there are
other places where the decoding has gotten out of sync with HotSpot. Some of
them can't be tested because they are part of JVMCI but I've added a directed
test for the JDK-8287061 code and a more brute force test that
On Fri, 12 Jan 2024 11:28:32 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
SA change looks good. But...
It looks like all the copyright updates to 2024 are missing from t
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
On Fri, 12 Jan 2024 03:31:37 GMT, sendaoYan wrote:
> Reviewed-by: Yi Yang
The test case before this PR has a maximum heap of 64MB and applies for 8M of
memory each time in the for loop. When applying for memory for the sixth time,
it was killed by the docker container because of OOM,
jdk.inte
On Fri, 12 Jan 2024 15:26:34 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
Marked as reviewed by ayang (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/p
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/5c9a5e96..ed54e312
Webrevs:
On Fri, 12 Jan 2024 15:15:41 GMT, Lei Zaakjyu wrote:
>> follow up 8234502.
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix indent
src/hotspot/share/gc/serial/serialHeap.cpp line 81:
> 79: #include "utilities/formatBuff
> follow up 8234502.
Lei Zaakjyu has updated the pull request incrementally with one additional
commit since the last revision:
fix indent
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17398/files
- new: https://git.openjdk.org/jdk/pull/17398/files/6d423eee..5c9a5e96
We
On Fri, 12 Jan 2024 14:31:54 GMT, Lei Zaakjyu wrote:
> follow up 8234502.
Some indentations of arg list are broken, e.g. `SerialHeap::collect_generation`.
-
PR Comment: https://git.openjdk.org/jdk/pull/17398#issuecomment-1889401934
follow up 8234502.
-
Commit messages:
- fix header ordering
Changes: https://git.openjdk.org/jdk/pull/17398/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17398&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323660
Stats: 33 lines in 4 files changed: 15 ins; 18 de
On Thu, 11 Jan 2024 20:59:05 GMT, Kevin Walls wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/PostE
On Wed, 26 Jan 2022 16:38:41 GMT, Alex Menkov wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplified the test, added comments
>
> Simplified the test (a lot of code was useful during development/debugging,
> bu
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Fri, 12 Jan 2024 02:07:47 GMT, Chris Plummer wrote:
>> The jcmd docs for Compiler.perfmap currently say:
>>
>> - *filename*: (Optional) The name of the map file (STRING, no default
>> value)
>>
>> However, there is a default, so not only should that be made more clear in
>> the above,
On Fri, 12 Jan 2024 00:47:20 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [2806adee](https://github.com/openjdk/jdk/commit/2806adee2d8cca6bc215f285888631799bd02eac)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The c
On Fri, 12 Jan 2024 00:47:20 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a clean backport of commit
> [2806adee](https://github.com/openjdk/jdk/commit/2806adee2d8cca6bc215f285888631799bd02eac)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The c
On Fri, 12 Jan 2024 08:38:48 GMT, Christoph Langer wrote:
> @MBaesken, I believe with this idea/PR, #16561 could be closed, right?
Yes we want to use inet_pton ; the other one was just a temporary thing (when
I think about it , I could have closed this for quite some time ) .
-
P
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
> famil
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
25 matches
Mail list logo
