On Mon, 8 Jan 2024 20:16:50 GMT, Chris Plummer wrote:
> Fix some broken links and other minor cleanups:
>
> There are a few broken links in the javadoc for ObjectReference.java. For
> example:
>
>
> * Not all target VMs support this operation. See
> * VirtualMachine#canGetMonitorIn
On Mon, 8 Jan 2024 20:16:50 GMT, Chris Plummer wrote:
> Fix some broken links and other minor cleanups:
>
> There are a few broken links in the javadoc for ObjectReference.java. For
> example:
>
>
> * Not all target VMs support this operation. See
> * VirtualMachine#canGetMonitorIn
Hi all,
This pull request contains a backport of commit
[dd8ae616](https://github.com/openjdk/jdk/commit/dd8ae616437398f957f9b4f09cf2c7f1d0bd0938)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Alex Menkov on 9 Jan 2024 and was
revie
On Wed, 10 Jan 2024 01:53:02 GMT, Alex Menkov wrote:
> The change fixes workaround introduced by
> [[JDK-8250630]](https://bugs.openjdk.org/browse/JDK-8250630).
> The root cause of the test failure was identified by JDK-8250630:
> On Apline Linux getaddrinfo function returns 2 entries for "any"
On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 23:12:40 GMT, Alex Menkov wrote:
>> Ok. I see now how the old code was actually reversing the order to undo the
>> reversing that was already done.
>
>> I think the indent here should be 4, not 6.
>
> I updated indentation to be consistent with other multi-line statements in
On Wed, 10 Jan 2024 21:40:08 GMT, Chris Plummer wrote:
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but als
On Wed, 10 Jan 2024 22:34:57 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 17:28:33 GMT, Chris Plummer wrote:
>> FieldStream from reflectionUtils iterates fields in reverse order, so
>> reversing again was previously needed here. JavaFieldStream from
>> fieldStreams (and the new FilteredJavaFieldStream) iterate in the order the
>> fields actually
On Wed, 10 Jan 2024 21:40:08 GMT, Chris Plummer wrote:
> The jcmd docs for Compiler.perfmap currently say:
>
> - *filename*: (Optional) The name of the map file (STRING, no default
> value)
>
> However, there is a default, so not only should that be made more clear in
> the above, but als
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details).
> The cha
The jcmd docs for Compiler.perfmap currently say:
- *filename*: (Optional) The name of the map file (STRING, no default value)
However, there is a default, so not only should that be made more clear in the
above, but also some descriptive text as to how the default is generated should
be ad
On Wed, 10 Jan 2024 11:49:05 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl handles.
>>
>> This cause
On Wed, 20 Dec 2023 21:28:04 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f8e4e0a](https://github.com/openjdk/jdk/commit/0f8e4e0a81257c678e948c341a241dc0b810494f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 10 Jan 2024 10:16:01 GMT, Hannes Greule wrote:
>> You said in the description that the order was reversed, but I don't see
>> where that is getting fixed. It seems it was partially fixed by
>> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692), but it is only
>> preserving the
On Wed, 10 Jan 2024 16:50:22 GMT, Kevin Walls wrote:
>> My thinking is that this tests for a leak when an MBean is created using a
>> ClassLoader which is also an MBean. MLet was such a ready-to-use
>> ClassLoader. We no longer have MLets, but it's still possible to register an
>> MBean that i
On Wed, 10 Jan 2024 16:11:35 GMT, Daniel Fuchs wrote:
>> I didn't see great value in it, as we no longer provide an MBean which is a
>> ClassLoader.
>> Having a test MBean that extends URLClassLoader, and calling its
>> loadClass()... is basically testing URLClassLoader? 8-)
>> Implementing Pri
On Wed, 10 Jan 2024 15:15:36 GMT, Kevin Walls wrote:
>> test/jdk/javax/management/Introspector/ClassLeakTest.java line 55:
>>
>>> 53: ObjectName testName = new ObjectName("x:name=Test");
>>> 54: Test mbean = new Test();
>>> 55: mbs.registerMBean(mbean, testName);
>>
>> I
On Wed, 10 Jan 2024 13:55:51 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary MLET_ Properties
>
> test/jdk/javax/management/Introspector/ClassLeakTest.java line 55:
>
>> 53:
On Tue, 9 Jan 2024 23:48:35 GMT, Serguei Spitsyn wrote:
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread`
> and `SetFramePopClosure::do_vthread`.
>
> Testing:
> - TBD to submit tiers: 1-5
This pull request has now been integrated.
Changeset: 2806adee
Author:Se
On Thu, 4 Jan 2024 10:48:38 GMT, Kevin Walls wrote:
>> Remove the MLet feature and its tests.
>>
>> Some tests use MLet classes but are not testing MLets. These are updated,
>> to use another test MBean or an MBean which is a URLClassLoader, e.g.
>> test/jdk/javax/management/MBeanServer/PostEx
On Fri, 3 Nov 2023 07:22:26 GMT, Johannes Bechberger
wrote:
>> Fix race condition in debugger port selection, introduced with
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>>
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> Johannes Bechberger has up
> On AIX, repeated calls to dlopen referring to the same shared library may
> result in different, unique dl handles to be returned from libc. In that it
> differs from typical libc implementations that cache dl handles.
>
> This causes problems in the JVM with code that assumes equality of hand
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread`
> and `SetFramePopClosure::do_vthread`.
>
> Testing:
> - TBD to submit tiers: 1-5
Serguei Spitsyn has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the un
On Wed, 20 Dec 2023 21:28:04 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f8e4e0a](https://github.com/openjdk/jdk/commit/0f8e4e0a81257c678e948c341a241dc0b810494f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 10 Jan 2024 05:28:39 GMT, Chris Plummer wrote:
>> src/hotspot/share/prims/jvmtiEnv.cpp line 2910:
>>
>>> 2908: result_list[i] = jfieldIDWorkaround::to_jfieldID(
>>> 2909: ik, flds.offset(),
>>> 2910: flds.access_flags().is_static());
>>
>> I think the indent here
On Tue, 9 Jan 2024 23:48:35 GMT, Serguei Spitsyn wrote:
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread`
> and `SetFramePopClosure::do_vthread`.
>
> Testing:
> - TBD to submit tiers: 1-5
Alex and Chris, thank you for review!
Chris, I'll add similar comments as you
On Wed, 10 Jan 2024 01:53:02 GMT, Alex Menkov wrote:
> The change fixes workaround introduced by
> [[JDK-8250630]](https://bugs.openjdk.org/browse/JDK-8250630).
> The root cause of the test failure was identified by JDK-8250630:
> On Apline Linux getaddrinfo function returns 2 entries for "any"
On Wed, 20 Dec 2023 21:28:04 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f8e4e0a](https://github.com/openjdk/jdk/commit/0f8e4e0a81257c678e948c341a241dc0b810494f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
29 matches
Mail list logo
