Re: RFR: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935

2023-12-03 Thread David Holmes
On Sat, 2 Dec 2023 17:15:57 GMT, Daniel D. Daugherty wrote: > In the fix for the following bug: > > [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one > JvmtiThreadState is created for one JavaThread associated with attached > native thread > > JvmtiThreadState::state_

Re: RFR: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935

2023-12-03 Thread Jiangli Zhou
On Sat, 2 Dec 2023 17:15:57 GMT, Daniel D. Daugherty wrote: > In the fix for the following bug: > > [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one > JvmtiThreadState is created for one JavaThread associated with attached > native thread > > JvmtiThreadState::state_

Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS [v2]

2023-12-03 Thread David Holmes
> Please review this simple clarification to the JVM TI spec regarding use of > `JAVA_TOOL_OPTIONS` in regards to module options and their format. > > I do not believe this clarification needs a CSR request. > > Thanks. David Holmes has updated the pull request with a new target base due to a m

Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS

2023-12-03 Thread David Holmes
On Thu, 30 Nov 2023 08:42:35 GMT, Alan Bateman wrote: >> Please review this simple clarification to the JVM TI spec regarding use of >> `JAVA_TOOL_OPTIONS` in regards to module options and their format. >> >> I do not believe this clarification needs a CSR request. >> >> Thanks. > > src/hotspo

Re: RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v11]

2023-12-03 Thread David Holmes
On Wed, 29 Nov 2023 11:49:31 GMT, Jaroslav Bachorik wrote: >> Please, review this fix for a corner case handling of `jmethodID` values. >> >> The issue is related to the interplay between `jmethodID` values and method >> redefinitions. Each `jmethodID` value is effectively a pointer to a `Meth