On Wed, 8 Nov 2023 16:11:44 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1974:
>>
>>> 1972:
>>> 1973: if (java_lang_VirtualThread::is_instance(target_h())) { // virtual
>>> thread
>>> 1974: if (!JvmtiEnvBase::is_vthread_alive(target_h())) {
>>
>> There is
> The handshakes support for virtual threads is needed to simplify the JVMTI
> implementation for virtual threads. There is a significant duplication in the
> JVMTI code to differentiate code intended to support platform, virtual
> threads or both. The handshakes are unified, so it is enough to
On Tue, 7 Nov 2023 11:40:02 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
>
> The handshakes support for virtual threads is needed to simplify the JVMTI
> implementation for virtual threads. There is a significant duplication in the
> JVMTI code to differentiate code intended to support platform, virtual
> threads or both. The handshakes are unified, so it is enough to
On Wed, 15 Nov 2023 09:38:25 GMT, Afshin Zafari wrote:
>>> I still approve of this patch as it's better than what we had before. There
>>> are a lot of suggested improvements that can be done either in this PR or
>>> in a future RFE. `git blame` shows that this hasn't been touched since
>>> 20
On Tue, 7 Nov 2023 11:40:02 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
>
On Tue, 14 Nov 2023 21:54:06 GMT, Alex Menkov wrote:
> The change impelements dumping of unmounted virtual threads data (stack
> traces and stack references).
> Unmounted vthreads can be detected only by iterating over the heap, but hprof
> stack trace records (HPROF_FRAME/HPROF_TRACE) should b
On Mon, 13 Nov 2023 10:11:26 GMT, Long Yang wrote:
>> I would like to fix this.
>>
>> Create 4096 threads, and the stack depth of each thread is 256.
>> After running jmx.dumpAllThreads(true, true), the RSS reaches 5.3GiB.
>> After optimization, the RSS is 250MiB.
>>
>> I would appreciate it
On Tue, 14 Nov 2023 21:33:37 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update parallel workers time after Remark
src/hotspo
On Wed, 15 Nov 2023 23:50:02 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix whitespace
Overall looks good, a few details cou
On Wed, 15 Nov 2023 09:36:47 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update parallel workers time after Remark
>
> Thanks for addressing my comments. I have a few more things:
>
> - I
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: https://git.open
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Move vm and conc_dedup counters to cpuTimeCounters class
- Revert test changes and fix whitespace issues
--
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko
wrote:
>> Zero'ing memory of extension event callbacks
>
> Roman Marchenko has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixing review comments
Sure. Here's the relevant sub-section from
On Wed, 15 Nov 2023 02:24:17 GMT, Alex Menkov wrote:
> ProblemList 2 nsk jdi tests with Xcomp on all platforms
This pull request has now been integrated.
Changeset: 536b1cee
Author:Alex Menkov
URL:
https://git.openjdk.org/jdk/commit/536b1cee249ec50d6270ced3ba52ed3848c80a97
Stats:
On Wed, 15 Nov 2023 02:24:17 GMT, Alex Menkov wrote:
> ProblemList 2 nsk jdi tests with Xcomp on all platforms
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16667#pullrequestreview-1732508536
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
On Tue, 24 Oct 2023 07:08:07 GMT, Thomas Stuefe wrote:
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
This pull request has now been integrated.
Changeset: 2e34a2eb
Author:
On Wed, 15 Nov 2023 06:22:58 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Sun, 29 Oct 2023 08:07:55 GMT, Kim Barrett wrote:
>> I still approve of this patch as it's better than what we had before. There
>> are a lot of suggested improvements that can be done either in this PR or in
>> a future RFE. `git blame` shows that this hasn't been touched since 2008, so
>>
On Wed, 15 Nov 2023 06:22:58 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request incrementally with one ad
On Tue, 14 Nov 2023 21:33:37 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update parallel workers time after Remark
Thanks for
22 matches
Mail list logo
