On Tue, 14 Nov 2023 20:51:22 GMT, Daniel D. Daugherty
wrote:
>> Roman Marchenko has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing review comments
>
> Just a heads up that HotSpot code normally requires two reviews (1 from a
> (R)e
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request incrementally with one additional
commit since the last revision:
feedback shade
--
On Tue, 14 Nov 2023 15:03:42 GMT, Aleksey Shipilev wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into
>> JDK-8318671-Potential-uninitialized-uintx-value-after-
On Wed, 15 Nov 2023 02:24:17 GMT, Alex Menkov wrote:
> ProblemList 2 nsk jdi tests with Xcomp on all platforms
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16667#pullrequestreview-1731230983
ProblemList 2 nsk jdi tests with Xcomp on all platforms
-
Commit messages:
- _cur_stack_depth_pl
Changes: https://git.openjdk.org/jdk/pull/16667/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16667&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8320130
Stats: 3 lin
The change impelements dumping of unmounted virtual threads data (stack traces
and stack references).
Unmounted vthreads can be detected only by iterating over the heap, but hprof
stack trace records (HPROF_FRAME/HPROF_TRACE) should be written before
HPROF_HEAP_DUMP/HPROF_HEAP_DUMP_SEGMENT.
Heap
On Mon, 13 Nov 2023 23:04:19 GMT, Man Cao wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Don't try to setup_jvmti_thread_state for obj allocation sampling if the
>> current thread is attaching from native and is
On Sat, 11 Nov 2023 00:23:28 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refactor ConcurrentRefine logic
> - Make CPUTimeCo
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Update parallel workers time after Remark
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/file
> Please review JvmtiThreadState::state_for_while_locked change to handle the
> state->get_thread_oop() null case. Please see
> https://bugs.openjdk.org/browse/JDK-8319935 for details.
Jiangli Zhou has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko
wrote:
>> Zero'ing memory of extension event callbacks
>
> Roman Marchenko has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixing review comments
Doing a post integration review.
This is
On Tue, 14 Nov 2023 03:10:20 GMT, David Holmes wrote:
> Is this a case where the code should be checking for `is_attaching_via_jni()`?
That's a good question. I think maybe we should try to completely avoid the
situation where a 'partial' `JvmtiThreadState` is created when a native thread
is a
On Mon, 13 Nov 2023 13:33:26 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request with a new target base du
On Thu, 28 Sep 2023 23:40:58 GMT, Chris Plummer wrote:
>> Please review this change to fix the operands of the bytecodes that operate
>> on fields when dumping a class using SA.
>>
>> Testing: hotspot_serviceability
>>
>> I have also verified that
>> `test/hotspot/jtreg/serviceability/sa/Clhs
On Thu, 28 Sep 2023 21:23:25 GMT, Ashutosh Mehra wrote:
> Please review this change to fix the operands of the bytecodes that operate
> on fields when dumping a class using SA.
>
> Testing: hotspot_serviceability
>
> I have also verified that
> `test/hotspot/jtreg/serviceability/sa/ClhsdbDump
On Tue, 14 Nov 2023 06:50:58 GMT, Roman Marchenko
wrote:
> Zero'ing memory of extension event callbacks
This pull request has now been integrated.
Changeset: 97ea5bf0
Author:Roman Marchenko
Committer: Yuri Nesterenko
URL:
https://git.openjdk.org/jdk/commit/97ea5bf0ffafaf8009c19483
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko
wrote:
>> Zero'ing memory of extension event callbacks
>
> Roman Marchenko has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixing review comments
The previous test run was OK https://githu
On Tue, 14 Nov 2023 07:42:08 GMT, David Holmes wrote:
>> Roman Marchenko has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing review comments
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 217:
>
>> 215: // all callbacks initiall
> Zero'ing memory of extension event callbacks
Roman Marchenko has updated the pull request incrementally with one additional
commit since the last revision:
Fixing review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16647/files
- new: https://git.openjdk.org/j
On Mon, 13 Nov 2023 13:33:26 GMT, Thomas Stuefe wrote:
>> When using 'MemStat' CompileCommand, we accidentally register the command if
>> an invalid suboption had been specified. Fixed, added regression test
>> (verified).
>
> Thomas Stuefe has updated the pull request with a new target base du
20 matches
Mail list logo
