Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

2023-10-31 Thread Thomas Stuefe
On Tue, 31 Oct 2023 16:58:19 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix various builds > > src/hotspot/os/linux/memMapPrinter_linux.cpp line 59: > >> 57: void print_OS_specific_deta

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

2023-10-31 Thread Thomas Stuefe
On Mon, 30 Oct 2023 17:31:30 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix various builds > > src/hotspot/os/linux/memMapPrinter_linux.cpp line 83: > >> 81: char line[linesize]; >> 8

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

2023-10-31 Thread Thomas Stuefe
On Mon, 30 Oct 2023 10:29:56 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix various builds > > src/hotspot/os/linux/memMapPrinter_linux.cpp line 80: > >> 78: FILE* f = os::fopen("/proc/se

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v5]

2023-10-31 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v35]

2023-10-31 Thread Man Cao
On Tue, 31 Oct 2023 04:23:13 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Replace NULL with nullptr LGTM still, thanks! -

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v4]

2023-10-31 Thread Thomas Schatzl
On Tue, 31 Oct 2023 18:08:00 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there i

Re: RFR: JDK-8318957: enhance agentlib:jdwp help output by info about allow option [v2]

2023-10-31 Thread Chris Plummer
On Mon, 30 Oct 2023 08:55:55 GMT, Matthias Baesken wrote: >> The allow option of agentlib:jdwp has been introduced a long time ago (see >> JDK-8061228) and is documented here : >> https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options >> However it is

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v4]

2023-10-31 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

2023-10-31 Thread Gerard Ziemski
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: JDK-8318957: enhance agentlib:jdwp help output by info about allow option [v2]

2023-10-31 Thread Matthias Baesken
On Mon, 30 Oct 2023 08:55:55 GMT, Matthias Baesken wrote: >> The allow option of agentlib:jdwp has been introduced a long time ago (see >> JDK-8061228) and is documented here : >> https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options >> However it is

Re: RFR: JDK-8318671: Potential uninitialized uintx value after JDK-8317683 [v4]

2023-10-31 Thread Tobias Hartmann
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote: >> When using 'MemStat' CompileCommand, we accidentally register the command if >> an invalid suboption had been specified. Fixed, added regression test >> (verified). > > Thomas Stuefe has updated the pull request incrementally with one ad