Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v7]

On Thu, 26 Oct 2023 02:24:49 GMT, David Holmes wrote: >> You can bind a non-const reference to a const one but not the other way. > > Sorry I was unclear: what is the advantage of a reference here? Is it just to > avoid copying @dholmes-ora Yes it helps avoid copying, especially if the copy con

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v6]

> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

On Fri, 27 Oct 2023 09:42:19 GMT, Johan Sjölen wrote: >> Thomas Stuefe has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge master and solve merge conflicts >> - small fixes >> - start from VM op; show mo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v5]

> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

On Fri, 27 Oct 2023 20:20:49 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > src/hotspot/share/services/memMapPrinter.cpp line 95: >

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

On Fri, 27 Oct 2023 15:42:06 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > Taking a look... @gerard-ziemski @jdksjolen I take thi

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

On Fri, 27 Oct 2023 22:01:07 GMT, Gerard Ziemski wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix spelling >> - timeout fuse >> - Feedback Johan > > src/hotspot/share/services/memMapPrinter.cpp line 294: