Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-22 Thread Thomas Stuefe
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools o

Re: RFR: 8318447: Move NMT source code to own subdirectory [v5]

2023-10-22 Thread David Holmes
On Fri, 20 Oct 2023 12:49:46 GMT, Johan Sjölen wrote: >> I think that NMT is deserving of its own subdirectory. Can we do a review of >> the changes before I fix the merge conflicts? >> >> 1. Moved all the nmt source code from services/ to nmt/ >> 2. Renamed all the include statements and sorte

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-22 Thread Thomas Stuefe
On Mon, 23 Oct 2023 01:39:16 GMT, Chris Plummer wrote: > The hs_err file includes a dump of the maps file. It seems these annotations > would be useful there also. I thought about this too. The problem is the printing may take long since it is O^2 (iterate through VMAs, for each one iterate NM

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v6]

2023-10-22 Thread David Holmes
On Fri, 20 Oct 2023 08:37:11 GMT, Afshin Zafari wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> first arg of `find` casted to `uint*` > > @dholmes-ora, any more comments? @afshin-zafari could you merge (not reba

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-22 Thread Chris Plummer
On Sun, 22 Oct 2023 10:08:49 GMT, Thomas Stuefe wrote: > Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out th

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-22 Thread Kimura Yukihiro
On Thu, 19 Oct 2023 07:54:47 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the test dose not work as intended. >> Could someone please review it? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request incrementally with one > additional com

RFR: JDK-8318636: Add jcmd to print annotated process memory map

2023-10-22 Thread Thomas Stuefe
Analysts and supporters often use /proc/xx/maps to make sense of the memory footprint of a process. Interpreting the memory map correctly can help when used as a complement to other tools (e.g. NMT). There even exist tools out there that attempt to annotate the process memory map with JVM infor