Re: RFR: 8318447: Move NMT source code to own subdirectory

2023-10-19 Thread David Holmes
On Thu, 19 Oct 2023 20:06:50 GMT, Johan Sjölen wrote: > I think that NMT is deserving of its own subdirectory. Can we do a review of > the changes before I fix the merge conflicts? > > 1. Moved all the nmt source code from services/ to nmt/ > 2. Renamed all the include statements and sorted the

Re: RFR: 8318447: Move NMT source code to own subdirectory

2023-10-19 Thread Stefan Karlsson
On Thu, 19 Oct 2023 20:06:50 GMT, Johan Sjölen wrote: > I think that NMT is deserving of its own subdirectory. Can we do a review of > the changes before I fix the merge conflicts? > > 1. Moved all the nmt source code from services/ to nmt/ > 2. Renamed all the include statements and sorted the

Integrated: 8312777: notifyJvmtiMount before notifyJvmtiUnmount

2023-10-19 Thread Alan Bateman
On Sat, 14 Oct 2023 18:07:45 GMT, Alan Bateman wrote: > JVMTI is notified after a virtual thread unmounts. Right not, this > notification is done after the virtual thread has finished parking or > yielding so it's possible for the virtual to continue, and be mounted on a > different carrier, b

Re: RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.

2023-10-19 Thread Chris Plummer
On Fri, 20 Oct 2023 03:20:44 GMT, Leonid Mesnik wrote: > There are several failure with reason > "Cannot invoke "String.equals(Object)" because "" is null" > which really caused by reading the command from debugee via socket. > Like: > > String command = pipe.readln(); > > if (!

Re: RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.

2023-10-19 Thread Serguei Spitsyn
On Fri, 20 Oct 2023 03:20:44 GMT, Leonid Mesnik wrote: > There are several failure with reason > "Cannot invoke "String.equals(Object)" because "" is null" > which really caused by reading the command from debugee via socket. > Like: > > String command = pipe.readln(); > > if (!

Re: RFR: 8318484: Initial version of cdsConfig.hpp

2023-10-19 Thread Serguei Spitsyn
On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam wrote: > This is the first step for [JDK-8318483 - Move CDS configuration management > into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483) > > - Remove `Arguments::is_dumping_archive()` and `Arguments > assert_is_dumping_archive()` > - Add

RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.

2023-10-19 Thread Leonid Mesnik
There are several failure with reason "Cannot invoke "String.equals(Object)" because "" is null" which really caused by reading the command from debugee via socket. Like: String command = pipe.readln(); if (!command.equals(AbstractDebuggeeTest.COMMAND_READY)) { setSucc

Re: RFR: 8318484: Initial version of cdsConfig.hpp

2023-10-19 Thread Ioi Lam
On Thu, 19 Oct 2023 22:21:30 GMT, Calvin Cheung wrote: >> This is the first step for [JDK-8318483 - Move CDS configuration management >> into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483) >> >> - Remove `Arguments::is_dumping_archive()` and `Arguments >> assert_is_dumping_archive

Integrated: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-19 Thread Hannes Greule
On Fri, 6 Oct 2023 20:56:13 GMT, Hannes Greule wrote: > See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. This pull request has now been integrated. Changes

Re: RFR: 8318484: Initial version of cdsConfig.hpp

2023-10-19 Thread Calvin Cheung
On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam wrote: > This is the first step for [JDK-8318483 - Move CDS configuration management > into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483) > > - Remove `Arguments::is_dumping_archive()` and `Arguments > assert_is_dumping_archive()` > - Add

RFR: 8318447: Move NMT source code to own subdirectory

2023-10-19 Thread Johan Sjölen
I think that NMT is deserving of its own subdirectory. Can we do a review of the changes before I fix the merge conflicts? 1. Moved all the nmt source code from services/ to nmt/ 2. Renamed all the include statements and sorted them 3. Fixed the include guards - Commit messages: -

Re: RFR: 8318484: Initial version of cdsConfig.hpp

2023-10-19 Thread Ioi Lam
On Thu, 19 Oct 2023 06:54:05 GMT, David Holmes wrote: >> This is the first step for [JDK-8318483 - Move CDS configuration management >> into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483) >> >> - Remove `Arguments::is_dumping_archive()` and `Arguments >> assert_is_dumping_archive(

Integrated: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-19 Thread Alex Menkov
On Wed, 11 Oct 2023 00:39:23 GMT, Alex Menkov wrote: > All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. > The change adds several fields in one of the test classes to verify order of > the returned fields (as described by GetClassFields spec: "in the order they > occ

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Chris Plummer
On Thu, 19 Oct 2023 13:52:24 GMT, Hannes Greule wrote: > I think this is worth a backport to jdk21u, what do you think? And if yes, is > it enough to run the backport command on the commit later and create a PR > from it? Since the problem was introduced in 21, that sounds reasonable. You can

Re: RFR: 8312777: notifyJvmtiMount before notifyJvmtiUnmount [v2]

2023-10-19 Thread Serguei Spitsyn
On Thu, 19 Oct 2023 09:33:49 GMT, Alan Bateman wrote: >> JVMTI is notified after a virtual thread unmounts. Right not, this >> notification is done after the virtual thread has finished parking or >> yielding so it's possible for the virtual to continue, and be mounted on a >> different carrie

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-19 Thread Serguei Spitsyn
On Thu, 19 Oct 2023 07:54:47 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the test dose not work as intended. >> Could someone please review it? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request incrementally with one > additional com

Re: RFR: 8315097: Rename createJavaProcessBuilder [v4]

2023-10-19 Thread Leo Korinth
On Tue, 17 Oct 2023 12:29:46 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v5]

2023-10-19 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Hannes Greule
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v9]

2023-10-19 Thread Chen Liang
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote: >> Summaries: >> 1. A few recommendations about updating the constant API is made at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html >> and I may update this patch shall the API changes be integrated before >> 2.

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Frederic Parain
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v30]

2023-10-19 Thread Albert Mingkun Yang
On Fri, 13 Oct 2023 01:38:13 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add call to publish in parallel gc and update counter

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v30]

2023-10-19 Thread Volker Simonis
On Fri, 13 Oct 2023 01:38:13 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add call to publish in parallel gc and update counter

Re: RFR: 8312777: notifyJvmtiMount before notifyJvmtiUnmount

2023-10-19 Thread Alan Bateman
On Sat, 14 Oct 2023 18:07:45 GMT, Alan Bateman wrote: > JVMTI is notified after a virtual thread unmounts. Right not, this > notification is done after the virtual thread has finished parking or > yielding so it's possible for the virtual to continue, and be mounted on a > different carrier, b

Re: RFR: 8312777: notifyJvmtiMount before notifyJvmtiUnmount [v2]

2023-10-19 Thread Alan Bateman
> JVMTI is notified after a virtual thread unmounts. Right not, this > notification is done after the virtual thread has finished parking or > yielding so it's possible for the virtual to continue, and be mounted on a > different carrier, before the unmount notification has completed on the > o

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-19 Thread Kimura Yukihiro
On Thu, 19 Oct 2023 07:54:47 GMT, Kimura Yukihiro wrote: >> I would like to fix this issue >> because the test dose not work as intended. >> Could someone please review it? >> >> Thanks, >> Kimura Yukihiro > > Kimura Yukihiro has updated the pull request incrementally with one > additional com

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-19 Thread Kimura Yukihiro
On Thu, 19 Oct 2023 04:43:06 GMT, Serguei Spitsyn wrote: >> Kimura Yukihiro has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8318410: [TESTBUG] >> jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on >> Japanese Windows

Re: RFR: 8318410: [TESTBUG] jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows [v2]

2023-10-19 Thread Kimura Yukihiro
> I would like to fix this issue > because the test dose not work as intended. > Could someone please review it? > > Thanks, > Kimura Yukihiro Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: 8318410: [TESTBUG] jdk/java/lang/inst

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v6]

2023-10-19 Thread Johannes Bechberger
On Wed, 18 Oct 2023 20:05:07 GMT, Chris Plummer wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add suggested modification > > test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 64: > >> 62: int port =

Re: RFR: 8318484: Initial version of cdsConfig.hpp

2023-10-19 Thread David Holmes
On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam wrote: > This is the first step for [JDK-8318483 - Move CDS configuration management > into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483) > > - Remove `Arguments::is_dumping_archive()` and `Arguments > assert_is_dumping_archive()` > - Add