On Thu, 12 Oct 2023 20:23:10 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetClassFields/getclfld007/TestDescription.java
>> line 36:
>>
>>> 34: * The test checks if the function returns the expected list of
>>> fields:
>>> 35: * - the list contains only dir
> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
> The change adds several fields in one of the test classes to verify order of
> the returned fields (as described by GetClassFields spec).
> Additionally added "printdump" argument to the test agent to make the test
>
On Tue, 17 Oct 2023 19:54:24 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Tue, 17 Oct 2023 21:37:05 GMT, Chris Plummer wrote:
>> Yes, so the current way is probably ok?
>>
>> IDEs like IntelliJ properly handle the exception event that is sent and
>> don't report an error, so I don't see a problem.
>
>> On the other hand, I think if the debug agent requires that a
On Tue, 17 Oct 2023 20:41:10 GMT, Johannes Bechberger
wrote:
>> It seems that ex.request()) is null for this event. The spec for
>> Event.request() says null might happen for VMDeath events, but doesn't
>> mention any other. In any case, I guess JDI does not filter out any events
>> for which
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote:
> The open nroff manpage files are out of sync with their closed markdown
> sources and need to be refreshed.
>
> The changes to apply are coming from:
>
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> to ea
On Mon, 16 Oct 2023 23:55:01 GMT, Iris Clark wrote:
>> The open nroff manpage files are out of sync with their closed markdown
>> sources and need to be refreshed.
>>
>> The changes to apply are coming from:
>>
>> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
>>
On Tue, 17 Oct 2023 20:32:52 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 76:
>>
>>> 74: while(eventIterator.hasNext() && start + TIMEOUT >
>>> System.currentTimeMillis()) {
>>> 75: Event event = eventIterator.next();
>>
On Tue, 17 Oct 2023 20:16:18 GMT, Chris Plummer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed event location
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 76:
>
>> 74: while
On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Tue, 17 Oct 2023 19:29:48 GMT, Johannes Bechberger
wrote:
> Maybe in a follow-up in a PR? This is not directly related to the exception
> value and could potentially change the behavior of the `onthrow` feature,
> therefore needing more tests.
Possibly, but the changes I made already have
> Fix `onthrow` issue by passing the event info to the `initialize` method.
>
> This prevents `jdb` from receiving a broken exception event and throwing an
> internal NullPointerException, upon attaching to the JDWP-agent.
Johannes Bechberger has updated the pull request incrementally with one
On Tue, 17 Oct 2023 19:07:45 GMT, Chris Plummer wrote:
> I'm also wondering if we shouldn't just export cbException() and call it
> directly rather than mimic a lot of what it is doing, although probably what
> would be easier is a new API that handles the event described in the
> EventInfo p
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Fri, 6 Oct 2023 20:47:22 GMT, Leonid Mesnik wrote:
> Test fixed to accept vm flags.
This pull request has now been integrated.
Changeset: d6679031
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/d6679031e0316f9ce0613b7db6bdf8ad46d31501
Stats: 4 lines in 1 file c
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
>
> Then I have manually modifi
17 matches
Mail list logo
