RFR: 8312777: notifyJvmtiMount before notifyJvmtiUnmount

2023-10-14 Thread Alan Bateman
JVMTI is notified after a virtual thread unmounts. Right not, this notification is done after the virtual thread has finished parking or yielding so it's possible for the virtual to continue, and be mounted on a different carrier, before the unmount notification has completed on the original car

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-14 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Sorry, I

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-14 Thread Chris Plummer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. So when y

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-14 Thread Hannes Greule
On Sat, 14 Oct 2023 01:16:26 GMT, Alex Menkov wrote: > > Thanks, I added a test case that ensures that the instance fields are all > > present. This is a very basic test, but it covers super types and also > > makes sure the order of supertypes is correct. If you want me to add > > something,

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v4]

2023-10-14 Thread Hannes Greule
> See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. Hannes Greule has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v3]

2023-10-14 Thread Hannes Greule
> See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. Hannes Greule has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-14 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. There is