Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v18]

2023-10-12 Thread Jonathan Joo
On Wed, 11 Oct 2023 22:25:04 GMT, Man Cao wrote: >> src/hotspot/share/runtime/perfData.hpp line 64: >> >>> 62: COM_THREADS, >>> 63: SUN_THREADS, >>> 64: SUN_THREADS_GCCPU,// Subsystem for Sun Threads GC CPU >> >> Really not sure about this naming ... > > +1, dropping the "GC" seems b

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v30]

2023-10-12 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add call to publish in parallel gc and update counter names - Changes: - all: https://git.openjdk.org/j

RFR: JDK-8317285: Misspellings in hprof test lib

2023-10-12 Thread Alex Menkov
The change fixes misspelled "referer" in test/lib/jdk/test/lib/hprof library The only caller of changed public API is VThreadInHeapDump.java - Commit messages: - fix Changes: https://git.openjdk.org/jdk/pull/16174/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16174&range=0

Integrated: 8316464: 3 sun/tools tests ignore VM flags

2023-10-12 Thread Leonid Mesnik
On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik wrote: > I marked tests > sun/tools/jcmd/TestProcessHelper.java > sun/tools/jinfo/JInfoTest.java > as headless. They used different specific VM options and are not worth > executing with other VM flags. > And fixed > sun/tools/jstat/JStatInterval

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v27]

2023-10-12 Thread Jonathan Joo
On Wed, 11 Oct 2023 23:23:11 GMT, Man Cao wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add comment and change if defined to ifdef > > src/hotspot/share/gc/shared/collectedHeap.cpp line 298: > >> 296: NOT_PROD

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v29]

2023-10-12 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add Copyright header to test and formatting changes - Changes: - all: https://git.openjdk.org/jdk/pull/

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v28]

2023-10-12 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Fix test - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - new: https://git.openjdk.or

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-12 Thread Alex Menkov
On Thu, 12 Oct 2023 01:37:01 GMT, Chris Plummer wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec). >> Additionally add

Integrated: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty wrote: > Trivial ProblemListing for some tests: > > [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList > runtime/CompressedOops/CompressedClassPointers.java on two platforms > [JDK-8318040](https://bugs.openjdk.org/brows

Re: RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
On Thu, 12 Oct 2023 19:54:17 GMT, Roger Riggs wrote: >> Trivial ProblemListing for some tests: >> >> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList >> runtime/CompressedOops/CompressedClassPointers.java on two platforms >> [JDK-8318040](https://bugs.openjdk.org/browse/JD

Re: RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Alexander Zvegintsev
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty wrote: > Trivial ProblemListing for some tests: > > [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList > runtime/CompressedOops/CompressedClassPointers.java on two platforms > [JDK-8318040](https://bugs.openjdk.org/brows

Re: RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Roger Riggs
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty wrote: > Trivial ProblemListing for some tests: > > [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList > runtime/CompressedOops/CompressedClassPointers.java on two platforms > [JDK-8318040](https://bugs.openjdk.org/brows

RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
Trivial ProblemListing for some tests: [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms [JDK-8318040](https://bugs.openjdk.org/browse/JDK-8318040) ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMon

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-12 Thread Alex Menkov
On Wed, 11 Oct 2023 06:11:29 GMT, Hannes Greule wrote: > > The fix itself looks good to me. How did you tested the change? Looks like > > we don't have test coverage for the correctness of the dumped fields. Would > > be nice to add it. > > Thanks. I ran `hotspot_serviceability` and also manua

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-12 Thread Chris Plummer
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. So with 8

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-12 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. I can con

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-12 Thread Serguei Spitsyn
On Tue, 10 Oct 2023 20:34:44 GMT, Leonid Mesnik wrote: >> I marked tests >> sun/tools/jcmd/TestProcessHelper.java >> sun/tools/jinfo/JInfoTest.java >> as headless. They used different specific VM options and are not worth >> executing with other VM flags. >> And fixed >> sun/tools/jstat/JStat