Re: RFR: 8314021: HeapDump: Optimize segmented heap file merging phase [v2]

2023-10-10 Thread Yi Yang
On Thu, 21 Sep 2023 02:12:06 GMT, Yi Yang wrote: > I had not noticed this PR sorry. I do not like the fact we have Linux-only > functionality being added with no intent to supply similar functionality on > other platforms. I also do not like the fact we had to ifdef the Linux code > into the s

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-10 Thread Hannes Greule
On Wed, 11 Oct 2023 01:13:56 GMT, Alex Menkov wrote: > The fix itself looks good to me. How did you tested the change? Looks like we > don't have test coverage for the correctness of the dumped fields. Would be > nice to add it. Thanks. I ran `hotspot_serviceability` and also manually looked i

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-10 Thread Alex Menkov
On Fri, 6 Oct 2023 20:56:13 GMT, Hannes Greule wrote: > See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. The fix itself looks good to me. How did you tested

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

2023-10-10 Thread Alex Menkov
On Fri, 6 Oct 2023 20:56:13 GMT, Hannes Greule wrote: > See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. src/hotspot/share/oops/fieldStreams.hpp line 194:

RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-10 Thread Alex Menkov
All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. The change adds several fields in one of the test classes to verify order of the returned fields (as described by GetClassFields spec). Additionally added "printdump" argument to the test agent to make the test more verb

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags [v2]

2023-10-10 Thread Leonid Mesnik
On Mon, 9 Oct 2023 08:29:39 GMT, Kevin Walls wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed test. > > test/jdk/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java line > 311: > >> 309: pr

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags [v2]

2023-10-10 Thread Leonid Mesnik
> Test fixed to accept vm flags. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed test. - Changes: - all: https://git.openjdk.org/jdk/pull/16081/files - new: https://git.openjdk.org/jdk/pull/16081/files/da6d36

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 23:31:57 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed JInfoTest.java > > test/jdk/sun/tools/jinfo/JInfoTest.java line 41: > >> 39: * @summary Unit test for jinfo ut

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-10 Thread Leonid Mesnik
> I marked tests > sun/tools/jcmd/TestProcessHelper.java > sun/tools/jinfo/JInfoTest.java > as headless. They used different specific VM options and are not worth > executing with other VM flags. > And fixed > sun/tools/jstat/JStatInterval.java > Tested with tier1, local execution of tests, and

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 21:03:03 GMT, Daniel D. Daugherty wrote: >> Test fixed to accept vm flags. > > Hmmm... what kind of testing has been done to make sure that we don't > suddenly get a bunch of new failures by allowing this test to accept VM flags? @dcubed-ojdk I tested this fix by running it w

Integrated: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads

2023-10-10 Thread Alex Menkov
On Thu, 21 Sep 2023 20:06:13 GMT, Alex Menkov wrote: > This is subtask of JDK-8299426: Heap dump does not contain virtual Thread > stack references > The change: > - reorganize thread-related code/prepare it to use for unmounted vthreads: > - new ThreadDumper class caches stack frames, thread

Integrated: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 19:58:13 GMT, Leonid Mesnik wrote: > The test uses specific classpath, and jar and is intended to test modules. So > I marked is as flagless, This pull request has now been integrated. Changeset: fec1d497 Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/comm

Re: RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v5]

2023-10-10 Thread Leonid Mesnik
On Sat, 7 Oct 2023 00:49:09 GMT, Alex Menkov wrote: >> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread >> stack references >> The change: >> - reorganize thread-related code/prepare it to use for unmounted vthreads: >> - new ThreadDumper class caches stack frames, thr

Integrated: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691

2023-10-10 Thread Christoph Langer
On Sun, 8 Oct 2023 21:51:42 GMT, Christoph Langer wrote: > Add listings for linux-ppc64le and aix-ppc64 for the 4 already problem listed > jstat tests. This pull request has now been integrated. Changeset: ad6dce37 Author:Christoph Langer URL: https://git.openjdk.org/jdk/commit/ad6