On Fri, 8 Sep 2023 12:34:39 GMT, Andrew Haley wrote:
>> This PR fixes a specific problem caused by using r29/rfp to unwind Java
>> code. For some time we have treated r29 as a callee-saved scratch register,
>> and it is freely used by C2-generated code. Therefore, any code in SA that
>> uses g
On Wed, 6 Sep 2023 08:18:45 GMT, JoKern65 wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
> The problem was described in
> [JDK-8309549](https://bugs.op
On Wed, 6 Sep 2023 08:18:45 GMT, JoKern65 wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
> The problem was described in
> [JDK-8309549](https://bugs.op
On Tue, 29 Aug 2023 10:09:21 GMT, Serguei Spitsyn wrote:
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `J
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `JvmtiThreadState's` for virtual threads
>
> The issue is tr
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `JvmtiThreadState's` for virtual threads
>
> The issue is tr
On Mon, 11 Sep 2023 20:05:07 GMT, Sergey Bylokhov wrote:
>> It's not that simple. Here's my comment from the bug:
>>
>> https://bugs.openjdk.org/browse/JDK-8307783?focusedCommentId=14582995&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14582995
>>
>> In jdk-21+24
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Sat, 9 Sep 2023 18:05:51 GMT, Leonid Mesnik wrote:
>> It is strange that the the tested vthreads in sleep(timeout) have sate
>> WAITING, not TIMED_WAITING.
>> It can be a bug in the implementation.
>> I've decided to add a short sleep. Checking states looks a little bit over
>> complicated.
On Mon, 11 Sep 2023 22:18:03 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed second round of review comments on VThreadEventTest.java
>
> test/hotspot/jtreg/serviceability/jvmti/vthrea
On Mon, 11 Sep 2023 21:22:18 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue: a need to lazily create
On Mon, 11 Sep 2023 21:22:18 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue: a need to lazily create
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `JvmtiThreadState's` for virtual threads
>
> The issue is tr
On Mon, 11 Sep 2023 19:53:19 GMT, Leonid Mesnik wrote:
> Could you please add comment why standard CountDownLatch doesn't work for
> this test.
Okay. Added comment.
-
PR Comment: https://git.openjdk.org/jdk/pull/15467#issuecomment-1714574938
On Sat, 20 May 2023 16:34:15 GMT, Daniel D. Daugherty
wrote:
>> test/hotspot/jtreg/runtime/reflect/ReflectOutOfMemoryError.java line 28:
>>
>>> 26: * @bug 8297977
>>> 27: * @summary Test that throwing OOM from reflected method gets
>>> InvocationTargetException
>>> 28: * @run main/othervm/t
On Mon, 11 Sep 2023 09:08:26 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue: a need to lazily create
On Thu, 7 Sep 2023 21:34:50 GMT, Chris Plummer wrote:
> Overall the changes look good. Have you tested to see if this fixes
> [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) and
> [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675)? You'll need to
> remove them from the probl
On Fri, 8 Sep 2023 12:34:39 GMT, Andrew Haley wrote:
>> This PR fixes a specific problem caused by using r29/rfp to unwind Java
>> code. For some time we have treated r29 as a callee-saved scratch register,
>> and it is freely used by C2-generated code. Therefore, any code in SA that
>> uses g
On Mon, 11 Sep 2023 09:08:26 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue: a need to lazily create
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote:
> Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests,
> each running exclusively. This drags the tier4 test times up. There seem to
> be no reason to run these tests exclusively, though: they complete in
> reason
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote:
> Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests,
> each running exclusively. This drags the tier4 test times up. There seem to
> be no reason to run these tests exclusively, though: they complete in
> reason
On Fri, 8 Sep 2023 09:34:36 GMT, Soumadipta Roy wrote:
> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
> -XX:-VerifyDependencies
>
> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and takes
> about 330 seconds out of 670 seconds of the entire run on
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote:
> Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests,
> each running exclusively. This drags the tier4 test times up. There seem to
> be no reason to run these tests exclusively, though: they complete in
> reason
On Mon, 11 Sep 2023 11:02:04 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Mon, 11 Sep 2023 11:02:04 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
> -XX:-VerifyDependencies
>
> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and takes
> about 330 seconds out of 670 seconds of the entire run on x86_64 fastdebug.
> The tier2 completion usually waits
On Mon, 11 Sep 2023 10:56:51 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote:
>> Soumadipta Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changing the order of flags to maintain consistency.
>
> The changes look good, but I'd suggest adding a comment so
On Fri, 8 Sep 2023 13:39:19 GMT, Aleksey Shipilev wrote:
> Good, any other reviewers for this one? Thanks!
Ping? Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15506#issuecomment-1713561482
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `JvmtiThreadState's` for virtual threads
>
> The issue is tr
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to lazily create
> `JvmtiThreadState's` for virtual threads
>
> The issue is tr
On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote:
> The changes look good, but I'd suggest adding a comment so the reader knows
> why these options were added.
Agreed. Something like:
"-Xmx512m", "-XX:MaxMetaspaceSize=64m",
"-XX:+CrashOnOutOfMemoryError",
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote:
>> Please review this simple change from @cjmoon1 for resolving static linking
>> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
>> found at:
>> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_no
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
35 matches
Mail list logo
