RFR: JDK-8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions

2023-08-09 Thread Alex Menkov
The change fixes several issues with capability management: - handling can_support_virtual_threads capability. JvmtiExport::can_support_virtual_threads() should be set to true if we have one or more agent with can_support_virtual_threads capability; - JvmtiManageCapabilities (used by GetPotentia

Re: RFR: 8313654: Test WaitNotifySuspendedVThreadTest.java timed out [v2]

2023-08-09 Thread Leonid Mesnik
> Test might times out if it suspend thread before it starts breakpoint event > handler. > The fix is to replace sleep with better synchronization and suspend virtual > thread only when it runs native code. > > Also, the completed monitor is acquired earlier to avoid racing when > completing te

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Serguei Spitsyn
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

Re: [jdk21] RFR: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64

2023-08-09 Thread Daniel D . Daugherty
On Wed, 9 Aug 2023 20:13:04 GMT, Naoto Sato wrote: >> A trivial fix to ProblemList jdk/jfr/tool/TestView.java on macosx-x64. > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the fast review! - PR Comment: https://git.openjdk.org/jdk21/pull/171#issuecomment-167208730

[jdk21] Integrated: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64

2023-08-09 Thread Daniel D . Daugherty
On Wed, 9 Aug 2023 19:58:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/tool/TestView.java on macosx-x64. This pull request has now been integrated. Changeset: 890adb64 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk21/commit/890adb6410dab4606a

[jdk21] RFR: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64

2023-08-09 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/jfr/tool/TestView.java on macosx-x64. - Commit messages: - 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64 Changes: https://git.openjdk.org/jdk21/pull/171/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=171&range=00 Issue: h

Re: [jdk21] RFR: 8314062: ProblemList jdk/jfr/tool/TestView.java on macosx-x64

2023-08-09 Thread Naoto Sato
On Wed, 9 Aug 2023 19:58:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/tool/TestView.java on macosx-x64. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/171#pullrequestreview-1570469956

Re: [JDK-8313814] Test serviceability/sa/ClhsdbSymbol.java timed out after passing

2023-08-09 Thread Chris Plummer
Hi Tham, Thank you for your interest in contributing to the OpenJDK project. We are more than happy to have you work on some bugs and can help you understand the process. https://openjdk.org/guide/ has a lot of useful information for new OpenJDK developers. As for you interest JDK-8313814, t

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Chris Plummer
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

RFR: 8313997: The jdi/ListeningConnector/startListening/startlis001 may fail if the hosts file is modified

2023-08-09 Thread Sergey Bylokhov
The test uses this code to create a list of valid addresses for the localhost: String hostname = "localhost"; List validAddresses = new LinkedList<>(); validAddresses.add(hostname); Arrays.stream(InetAddress.getAllByName(hostname)) .forEach(addre

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v3]

2023-08-09 Thread Matthias Baesken
> There is coding e.g. in > https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 > that deals with shared lib naming on different OS. > This code should be simplified. Matthias Baesken has updated the pull request incrementally with one additi

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v2]

2023-08-09 Thread Matthias Baesken
On Wed, 9 Aug 2023 08:42:35 GMT, Matthias Baesken wrote: >> There is coding e.g. in >> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 >> that deals with shared lib naming on different OS. >> This code should be simplified. > > Matthias

Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests [v2]

2023-08-09 Thread Matthias Baesken
> There is coding e.g. in > https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72 > that deals with shared lib naming on different OS. > This code should be simplified. Matthias Baesken has updated the pull request incrementally with one additi

RFR: 8311775: [TEST] duplicate verifyHeapDump in several tests

2023-08-09 Thread Yi Yang
This is a follow-up patch of #13667. verifyHeapDump is duplicated in several tests, this patch tries to consolidate them into one method. - Commit messages: - 8311775: [TEST] duplicate verifyHeapDump in several tests Changes: https://git.openjdk.org/jdk/pull/15202/files Webrev: ht

[JDK-8313814] Test serviceability/sa/ClhsdbSymbol.java timed out after passing

2023-08-09 Thread Tham To Thi Hong
Dear members of the serviceability-dev mailing list, I hope this email finds you well. My name is Tham To, and I am a new contributor to the OpenJDK community. I am writing to seek your guidance and assistance regarding a bug that I have been tracking. Bug Details: Bug ID: JDK-8313814 Bug Descr