Re: RFR: JDK-8313670: Simplify shared lib name handling code in some tests

2023-08-06 Thread David Holmes
On Fri, 4 Aug 2023 20:55:25 GMT, Serguei Spitsyn wrote: >> test/lib/jdk/test/lib/Platform.java line 376: >> >>> 374: } >>> 375: } >>> 376: >> >> The following tests could leverage this new API. Just look for calls to >> `Platform.sharedLibraryExt()`: >> >> test/hotspot/jtreg/runt

Re: RFR: 8313785: Fix -Wconversion warnings in prims code [v2]

2023-08-06 Thread David Holmes
On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote: >> This patch fixes Wconversion in code in the src/hotspot/share/prims >> directory. Most of the changes correct the types. jfieldID's are created >> with the int offset returned by InstanceKlass::field_offset(). >> int field_

Re: RFR: 8313785: Fix -Wconversion warnings in prims code [v2]

2023-08-06 Thread David Holmes
On Fri, 4 Aug 2023 23:06:54 GMT, Coleen Phillimore wrote: >> src/hotspot/share/prims/jvm.cpp line 612: >> >>> 610: // as implemented in the classic virtual machine; return 0 if object >>> is null >>> 611: return handle == nullptr ? 0 : >>> 612: checked_cast(ObjectSynchronizer::Fast

RFR: 8313854: Some tests in serviceability area fail on localized Windows platform

2023-08-06 Thread Kimura Yukihiro
I would like to fix this issue because the svc jtreg test does not pass on localized Windows platform. Testing: all serviceability area tests (jdk_svc group). Could anyone review the fix please? Thanks, Kimura Yukihiro - Commit messages: - 8313854: Some tests in serviceability a