Re: RFR: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects [v2]

2023-08-03 Thread Leonid Mesnik
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class > cls). The previous attempt to post event directly from > 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even > if jvmti event is not enabled. Some optimizations have been disabled just > bec

Re: RFR: 8256379: Replace SIZE_FORMAT with 'z' length modifier

2023-08-03 Thread David Holmes
On Thu, 3 Aug 2023 23:39:11 GMT, Andrew John Hughes wrote: > Removing it to hardcode a format thus seems like a bit of a backward step to > me. But we only defined abstract things like `SIZE_FORMAT` because there was no single specifier accepted by all C runtimes and which behaves in the same

Re: RFR: JDK-8306441: Two phase segmented heap dump [v25]

2023-08-03 Thread Yi Yang
On Thu, 3 Aug 2023 13:24:19 GMT, Kevin Walls wrote: > Also the variable num_requested_dump_thread is not needed? It's just a copy > of _num_dumper_threads which we don't change. This is needed because _num_dumper_threads will change later, the requested dump thread may not equal to actual _num

Re: RFR: 8256379: Replace SIZE_FORMAT with 'z' length modifier

2023-08-03 Thread Andrew John Hughes
On Wed, 2 Aug 2023 01:31:43 GMT, Coleen Phillimore wrote: > Replace SIZE_FORMAT with %zu and SIZE_FORMAT_X with 0x%zx using a 4 line sed > script: > > sed -e 's/" SIZE_FORMAT "/%zu/g' -e 's/" SIZE_FORMAT,/%zu",/' \ > -e 's/print(SIZE_FORMAT "/print("%zu/g' \ > -e 's/" SIZE_FORMAT_

Withdrawn: 8256379: Replace SIZE_FORMAT with 'z' length modifier

2023-08-03 Thread Coleen Phillimore
On Wed, 2 Aug 2023 01:31:43 GMT, Coleen Phillimore wrote: > Replace SIZE_FORMAT with %zu and SIZE_FORMAT_X with 0x%zx using a 4 line sed > script: > > sed -e 's/" SIZE_FORMAT "/%zu/g' -e 's/" SIZE_FORMAT,/%zu",/' \ > -e 's/print(SIZE_FORMAT "/print("%zu/g' \ > -e 's/" SIZE_FORMAT_

Re: RFR: 8256379: Replace SIZE_FORMAT with 'z' length modifier

2023-08-03 Thread Coleen Phillimore
On Wed, 2 Aug 2023 01:31:43 GMT, Coleen Phillimore wrote: > Replace SIZE_FORMAT with %zu and SIZE_FORMAT_X with 0x%zx using a 4 line sed > script: > > sed -e 's/" SIZE_FORMAT "/%zu/g' -e 's/" SIZE_FORMAT,/%zu",/' \ > -e 's/print(SIZE_FORMAT "/print("%zu/g' \ > -e 's/" SIZE_FORMAT_

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-08-03 Thread Ashutosh Mehra
On Thu, 3 Aug 2023 15:59:14 GMT, Chris Plummer wrote: >> @ashu-mehra thanks for doing the additional testing. Pity there is no >> regression/functional test for this. > >> @dholmes-ora @plummercj I have improved [dumpclass >> tests](https://github.com/openjdk/jdk/commit/97618cc9bbadce4b51fc0fbe

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-08-03 Thread Chris Plummer
On Wed, 2 Aug 2023 05:07:31 GMT, David Holmes wrote: >> @dholmes-ora I verified the case for hidden dynamically injected classes. >> The dumped class data for a hidden dynamically injected class does not have >> any Nest-Host attribute. When generating these classes dynamically the VM >> does

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-08-03 Thread Ashutosh Mehra
On Wed, 2 Aug 2023 05:07:31 GMT, David Holmes wrote: > Pity there is no regression/functional test for this. @dholmes-ora @plummercj I have improved [dumpclass tests](https://github.com/openjdk/jdk/commit/97618cc9bbadce4b51fc0fbee93557f4dcc8d26a) to cover up some cases for this PR and [JDK-8

Re: RFR: JDK-8306441: Two phase segmented heap dump [v25]

2023-08-03 Thread Kevin Walls
On Wed, 2 Aug 2023 14:33:28 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurre

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform

2023-08-03 Thread Jean-Philippe Bempel
On Thu, 13 Jul 2023 14:34:38 GMT, Coleen Phillimore wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are in

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v6]

2023-08-03 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v5]

2023-08-03 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons