Re: RFR: JDK-8306441: Two phase segmented heap dump [v20]

2023-07-28 Thread Yi Yang
On Fri, 28 Jul 2023 17:18:05 GMT, Kevin Walls wrote: > I think we might be best off leaving the long dump as you have it in the > AttachListener for now. 8-) Consideing a very large heap size, the VM used to pause all threads and spend 1 hour to execute a heap dump, during which time jcmd/jsta

Re: RFR: JDK-8306441: Two phase segmented heap dump [v16]

2023-07-28 Thread Chris Plummer
On Tue, 11 Jul 2023 20:49:35 GMT, Chris Plummer wrote: >> Yi Yang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - whitespace >> - add test > > BTW, `serviceability/dcmd/gc/HeapDumpAllTest.java` is failing due to build > failures when

Re: RFR: JDK-8306441: Two phase segmented heap dump [v20]

2023-07-28 Thread Kevin Walls
On Wed, 19 Jul 2023 12:42:27 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurr

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v4]

2023-07-28 Thread Coleen Phillimore
On Tue, 18 Jul 2023 16:48:55 GMT, Jean-Philippe Bempel wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v4]

2023-07-28 Thread Coleen Phillimore
On Tue, 18 Jul 2023 16:48:55 GMT, Jean-Philippe Bempel wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are

Re: RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures [v6]

2023-07-28 Thread Kevin Walls
> This test iterates an array of ThreadInfos in a few places (e.g. in the > method doCheck()), and needs to tolerate and ignore nulls, in case a thread > finishes and the test hits an NPE. > > There are other calls like "TM.getThreadInfo(tid).getLockName()" which might > often be risky, but if

Integrated: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures

2023-07-28 Thread Kevin Walls
On Thu, 15 Jun 2023 20:34:53 GMT, Kevin Walls wrote: > This test iterates an array of ThreadInfos in a few places (e.g. in the > method doCheck()), and needs to tolerate and ignore nulls, in case a thread > finishes and the test hits an NPE. > > There are other calls like "TM.getThreadInfo(tid

Re: RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures [v5]

2023-07-28 Thread Kevin Walls
> This test iterates an array of ThreadInfos in a few places (e.g. in the > method doCheck()), and needs to tolerate and ignore nulls, in case a thread > finishes and the test hits an NPE. > > There are other calls like "TM.getThreadInfo(tid).getLockName()" which might > often be risky, but if

Re: RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures [v4]

2023-07-28 Thread Kevin Walls
On Wed, 26 Jul 2023 20:14:16 GMT, Kevin Walls wrote: >> This test iterates an array of ThreadInfos in a few places (e.g. in the >> method doCheck()), and needs to tolerate and ignore nulls, in case a thread >> finishes and the test hits an NPE. >> >> There are other calls like "TM.getThreadInf

Re: RFR: JDK-8306441: Two phase segmented heap dump [v16]

2023-07-28 Thread Yi Yang
On Tue, 11 Jul 2023 20:49:35 GMT, Chris Plummer wrote: >> Yi Yang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - whitespace >> - add test > > BTW, `serviceability/dcmd/gc/HeapDumpAllTest.java` is failing due to build > failures when