Re: RFR: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread Thomas Stuefe
On Wed, 26 Jul 2023 05:38:26 GMT, David Holmes wrote: > Okay I guess, though now all we are testing is that we fired of the right > DCmd, not that the DCmd actually did something that worked. > > Thanks. True, but unlike runtime/os/TestTrimNative.java, this old test did nothing to provoke a m

Integrated: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread Thomas Stuefe
On Tue, 25 Jul 2023 06:28:16 GMT, Thomas Stuefe wrote: > Trivial patch. > > The test just fires `jcmd System.trim_native_heap`, but without preparing any > special memory allocation conditions. Typically, we end up firing the command > when VM initialization is done, and therefore end up trimm

Re: RFR: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread Thomas Stuefe
On Tue, 25 Jul 2023 12:54:10 GMT, Kevin Walls wrote: >> Trivial patch. >> >> The test just fires `jcmd System.trim_native_heap`, but without preparing >> any special memory allocation conditions. Typically, we end up firing the >> command when VM initialization is done, and therefore end up tr

Re: RFR: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread David Holmes
On Tue, 25 Jul 2023 06:28:16 GMT, Thomas Stuefe wrote: > Trivial patch. > > The test just fires `jcmd System.trim_native_heap`, but without preparing any > special memory allocation conditions. Typically, we end up firing the command > when VM initialization is done, and therefore end up trimm

Re: RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

2023-07-25 Thread David Holmes
On Tue, 25 Jul 2023 21:48:24 GMT, Paul Hohensee wrote: > MonitoringSupport_lock is initialized only when UseG1GC is true, but > [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) uses it to > implement getTotalThreadAllocatedBytes, which is available for all garbage > collectors. While

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v4]

2023-07-25 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v3]

2023-07-25 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

2023-07-25 Thread Paul Hohensee
MonitoringSupport_lock is initialized only when UseG1GC is true, but [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) uses it to implement getTotalThreadAllocatedBytes, which is available for all garbage collectors. While the current code sets UseG1GC regardless of which collector is s

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v2]

2023-07-25 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

Re: RFR: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

2023-07-25 Thread Chris Plummer
On Tue, 25 Jul 2023 11:44:06 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which removes usages of > the deprecated (no-op) `-Xdebug` from these tests? I missed these files when > addressing https://bugs.openjdk.org/browse/JDK-8227229. > > tier testing with thes

Re: RFR: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread Kevin Walls
On Tue, 25 Jul 2023 06:28:16 GMT, Thomas Stuefe wrote: > Trivial patch. > > The test just fires `jcmd System.trim_native_heap`, but without preparing any > special memory allocation conditions. Typically, we end up firing the command > when VM initialization is done, and therefore end up trimm

Re: RFR: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

2023-07-25 Thread Kevin Walls
On Tue, 25 Jul 2023 11:44:06 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which removes usages of > the deprecated (no-op) `-Xdebug` from these tests? I missed these files when > addressing https://bugs.openjdk.org/browse/JDK-8227229. > > tier testing with thes

RFR: JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

2023-07-25 Thread Thomas Stuefe
Trivial patch. The test just fires `jcmd System.trim_native_heap`, but without preparing any special memory allocation conditions. Typically, we end up firing the command when VM initialization is done, and therefore end up trimming a lot of memory. But once in a blue moon concurrent allocation

RFR: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

2023-07-25 Thread Jaikiran Pai
Can I please get a review of this test-only change which removes usages of the deprecated (no-op) `-Xdebug` from these tests? I missed these files when addressing https://bugs.openjdk.org/browse/JDK-8227229. tier testing with these changes has passed without issues. - Commit messag