Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked

2023-07-24 Thread Alan Bateman
On Tue, 25 Jul 2023 05:21:45 GMT, David Holmes wrote: > Why handle TIMED this way instead of just making TIMED_PARKED/PARKING states? Been there but it is 3 additional states and a lot simpler to just use the additional state bits, like we do with SUSPENDED. We might use another one for specia

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-07-24 Thread David Holmes
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote: > This patch adds NestHost and NestMembers attributes to the class dumped by SA. > > Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb` > Manual testing by dumping `j.l.String` and > `j.l.String$CaseInsensitiveC

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked

2023-07-24 Thread David Holmes
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote: > Thread::getState is an API for monitoring and management purposes to report > the thread state. If a virtual thread is parked with LockSupport.parkNanos, > its state is reported as WAITING when it should be TIMED_WAITING. JVM TI > GetThr

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-07-24 Thread Serguei Spitsyn
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote: > This patch adds NestHost and NestMembers attributes to the class dumped by SA. > > Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb` > Manual testing by dumping `j.l.String` and > `j.l.String$CaseInsensitiveC

[jdk21] Integrated: 8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist

2023-07-24 Thread Serguei Spitsyn
On Fri, 21 Jul 2023 22:32:29 GMT, Serguei Spitsyn wrote: > This is a clean 21 backport of the 22 fix: > [JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051): > assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event > controller, JVM TI environments must exist > > Testi

Re: [jdk21] RFR: 8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist

2023-07-24 Thread Serguei Spitsyn
On Fri, 21 Jul 2023 22:32:29 GMT, Serguei Spitsyn wrote: > This is a clean 21 backport of the 22 fix: > [JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051): > assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event > controller, JVM TI environments must exist > > Testi

Re: RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-07-24 Thread Chris Plummer
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote: > This patch adds NestHost and NestMembers attributes to the class dumped by SA. > > Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb` > Manual testing by dumping `j.l.String` and > `j.l.String$CaseInsensitiveC

RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

2023-07-24 Thread Ashutosh Mehra
This patch adds NestHost and NestMembers attributes to the class dumped by SA. Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb` Manual testing by dumping `j.l.String` and `j.l.String$CaseInsensitiveComparator` classes. `j.l.String` shows one entry in `NestMembers` at

RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked

2023-07-24 Thread Alan Bateman
Thread::getState is an API for monitoring and management purposes to report the thread state. If a virtual thread is parked with LockSupport.parkNanos, its state is reported as WAITING when it should be TIMED_WAITING. JVM TI GetThreadState has the same issue in that it returns JVMTI_THREAD_STA

Re: [jdk21] RFR: 8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist

2023-07-24 Thread Chris Plummer
On Fri, 21 Jul 2023 22:32:29 GMT, Serguei Spitsyn wrote: > This is a clean 21 backport of the 22 fix: > [JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051): > assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event > controller, JVM TI environments must exist > > Testi