[jdk21] Integrated: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach

2023-07-18 Thread Serguei Spitsyn
On Thu, 13 Jul 2023 03:41:28 GMT, Serguei Spitsyn wrote: > Clean backport from mainline jdk repo to jdk21 for the fix of: > [8311556](https://bugs.openjdk.org/browse/JDK-8311556): GetThreadLocalStorage > not working for vthreads mounted during JVMTI attach > > Testing: > - TBD: mach5 tiers 1-5

Re: [jdk21] RFR: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach

2023-07-18 Thread Serguei Spitsyn
On Thu, 13 Jul 2023 03:41:28 GMT, Serguei Spitsyn wrote: > Clean backport from mainline jdk repo to jdk21 for the fix of: > [8311556](https://bugs.openjdk.org/browse/JDK-8311556): GetThreadLocalStorage > not working for vthreads mounted during JVMTI attach > > Testing: > - TBD: mach5 tiers 1-5

Integrated: JDK-8310584: GetThreadState reports blocked and runnable for pinned suspended virtual threads

2023-07-18 Thread Alex Menkov
On Thu, 13 Jul 2023 19:18:38 GMT, Alex Menkov wrote: > The change fixes handling of "suspended" bit in VT state. > The code looks very strange. > java_lang_VirtualThread::RUNNING == 3, so line 803 clears > JVMTI_THREAD_STATE_ALIVE(1) and JVMTI_THREAD_STATE_TERMINATED(2) > Per log this code came

Re: [jdk21] RFR: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach

2023-07-18 Thread Alex Menkov
On Thu, 13 Jul 2023 03:41:28 GMT, Serguei Spitsyn wrote: > Clean backport from mainline jdk repo to jdk21 for the fix of: > [8311556](https://bugs.openjdk.org/browse/JDK-8311556): GetThreadLocalStorage > not working for vthreads mounted during JVMTI attach > > Testing: > - TBD: mach5 tiers 1-5

Re: RFR: JDK-8293114: JVM should trim the native heap [v12]

2023-07-18 Thread Thomas Stuefe
On Fri, 14 Jul 2023 20:03:24 GMT, Thomas Stuefe wrote: >> This is a continuation of https://github.com/openjdk/jdk/pull/10085. I >> closed https://github.com/openjdk/jdk/pull/10085 because it had accumulated >> too much comment history and got confusing. For a history of this issue, see >> pre

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v4]

2023-07-18 Thread Alan Bateman
On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

RFR: 8312246: NPE when HSDB visits bad oop

2023-07-18 Thread Sergey Nazarkin
Hi! This is a minor HSDB fix. It prints "bad oop" instead of throwing an NPE message to the console when a corrupted object is found. - Commit messages: - 8312246: NPE when HSDB visits bad oop Changes: https://git.openjdk.org/jdk/pull/14922/files Webrev: https://webrevs.openjdk.o

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform

2023-07-18 Thread Jean-Philippe Bempel
On Thu, 13 Jul 2023 14:34:38 GMT, Coleen Phillimore wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are in

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v4]

2023-07-18 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v3]

2023-07-18 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons

Re: RFR: JDK-8306441: Two phase segmented heap dump [v19]

2023-07-18 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: 8311971: SA's ConstantPool.java uses incorrect computation to read long value in the constant pool

2023-07-18 Thread Ashutosh Mehra
On Mon, 17 Jul 2023 22:59:30 GMT, David Holmes wrote: > Approved, but please file that follow up issue. Follow up issue for removing the dead code - https://bugs.openjdk.org/browse/JDK-8312232 - PR Comment: https://git.openjdk.org/jdk/pull/14855#issuecomment-1640234531

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v2]

2023-07-18 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v3]

2023-07-18 Thread Jaikiran Pai
On Tue, 18 Jul 2023 11:01:33 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> include -debug (alias) option in the deprecated log message > > src/java.base/share/classes/sun/launcher/resources/laun

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v4]

2023-07-18 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option and `-debug` option of the `java` command? This > addresses https://bugs.openjdk.org/browse/JDK-8227229. > > As noted in the JBS issue this option is currently a no-op and has been there >

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v3]

2023-07-18 Thread Alan Bateman
On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v3]

2023-07-18 Thread Jaikiran Pai
On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v3]

2023-07-18 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option and `-debug` option of the `java` command? This > addresses https://bugs.openjdk.org/browse/JDK-8227229. > > As noted in the JBS issue this option is currently a no-op and has been there >

Re: RFR: 8312151: Deprecate for removal the -Xdebug option [v2]

2023-07-18 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option of the `java` command? This addresses > https://bugs.openjdk.org/browse/JDK-8312151? > > As noted in the JBS issue this option is currently a no-op and has been there > only for backward c

Re: RFR: 8312151: Deprecate for removal the -Xdebug option

2023-07-18 Thread Alan Bateman
On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option of the `java` command? This addresses > https://bugs.openjdk.org/browse/JDK-8312151? > > As noted in the JBS issue this option is cur

Re: RFR: 8312151: Deprecate for removal the -Xdebug option

2023-07-18 Thread Jaikiran Pai
On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option of the `java` command? This addresses > https://bugs.openjdk.org/browse/JDK-8312151? > > As noted in the JBS issue this option is cur

RFR: 8312151: Deprecate for removal the -Xdebug option

2023-07-18 Thread Jaikiran Pai
Can I please get a review of this change which proposes to deprecate for removal the `-Xdebug` option of the `java` command? This addresses https://bugs.openjdk.org/browse/JDK-8312151? As noted in the JBS issue this option is currently a no-op and has been there only for backward compatible si