Re: RFR: JDK-8293114: JVM should trim the native heap [v6]

2023-07-07 Thread Thomas Stuefe
> This is a continuation of https://github.com/openjdk/jdk/pull/10085. I closed > https://github.com/openjdk/jdk/pull/10085 because it had accumulated too much > comment history and got confusing. For a history of this issue, see previous > discussions [1] and the comment section of 10085. > >

Re: RFR: JDK-8293114: JVM should trim the native heap [v5]

2023-07-07 Thread Thomas Stuefe
On Fri, 7 Jul 2023 13:36:22 GMT, Thomas Stuefe wrote: >> This is a continuation of https://github.com/openjdk/jdk/pull/10085. I >> closed https://github.com/openjdk/jdk/pull/10085 because it had accumulated >> too much comment history and got confusing. For a history of this issue, see >> prev

Re: RFR: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"

2023-07-07 Thread Alex Menkov
On Wed, 14 Jun 2023 01:02:09 GMT, Alex Menkov wrote: > If virtual thread has frames in stackChunks, need to apply load barriers > before processing nmethods (javaVFrame::locals() and > javaVFrame::expressions() do it internally) > > Testing: tier1-tier5; > 400 runs of VThreadStackRefTest.java

Re: RFR: JDK-8310066: Improve test coverage for JVMTI GetThreadState on carrier and mounted vthread [v4]

2023-07-07 Thread Alex Menkov
On Thu, 29 Jun 2023 18:40:50 GMT, Alex Menkov wrote: >> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier >> should return STATE_WAITING) >> New test tests GetThreadState for different thread states. >> The test detected a bug in the implementation, new issue is created:

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v15]

2023-07-07 Thread Alex Menkov
On Thu, 6 Jul 2023 06:07:18 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurre

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Ashutosh Mehra
On Fri, 7 Jul 2023 13:38:34 GMT, Thomas Stuefe wrote: > (just noticed the patch adds +666 lines, bad sign, I should add another line > somewhere). It also deletes 2 lines so that makes it 664 😉 - PR Comment: https://git.openjdk.org/jdk/pull/14781#issuecomment-1625515410

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Thomas Stuefe
On Thu, 6 Jul 2023 15:38:56 GMT, Leo Korinth wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> last cleanups and shade feedback > > The description says `-XX:GCTrimNativeHeapInterval= (defaults to > 60)`, but the c

Re: RFR: JDK-8293114: JVM should trim the native heap [v5]

2023-07-07 Thread Thomas Stuefe
> This is a continuation of https://github.com/openjdk/jdk/pull/10085. I closed > https://github.com/openjdk/jdk/pull/10085 because it had accumulated too much > comment history and got confusing. For a history of this issue, see previous > discussions [1] and the comment section of 10085. > >

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Thomas Stuefe
On Thu, 6 Jul 2023 18:50:45 GMT, Robbin Ehn wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> last cleanups and shade feedback > > src/hotspot/share/runtime/trimNative.cpp line 137: > >> 135: os::size_change_t

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Thomas Stuefe
On Fri, 7 Jul 2023 04:42:53 GMT, David Holmes wrote: > I had an initial look at this. Seems okay in principle. The > naming/terminology needs some updating IMO: "trimNative" doesn't convey > enough information, please use "trimNativeHeap". "trim" for logging tag is > also too non-descript. >

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Thomas Stuefe
On Thu, 6 Jul 2023 19:04:46 GMT, Robbin Ehn wrote: >> src/hotspot/share/runtime/trimNative.cpp line 149: >> >>> 147: return true; >>> 148: } else { >>> 149: log_info(trim)("Trim native heap (no details)"); >> >> Consistency: `Trim native heap: complete, no details`. > > I

Re: RFR: JDK-8293114: JVM should trim the native heap [v4]

2023-07-07 Thread Thomas Stuefe
On Thu, 6 Jul 2023 16:57:56 GMT, Leo Korinth wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> last cleanups and shade feedback > > src/hotspot/share/runtime/trimNative.cpp line 78: > >> 76: static constexpr int

Integrated: JDK-8310550: Adjust references to rt.jar

2023-07-07 Thread Matthias Baesken
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote: > There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. This pull request has now been integrated. Changeset: 25cbe85d Author:Matthias Baesken URL: https://