Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread Daniel Jeliński
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

2023-07-04 Thread Daniel Jeliński
> Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointer (64 bits) to the address given by > its parameter, whic

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread David Holmes
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe

Re: RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread Kevin Walls
On Tue, 4 Jul 2023 17:33:02 GMT, Daniel Jeliński wrote: > Please review this test-only fix that fixes the size of variables that are > used in methods that expect a pointer. > > On Windows, type `long` is 32 bits, pointers are 64 bits large. The method > `GetThreadLocalStorage` writes a pointe

RFR: 8311301: MethodExitTest may fail with stack buffer overrun

2023-07-04 Thread Daniel Jeliński
Please review this test-only fix that fixes the size of variables that are used in methods that expect a pointer. On Windows, type `long` is 32 bits, pointers are 64 bits large. The method `GetThreadLocalStorage` writes a pointer (64 bits) to the address given by its parameter, which overflows