Integrated: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-07-03 Thread Daniel Jeliński
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote: > Please review this attempt to fix ignored-qualifiers warning. > > Example warnings: > > src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier > on return type has no effect [-Wignored-qualifiers] >CompiledMet

Re: RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-07-03 Thread Daniel Jeliński
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote: > Please review this attempt to fix ignored-qualifiers warning. > > Example warnings: > > src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier > on return type has no effect [-Wignored-qualifiers] >CompiledMet

Re: RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-07-03 Thread David Holmes
On Mon, 3 Jul 2023 07:24:56 GMT, Daniel Jeliński wrote: >> Yes, I think that may have been the original intent. I'll add const on these >> functions. > > ...actually these methods are static, and static functions can't be > const-qualified. Ah okay :) - PR Review Comment: https:/

Re: RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-07-03 Thread Daniel Jeliński
On Mon, 3 Jul 2023 06:47:04 GMT, Daniel Jeliński wrote: >> src/hotspot/cpu/aarch64/aarch64.ad line 2288: >> >>> 2286: >>> //= >>> 2287: >>> 2288: const bool Matcher::match_rule_supported(int opcode) { >> >> Have to wo

[jdk21] Integrated: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-07-03 Thread Matthias Baesken
On Fri, 30 Jun 2023 12:35:27 GMT, Matthias Baesken wrote: > 8310380: Handle problems in core-related tests on macOS when codesign tool > does not work This pull request has now been integrated. Changeset: 6f3f4aa2 Author:Matthias Baesken URL: https://git.openjdk.org/jdk21/commit/6f