On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote:
> Simple addition of a doc tag.
>
> src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java
> is introduced in jdk7 by
> 7036199: Adding a notification to the implementation of
> GarbageCollectorMXBeans
Marked as revie
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
On Thu, 29 Jun 2023 18:40:50 GMT, Alex Menkov wrote:
>> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
>> should return STATE_WAITING)
>> New test tests GetThreadState for different thread states.
>> The test detected a bug in the implementation, new issue is created:
On Thu, 29 Jun 2023 19:44:58 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/methodComparator.cpp line 79:
>>
>>> 77: case Bytecodes::_instanceof : {
>>> 78: int cpi_old = s_old->get_index_u2();
>>> 79: int cpi_new = s_new->get_index_u2();
>>
>> These constant pool access
On Thu, 29 Jun 2023 17:29:50 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Thu, 29 Jun 2023 19:51:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 2195:
>>
>>> 2193: case Bytecodes::_ldc:
>>> 2194: {
>>> 2195: u1 cp_index = *(bcp + 1);
>>
>> Constant pool indices are usually u2, why does this need to be a
On Thu, 29 Jun 2023 18:51:26 GMT, Alex Menkov wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedTest.java
>> line 62:
>>
>>> 60: TestStatus status = new
>>> TestStatus("JVMTI_THREAD_STATE_RUNNABLE");
>>> 61: CountDownLatch
On Thu, 29 Jun 2023 13:05:58 GMT, Leo Korinth wrote:
> My changes look like this in the diff output
> ```
> }
> -
> ```
Thanks for showing this and other output. To me this looked like the final
newline had been removed. I would have expected to see something that more
obviously showed more
On Thu, 29 Jun 2023 20:06:19 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Thu, 29 Jun 2023 02:13:32 GMT, David Holmes wrote:
> Someone from the compiler team should review this now.
@vnkozlov could you please review this or nominate someone else from the
compiler team to look at it. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/14641#issueco
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Thu, 29 Jun 2023 17:29:50 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Thu, 29 Jun 2023 17:23:44 GMT, Matias Saavedra Silva
wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a comment about u1 cast to new_index for the ldc bytecode.
>
> src/hotspot/share/prims/jvmtiRedefine
On Thu, 29 Jun 2023 14:26:10 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spurious wakeups
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedT
On Thu, 29 Jun 2023 14:10:38 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spurious wakeups
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedT
> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
> should return STATE_WAITING)
> New test tests GetThreadState for different thread states.
> The test detected a bug in the implementation, new issue is created:
> JDK-8310584
> Corresponding testcases are commented now
On Thu, 29 Jun 2023 17:29:50 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
> Please review change for mostly fixing return types in the constant pool and
> metadata to fix -Wconversion warnings in JVMTI code. The order of preference
> for changes are: 1. change the types to more distinct types (fields in the
> constant pool are u2 because that's their size in the clas
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
On Thu, 29 Jun 2023 14:34:06 GMT, Frederic Parain wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fred's comments.
>
> src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp line 399:
>
>> 397: int length
> Please review change for mostly fixing return types in the constant pool and
> metadata to fix -Wconversion warnings in JVMTI code. The order of preference
> for changes are: 1. change the types to more distinct types (fields in the
> constant pool are u2 because that's their size in the clas
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 12:17:23 GMT, Coleen Phillimore wrote:
> Please review change for mostly fixing return types in the constant pool and
> metadata to fix -Wconversion warnings in JVMTI code. The order of preference
> for changes are: 1. change the types to more distinct types (fields in the
On Thu, 29 Jun 2023 16:22:29 GMT, Alan Bateman wrote:
> Looks fine, I assume you'll bump the copyright date before integrating.
Will do.
-
PR Comment: https://git.openjdk.org/jdk/pull/14714#issuecomment-1613500142
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
Simple doc tag addition.
These are files which describe an interface that has been with us since 1.5.
The files themselves were previously generated at build time, but have been in
the repo since jdk15. But the API is since 1.5.
The other file mentioned in the bug is not a public class and ha
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote:
> Simple addition of a doc tag.
>
> src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java
> is introduced in jdk7 by
> 7036199: Adding a notification to the implementation of
> GarbageCollectorMXBeans
Marked as revie
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 04:41:20 GMT, Alex Menkov wrote:
>> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
>> should return STATE_WAITING)
>> New test tests GetThreadState for different thread states.
>> The test detected a bug in the implementation, new issue is created:
On Thu, 15 Jun 2023 15:06:54 GMT, Ashutosh Mehra wrote:
> Please review this PR that extends SA to write BootstrapMethods attribute
> when dumping the class files.
>
> Tested it by dumping the class file for java/lang/String and comparing the
> BootstrapMethods attribute shown by javap for the
On Thu, 22 Jun 2023 15:37:11 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 29 Jun 2023 14:16:16 GMT, Kevin Walls wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment about the layout of operands array in constant pool
>>
>> Signed-off-by: Ashutosh Mehra
>
> Yes 8-)
On Thu, 29 Jun 2023 04:41:20 GMT, Alex Menkov wrote:
>> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
>> should return STATE_WAITING)
>> New test tests GetThreadState for different thread states.
>> The test detected a bug in the implementation, new issue is created:
On Thu, 29 Jun 2023 12:40:34 GMT, Coleen Phillimore wrote:
> You could fix your emacs functions.
It is a *very nice* feature of global-whitespace-cleanup-mode
-
PR Comment: https://git.openjdk.org/jdk/pull/14698#issuecomment-1613252347
On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> Yes, it is already problem listed
On Thu, 29 Jun 2023 12:11:40 GMT, David Holmes wrote:
> Neither the PR diffs nor the webrev make it easy to see exactly what is being
> changed here. It appeared to me that the last empty line of each file was
> being deleted, leaving no newline at the end.
My changes look like this in the dif
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 12:01:03 GMT, Coleen Phillimore wrote:
> Why do we care about this?
I care because of global-whitespace-cleanup-mode (in emacs). It helps me remove
trailing whitespaces and blanklines when saving but it will not fix a file that
was "dirty" when it was opened. Trailing blank
Please review change for mostly fixing return types in the constant pool and
metadata to fix -Wconversion warnings in JVMTI code.
Tested with tier1-4.
-
Commit messages:
- Fix -Wconversion warnings in jvmti code.
Changes: https://git.openjdk.org/jdk/pull/14710/files
Webrev: https:
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
Simple addition of a doc tag.
src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java is
introduced in jdk7 by
7036199: Adding a notification to the implementation of GarbageCollectorMXBeans
-
Commit messages:
- 8311000: missing @since info in jdk.management
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
This pull request has now been integrated.
Changeset: 98a954ee
Author:Artem Semenov
URL:
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
>
> It also seems far too large and disruptive.
Do you still think it is too disruptive after Erik's expl
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment: https://git.
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
49 matches
Mail list logo
