On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
On Wed, 28 Jun 2023 07:37:00 GMT, Serguei Spitsyn wrote:
> The test is great. I realize it is not easy to make it fully reliable though.
> So, will need another pass.
Good point about spurious wakeups.
Updated the test to handle them.
Now for WAITING scenarios the test suspends test thread and
> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
> should return STATE_WAITING)
> New test tests GetThreadState for different thread states.
> The test detected a bug in the implementation, new issue is created:
> JDK-8310584
> Corresponding testcases are commented now
On Wed, 28 Jun 2023 21:21:11 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Wed, 28 Jun 2023 21:21:11 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Wed, 28 Jun 2023 18:28:37 GMT, Tom Rodriguez wrote:
> Why can't the pending exception handling be in the respective virtual?
Done: 9236128ad1b7297c8c4e9d3022b88c3ab3278022
-
PR Comment: https://git.openjdk.org/jdk/pull/14641#issuecomment-1612113760
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
On Tue, 27 Jun 2023 12:41:50 GMT, Coleen Phillimore wrote:
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agr
On Wed, 28 Jun 2023 16:15:39 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use pointer_delta_as_int for the name that uses pointer_delta, fix
>> negative case to just do checked_cast.
>
> src/h
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
On Tue, 27 Jun 2023 21:29:53 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
Remove trailing "blank" lines in source files.
I like to use global-whitespace-cleanup-mode, but I can not use it if the files
are "dirty" to begin with. This fix will make more files "clean". I also
considered adding a check for this in jcheck for Skara, however it seems jcheck
code handling h
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
On Wed, 28 Jun 2023 13:16:30 GMT, Alan Bateman wrote:
>> Hi Alan, regarding usage of class VM I get
>> 'package jdk.internal.misc is declared in module java.base, which does not
>> export it to module java.sql'
>> Is there any concern to export it as well to module java.sql ?
>> And btw did yo
On Wed, 28 Jun 2023 12:54:10 GMT, Matthias Baesken wrote:
> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is
> declared in module java.base, which does not export it to module java.sql' Is
> there any concern to export it as well to module java.sql ? And btw did you
> m
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Thu, 22 Jun 2023 14:20:30 GMT, Alan Bateman wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> src/java.sql/share/classes/java/sql/DriverManager.java line 658:
>
>> 656: * (which is invoking this c
On Wed, 28 Jun 2023 07:52:35 GMT, Stefan Karlsson wrote:
>> Taking out that cast does work, so I've fixed that.
>
>> pointer_delta has different semantics
>
> Right. That was "recently" added to pointer_delta with JDK-8260046. It begs
> the question why felt the need to add it there but feel th
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> warning: 'volatile' type qualifier on return type has no effect
Can't say that I understand that warning. If I pass in a volatile pointer and
return the same pointer then I would not expect to lose the volatile aspect of
it. @kbarrett
On Fri, 16 Jun 2023 09:15:52 GMT, Kevin Walls wrote:
> Clean backport from latest jdk repo to jdk21 for the test change:
> 8303916: ThreadLists.java inconsistent results
This pull request has now been integrated.
Changeset: 8d9ebb69
Author:Kevin Walls
URL:
https://git.openjdk.org/jd
On Tue, 16 May 2023 18:41:26 GMT, Chris Plummer wrote:
>> Hi, can I have a review for this patch?
>
> @y1yang0 Sorry no one has been able to review this so far. The serviceability
> team is very busy for the next few weeks finishing up JDK 21 changes before
> RDP1. It's unlikely we'll find time
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the sam
On Tue, 27 Jun 2023 15:11:34 GMT, Coleen Phillimore wrote:
>> Hm. Maybe this would be ok. Our original idea was to make it T* not T until
>> this cast. I don't know how many other cases there are that I haven't
>> gotten to yet. But it would eliminate a cast, so that's good (unless these
>>
On Tue, 27 Jun 2023 20:54:27 GMT, Alex Menkov wrote:
>> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
>> should return STATE_WAITING)
>> New test tests GetThreadState for different thread states.
>> The test detected a bug in the implementation, new issue is created:
On Tue, 27 Jun 2023 23:06:49 GMT, Tom Rodriguez wrote:
> I don't think pushing it down that far improves things. encode always
> precedes decode so why not resolve it before the encode call.
Because the `VMSupport` klass is only needed if calling into HotSpot so it's
better to push it down int
On Tue, 27 Jun 2023 23:08:22 GMT, Tom Rodriguez wrote:
>> Doug Simon has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert to lazy loading of VMSupport
>
> src/hotspot/share/jvmci/jvmciEnv.cpp line 402:
>
>> 400: }
>> 401:
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
32 matches
Mail list logo
