Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-06-23 Thread Vladimir Sitnikov
On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie wrote: >> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an >> attempt to remove all trailing whitespace from properties files, and enable >> a jcheck verification that they did not come back, similar to other sourc

RFR: 8310585: GetThreadState spec mentions undefined JVMTI_THREAD_STATE_MONITOR_WAITING

2023-06-23 Thread Alex Menkov
Trivial fix in JVMTI spec. As it's just a typo, CSR is not required - Commit messages: - Update jvmti.xml Changes: https://git.openjdk.org/jdk/pull/14634/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14634&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310585 Sta

Re: RFR: 8310816: GcInfoBuilder float/double signature mismatch

2023-06-23 Thread David Holmes
On Fri, 23 Jun 2023 18:10:59 GMT, Kevin Walls wrote: > Simple typo in a signature which is passed to JNU_NewObjectByName. The > method clearly intentds to pass Float, but uses Double. > > This code is probably not invoked, unless there is a GC MXBean with such > fields. I see no straightforw

Re: RFR: 8310816: GcInfoBuilder float/double signature mismatch

2023-06-23 Thread Mandy Chung
On Fri, 23 Jun 2023 18:10:59 GMT, Kevin Walls wrote: > Simple typo in a signature which is passed to JNU_NewObjectByName. The > method clearly intentds to pass Float, but uses Double. > > This code is probably not invoked, unless there is a GC MXBean with such > fields. I see no straightforw

Re: RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2]

2023-06-23 Thread Serguei Spitsyn
On Fri, 23 Jun 2023 19:31:20 GMT, Tom Rodriguez wrote: >> This is a minor fix to core file reading on macos x. I can confirm that >> after this fix I can run the problem listed SA core file tests on Ventura. > > Tom Rodriguez has updated the pull request incrementally with three > additional c

Re: RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2]

2023-06-23 Thread Tom Rodriguez
> This is a minor fix to core file reading on macos x. I can confirm that > after this fix I can run the problem listed SA core file tests on Ventura. Tom Rodriguez has updated the pull request incrementally with three additional commits since the last revision: - Flatten nested ifs - Adjust

Re: RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2]

2023-06-23 Thread Tom Rodriguez
On Wed, 21 Jun 2023 19:56:58 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Flatten nested ifs >> - Adjust ordering of message >> - Adjust printing > > src/jdk.hotspot.agent/macosx/native

RFR: 8310816: GcInfoBuilder float/double signature mismatch

2023-06-23 Thread Kevin Walls
Simple typo in a signature which is passed to JNU_NewObjectByName. The method clearly intentds to pass Float, but uses Double. This code is probably not invoked, unless there is a GC MXBean with such fields. I see no straightforward way of testing this explicitly, but the change is tiny. All

Integrated: 8310628: GcInfoBuilder.c missing JNI Exception checks

2023-06-23 Thread Kevin Walls
On Thu, 22 Jun 2023 10:10:07 GMT, Kevin Walls wrote: > JNI calls were identified, where we do not check for a pending Exception > afterwards. > > (JDK-8162530 cleaned up up some of these kind of issues some years back, but > more were found.) > > I tested a code change to manually create an E

Re: RFR: 8310628: GcInfoBuilder.c missing JNI Exception checks

2023-06-23 Thread Kevin Walls
On Thu, 22 Jun 2023 10:10:07 GMT, Kevin Walls wrote: > JNI calls were identified, where we do not check for a pending Exception > afterwards. > > (JDK-8162530 cleaned up up some of these kind of issues some years back, but > more were found.) > > I tested a code change to manually create an E

Re: RFR: 8310628: GcInfoBuilder.c missing JNI Exception checks

2023-06-23 Thread Mandy Chung
On Thu, 22 Jun 2023 10:10:07 GMT, Kevin Walls wrote: > JNI calls were identified, where we do not check for a pending Exception > afterwards. > > (JDK-8162530 cleaned up up some of these kind of issues some years back, but > more were found.) > > I tested a code change to manually create an E

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v3]

2023-06-23 Thread Matthias Baesken
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote: >> Currently, a number of tests fail on macOS because they miss the core file >> (e.g. serviceability/sa/TestJmapCore.java). >> The reason is that configure detects on some setups that codesign does not >> work ("checking if debug mode c

Re: RFR: 8308286 Fix clang warnings in linux code [v8]

2023-06-23 Thread Daniel Jeliński
On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8308286 Fix clang warnings in linux code [v6]

2023-06-23 Thread Artem Semenov
On Fri, 23 Jun 2023 06:19:31 GMT, Daniel Jeliński wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: >> >>> 239: DISABLED_WARNINGS_gcc_OGLPaints.c := >>> format-nonliteral, \ >>> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c >>> :=

Re: RFR: 8308286 Fix clang warnings in linux code [v8]

2023-06-23 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all: