Re: RFR: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled

2023-06-19 Thread Doug Simon
On Fri, 9 Jun 2023 12:14:46 GMT, Doug Simon wrote: > > Is JVMCI used by the Graal compiler only? > > So far this is true and will probably remain true for the foreseeable future. > However, the Right Thing to do long term is to add a > `jdk.test.whitebox.code.Compiler.uncommonTrapsHavePreciseB

Re: Clarifying jmethodID Usage and Potential JVM Crashes

2023-06-19 Thread Jaroslav Bachorík
On Tue, Jun 20, 2023 at 4:38 AM David Holmes wrote: > On 19/06/2023 11:46 pm, Jaroslav Bachorík wrote: > > Hi, > > > > On Thu, Jun 1, 2023 at 5:49 PM > > wrote: > > > > Hmmm... seems like concurrent class unloading has revealed a > situation > > in som

Re: Clarifying jmethodID Usage and Potential JVM Crashes

2023-06-19 Thread David Holmes
On 19/06/2023 11:46 pm, Jaroslav Bachorík wrote: Hi, On Thu, Jun 1, 2023 at 5:49 PM > wrote: Hmmm... seems like concurrent class unloading has revealed a situation in some code where class refs should have been held, but were not held because

Integrated: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22 [v2]

2023-06-19 Thread David Holmes
> Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-19 Thread Ashutosh Mehra
On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote: >> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments by plummercj >> >> Signed-off-by: Ashutosh Mehra > > Yes, it is already problem listed

RFR: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures

2023-06-19 Thread Kevin Walls
This test iterates an array of ThreadInfos in a few places (e.g. in the method doCheck()), and needs to tolerate and ignore nulls, in case a thread finishes and the test hits an NPE. There are other calls like "TM.getThreadInfo(tid).getLockName()" which might often be risky, but if the threads

Re: Clarifying jmethodID Usage and Potential JVM Crashes

2023-06-19 Thread Jaroslav Bachorík
Hi, On Thu, Jun 1, 2023 at 5:49 PM wrote: > Hmmm... seems like concurrent class unloading has revealed a situation > in some > code where class refs should have been held, but were not held because > it's very > difficult to do, and the code (mostly) got away with it for a long time... > > David

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v13]

2023-06-19 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v12]

2023-06-19 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: 8303916: ThreadLists.java inconsistent results

2023-06-19 Thread Kevin Walls
On Wed, 14 Jun 2023 09:30:49 GMT, Kevin Walls wrote: > This test fails when additional threads are created, as it compares thread > lists from different sources and sees a mismatch. > > It needs to tolerate some threads with certain names appearing, e.g. JVMCI > and ForkJoin threads. If there

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Alan Bateman
On Mon, 19 Jun 2023 07:06:00 GMT, Axel Boldt-Christmas wrote: > > Hmmm... hopefully `vm.gc.ZSingelgen` is really `vm.gc.ZSinglegen`. If so > > you might want to fix the PR description. > > What part are you worried about? When would `vm.gc.ZSingelgen` be invalid? > > Also what part of the PR

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Axel Boldt-Christmas
On Fri, 16 Jun 2023 20:31:28 GMT, Daniel D. Daugherty wrote: > Hmmm... hopefully `vm.gc.ZSingelgen` is really `vm.gc.ZSinglegen`. If so you > might want to fix the PR description. What part are you worried about? When would `vm.gc.ZSingelgen` be invalid? Also what part of the PR requires fix

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Axel Boldt-Christmas
On Sat, 17 Jun 2023 13:24:24 GMT, Alan Bateman wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix wrong ZGenerational flag in VectorRebracket128Test.java > > test/jdk/java/lang/Thread/virtual/stress/Skynet

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v11]

2023-06-19 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v10]

2023-06-19 Thread Yi Yang
On Sat, 17 Jun 2023 01:20:21 GMT, Alex Menkov wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> whitespace > > Could you please add info about what testing have been done Hi @alexmenkov, > Could you please add info abou