On Wed, 14 Jun 2023 19:28:23 GMT, Alex Menkov wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 2325:
>>
>>> 2323: // Need to apply load barriers for unmounted vthreads.
>>> 2324: nmethod* nm = jvf->cb()->as_nmethod();
>>> 2325: nm->run_nmethod_entry_barrier();
>>
>
On Wed, 14 Jun 2023 01:02:09 GMT, Alex Menkov wrote:
> If virtual thread has frames in stackChunks, need to apply load barriers
> before processing nmethods (javaVFrame::locals() and
> javaVFrame::expressions() do it internally)
>
> Testing: tier1-tier5;
> 400 runs of VThreadStackRefTest.java
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the original file's changes in UTF-8
> native. Those fil
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 15 Jun 2023 20:55:12 GMT, Chris Plummer wrote:
> Can you tell me what testing you've done? Would be best to call that out in
> the PR description.
Edited the description to add a comment about the testing. Hope this helps.
-
PR Comment: https://git.openjdk.org/jdk/pull/144
On Thu, 15 Jun 2023 21:06:32 GMT, Kevin Rushforth wrote:
> Is the patch expected to be the same as in jdk mainline? I see some
> differences between the two patches (which is why Skara didn't mark it as
> "clean")
Hi Kevin, yes it is. I still need to grab the changes from mainline and include
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addres
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addres
On Thu, 15 Jun 2023 18:15:41 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> src/jdk.hotspot.agent/share/class
> Please review this PR that extends SA to write BootstrapMethods attribute
> when dumping the class files.
Ashutosh Mehra has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments by plummercj
Signed-off-by: Ashutosh Mehra
-
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Wed, 14 Jun 2023 21:24:31 GMT, Chris Plummer wrote:
> The test gets overloaded with MethodExitEvents, causing them to queue up (in
> the JDI queue) and continue to be processed by the test after the debuggee
> exits. This results in a VMDisconnectedException when the test tries to do
> the
On Thu, 15 Jun 2023 15:06:54 GMT, Ashutosh Mehra wrote:
> Please review this PR that extends SA to write BootstrapMethods attribute
> when dumping the class files.
Changes requested by cjplummer (Reviewer).
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line
498:
On Wed, 14 Jun 2023 21:24:31 GMT, Chris Plummer wrote:
> The test gets overloaded with MethodExitEvents, causing them to queue up (in
> the JDI queue) and continue to be processed by the test after the debuggee
> exits. This results in a VMDisconnectedException when the test tries to do
> the
Please review this PR that extends SA to write BootstrapMethods attribute when
dumping the class files.
-
Commit messages:
- 8309979: BootstrapMethods attribute is missing in class files recreated by SA
Changes: https://git.openjdk.org/jdk/pull/14495/files
Webrev: https://webrevs.
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> settled down now so we can do some small cleanups that came up in PR
>
On Wed, 14 Jun 2023 09:30:49 GMT, Kevin Walls wrote:
> This test fails when additional threads are created, as it compares thread
> lists from different sources and sees a mismatch.
>
> It needs to tolerate some threads with certain names appearing, e.g. JVMCI
> and ForkJoin threads. If there
On Wed, 14 Jun 2023 21:24:31 GMT, Chris Plummer wrote:
> The test gets overloaded with MethodExitEvents, causing them to queue up (in
> the JDI queue) and continue to be processed by the test after the debuggee
> exits. This results in a VMDisconnectedException when the test tries to do
> the
On Mon, 5 Jun 2023 19:44:35 GMT, Alan Bateman wrote:
> > I think we need to delay this until
> > [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in
> > case we would like to revert
> > [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305092).
>
> Okay, I won't integr
22 matches
Mail list logo
