Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v10]

2023-06-13 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v9]

2023-06-13 Thread Yi Yang
> ### Motivation and proposal > Hi, heap dump brings about pauses for application's execution(STW), this is a > well-known pain. JDK-8252842 have added parallel support to heapdump in an > attempt to alleviate this issue. However, all concurrent threads > competitively write heap data to the sam

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread David Holmes
On Wed, 14 Jun 2023 06:08:59 GMT, Alan Bateman wrote: >> Updated the version to 22-ea and year to 2024. >> >> The following unpublished changes will also be included in this update: >> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool >> manpage contains a special character

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread Alan Bateman
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-13 Thread David Holmes
Updated the version to 22-ea and year to 2024. The following unpublished changes will also be included in this update: - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character - [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update ja

Re: RFR: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"

2023-06-13 Thread Alex Menkov
On Wed, 14 Jun 2023 01:02:09 GMT, Alex Menkov wrote: > If virtual thread has frames in stackChunks, need to apply load barriers > before processing nmethods (javaVFrame::locals() and > javaVFrame::expressions() do it internally) > > Testing: tier1-tier5 (still in progress); > 400 runs of VThre

Integrated: 8309878: Reduce inclusion of resolvedIndyEntry.hpp

2023-06-13 Thread Ioi Lam
On Mon, 12 Jun 2023 19:52:36 GMT, Ioi Lam wrote: > resolvedIndyEntry.hpp was added in > [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995) and is included in > the popular cpCache.hpp. As a result, resolvedIndyEntry.hpp is included in > 807 out of about 1160 hotspot .o files. > > The

Re: RFR: 8309878: Reduce inclusion of resolvedIndyEntry.hpp

2023-06-13 Thread Ioi Lam
On Mon, 12 Jun 2023 22:24:26 GMT, Serguei Spitsyn wrote: >> resolvedIndyEntry.hpp was added in >> [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995) and is included >> in the popular cpCache.hpp. As a result, resolvedIndyEntry.hpp is included >> in 807 out of about 1160 hotspot .o file

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v4]

2023-06-13 Thread Naoto Sato
On Tue, 13 Jun 2023 22:09:40 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > Some comments: > > - `src/java.base/share/classes/sun/launcher/resources

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v4]

2023-06-13 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v8]

2023-06-13 Thread Alex Menkov
On Tue, 6 Jun 2023 02:35:30 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurre

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 19:59:28 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/java.desktop/macosx/classes/com/apple/laf/resources/aqua_ja.properties

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v3]

2023-06-13 Thread Justin Lu
> Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the original file's changes in UTF-8 > native. Those fil

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Weijun Wang
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Justin Lu
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 'main.help.opt.any.file' value for _de > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.p

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

2023-06-13 Thread Chris Plummer
On Fri, 9 Jun 2023 23:58:39 GMT, Chris Plummer wrote: > This test launches a debuggee, which creates 11 instances of its main class, > stores them in a static array of the main class, and then the debugger side > iterates over all referrers to the main class instaces. Usually this is a > prett

Integrated: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

2023-06-13 Thread Chris Plummer
On Fri, 9 Jun 2023 23:58:39 GMT, Chris Plummer wrote: > This test launches a debuggee, which creates 11 instances of its main class, > stores them in a static array of the main class, and then the debugger side > iterates over all referrers to the main class instaces. Usually this is a > prett

Re: RFR: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory [v2]

2023-06-13 Thread Chris Plummer
> This test launches a debuggee, which creates 11 instances of its main class, > stores them in a static array of the main class, and then the debugger side > iterates over all referrers to the main class instaces. Usually this is a > pretty quick process and doesn't produce much in the way of o

Re: RFR: 8309878: Reduce inclusion of resolvedIndyEntry.hpp

2023-06-13 Thread Matias Saavedra Silva
On Mon, 12 Jun 2023 19:52:36 GMT, Ioi Lam wrote: > resolvedIndyEntry.hpp was added in > [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995) and is included in > the popular cpCache.hpp. As a result, resolvedIndyEntry.hpp is included in > 807 out of about 1160 hotspot .o files. > > The

Integrated: 8309468: Remove jvmti Allocate locker test case

2023-06-13 Thread Leo Korinth
On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named jvmti locker. In that test, JNI code is doing a loop > of ` jvmti->Allocate()` followed `sleep()` followed by a > `jvmti->Deallocate()`.

Re: RFR: 8309468: Remove jvmti Allocate locker test case

2023-06-13 Thread Leo Korinth
On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named jvmti locker. In that test, JNI code is doing a loop > of ` jvmti->Allocate()` followed `sleep()` followed by a > `jvmti->Deallocate()`.

Re: RFR: 8309757: com/sun/jdi/ReferrersTest.java fails with virtual test thread factory

2023-06-13 Thread Kevin Walls
On Fri, 9 Jun 2023 23:58:39 GMT, Chris Plummer wrote: > This test launches a debuggee, which creates 11 instances of its main class, > stores them in a static array of the main class, and then the debugger side > iterates over all referrers to the main class instaces. Usually this is a > prett

Integrated: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled

2023-06-13 Thread Yudi Zheng
On Thu, 8 Jun 2023 17:14:39 GMT, Yudi Zheng wrote: > HeapMonitor checks if System.getProperty("jvmci.Compiler") is graal and will > not enforce checking line number derived from uncommon trap debug info. > However, Graal does not set this property explicitly. This pull request has now been int

Re: RFR: 8309671: Avoid using jvmci.Compiler property to determine if Graal is enabled

2023-06-13 Thread Yudi Zheng
On Thu, 8 Jun 2023 17:14:39 GMT, Yudi Zheng wrote: > HeapMonitor checks if System.getProperty("jvmci.Compiler") is graal and will > not enforce checking line number derived from uncommon trap debug info. > However, Graal does not set this property explicitly. Thanks for the review! --

Integrated: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop

2023-06-13 Thread Martin Doerr
On Mon, 12 Jun 2023 14:36:56 GMT, Martin Doerr wrote: > Test fix for test failing on AIX because of undefined behavior in current > implementation. This pull request has now been integrated. Changeset: 08eff92b Author:Martin Doerr URL: https://git.openjdk.org/jdk21/commit/08eff92b5