On Mon, 29 May 2023 15:36:36 GMT, Stefan Karlsson wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/gc/z/zHeap.cpp line 438:
>
>> 436:
>> 437: if (addr == zaddress::null) {
>> 438:
On Mon, 29 May 2023 10:17:06 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/runtime/globals.hpp line 632:
>
>> 630:
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Looks good. A few suggested changes below.
Can we now poison NULL so it can't get reintroduced? Or would that po
On Mon, 29 May 2023 17:51:17 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface meth
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Mon, 29 May 2023 02:02:21 GMT, David Holmes wrote:
>> Paul Hohensee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 100 commits:
>>
>> - 8304074: Remove extra file
>> - 8304074: Add getTotalAllocatedBytes high water mark
>>
On Fri, 26 May 2023 16:41:32 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface meth
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Looks good. Though, I'd prefer if we could slightly tweak the following two
print lines.
src/hotspot/share/gc/z
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
not a review, but would you like to check if these could replaced as well :-)
./cpu/ppc/macroAssembler_ppc.hpp:
On Mon, 29 May 2023 10:19:02 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/utilities/globalDefinitions.cpp line 162:
>
>> 160: static_assert((size_t)HeapWordSize
A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
I'd appreciate if this was considered trivial.
-
Commit messages:
- Fix remaining work
Changes: https://git.openjdk.org/jdk/pull/14198/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14198&range=00
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
All of the stuff to actually keep.
src/hotspot/cpu/aarch64/jvmciCodeInstaller_aarch64.cpp line 125:
> 123:
> 1
On Sat, 27 May 2023 08:18:57 GMT, Alan Bateman wrote:
> I agree it could be annoying to have multiple warnings if the profiler is
> attaching and loading the same agent library many times.
I've updated the changes to allow it be implementation specific as to whether a
warning is printed when
> This is the implementation for JEP 451. There are two parts to this:
>
> 1. A multi-line warning is printed when a JVM TI or Java agent is loaded into
> a running VM. For JVM TI, the message is printed to stderr from
> JvmtiAgent::load. For Java agents, it is printed to System.err (as that may
15 matches
Mail list logo
