On Tue, 9 May 2023 13:49:55 GMT, Coleen Phillimore wrote:
>> `put_when_known_absent`?
>>
>> A basic `put` should either add or replace; a `put_if_absent` should only
>> add else do nothing.
>
> put_when_absent is what I have and it's fine. I don't think we need more
> sentence names or chang
On Wed, 10 May 2023 19:56:53 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
>
> Daniel D. Daugherty has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated chang
On Wed, 10 May 2023 14:40:24 GMT, Afshin Zafari wrote:
>> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which
>> was far behind the master.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8305083: R
On Tue, 9 May 2023 09:40:37 GMT, Afshin Zafari wrote:
> We still need the Finalizable interface to call the cleanup of the host
> object:
No you would replace any occurrence of `Finalizable` with `FinalizeableObject`
-
PR Comment: https://git.openjdk.org/jdk/pull/13884#issuecommen
On Thu, 11 May 2023 03:40:31 GMT, David Holmes wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8304074: getTotalThreadAllocatedBytes name change, increment
>> exited_allocated_bytes in ThreadService::remove_threa
On Wed, 10 May 2023 23:57:47 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface meth
On Wed, 10 May 2023 18:02:22 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
On Thu, 11 May 2023 01:02:48 GMT, Leonid Mesnik wrote:
> Method post_dynamic_code_generated_while_holding_locks()
> register stubs and might be called during VTMT transitions.
> At least it is called in tmp VTMT transition, and stubs might be generated
> during standard VTMT transition.
>
> The
On Wed, 10 May 2023 23:41:07 GMT, Alex Menkov wrote:
>> The fix updates JVMTI FollowReferences implementation to report references
>> from virtual threads:
>> - unmounted vthreads are detected, their stack references for
>> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
>> - s
Method post_dynamic_code_generated_while_holding_locks()
register stubs and might be called during VTMT transitions.
At least it is called in tmp VTMT transition, and stubs might be generated
during standard VTMT transition.
The method doesn't post event but just register stub for later posting s
In TestScaffold.java we check the debuggee process exitValue, and allow a 0 or
a 1. Otherwise the test fails. You get exitValue 1 when the debuggee exits with
an exception. Allowing this was necessary because some tests purposely make the
debuggee exit with an exception. However, this runs the r
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - unmounted vthreads are detected, their stack references for
> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
> - stacks of mounted vthreads are splitted into 2 parts (virtual
On Wed, 10 May 2023 17:48:04 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681
On Wed, 10 May 2023 17:48:04 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
On Tue, 9 May 2023 20:22:28 GMT, Chris Plummer wrote:
>> The SA document `transported_core.html` contains some tips on getting core
>> files to work when debugging it on a machine other than the one that
>> produced it. There are a few improvements that can be made based on
>> information prov
> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three ad
On Wed, 10 May 2023 19:32:35 GMT, Daniel D. Daugherty
wrote:
> A trivial copyright fix.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13916#pullrequestreview-1421263660
On Wed, 10 May 2023 19:33:28 GMT, Roger Riggs wrote:
>> A trivial copyright fix.
>
> Marked as reviewed by rriggs (Reviewer).
@RogerRiggs and @plummercj - Thanks for the lightning fast reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/13916#issuecomment-1542703655
On Wed, 10 May 2023 19:32:35 GMT, Daniel D. Daugherty
wrote:
> A trivial copyright fix.
This pull request has now been integrated.
Changeset: df90df29
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/df90df298e4183f5328b88ff0af91ba96fb2510d
Stats: 1 line in 1
On Wed, 10 May 2023 19:32:35 GMT, Daniel D. Daugherty
wrote:
> A trivial copyright fix.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13916#pullrequestreview-1421263508
A trivial copyright fix.
-
Commit messages:
- 8307857: validate-source fails after JDK-8306758
Changes: https://git.openjdk.org/jdk/pull/13916/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13916&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8307857
Stats: 1 line
On Fri, 5 May 2023 22:21:36 GMT, Chris Plummer wrote:
> This test was very rarely failing with a exitValue 143 from the debuggee. It
> only happened when the machine was under a lot of stress. After some
> investigation it was realized that on unix OSes it should *always* expect
> exitValue 14
On Tue, 9 May 2023 22:49:28 GMT, Chris Plummer wrote:
>> This test was very rarely failing with a exitValue 143 from the debuggee. It
>> only happened when the machine was under a lot of stress. After some
>> investigation it was realized that on unix OSes it should *always* expect
>> exitValu
Before I get to your specific points, let me clarify that this informational
JEP is a summary of *past* work and decisions (except maybe the FFM/JNI
restriction) that, though already delivered or announced, their full motivation
was never canonised in JEP form. Everything it describes has either
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote:
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
This pull request has now been integrated.
Changeset: 9af1787e
Author:Kevin Walls
URL:
https://g
On Tue, 11 Apr 2023 08:16:29 GMT, Afshin Zafari wrote:
> The `finalize()` method is removed from base classes/interfaces and are
> replaced by a Cleaner callback..
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/13420
On Wed, 10 May 2023 14:40:24 GMT, Afshin Zafari wrote:
>> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which
>> was far behind the master.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8305083: R
On Wed, 10 May 2023 14:40:24 GMT, Afshin Zafari wrote:
>> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which
>> was far behind the master.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8305083: R
On Tue, 9 May 2023 15:55:48 GMT, Coleen Phillimore wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/
>> and /jpda that are used in serviceabi
On Wed, 10 May 2023 14:29:20 GMT, Afshin Zafari wrote:
>> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which
>> was far behind the master.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8305083: R
> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which
> was far behind the master.
Afshin Zafari has updated the pull request incrementally with one additional
commit since the last revision:
8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with four additional
> commits since th
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Tue, 17 Jan 2023 11:26:12 GMT, Johan Sjölen wrote:
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
On Thu, 4 May 2023 22:32:36 GMT, Coleen Phillimore wrote:
> The ResourceHashtable conversion for JDK-8292741 didn't add the resizing
> code. The old hashtable code was tuned for resizing in anticipation of large
> hashtables for JVMTI tags. This patch ports over the old hashtable resizing
>
On Mon, May 8, 2023 at 9:17 PM Mark Reinhold wrote:
>
> https://openjdk.org/jeps/451
>
> Summary: Issue warnings when agents are loaded dynamically into a
> running JVM. These warnings aim to prepare users for a future release
> which disallows the dynamic loading of agents by default in ord
On Wed, 10 May 2023 09:02:40 GMT, Kevin Walls wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java
>> line 188:
>>
>>> 186: *
>>> 187: *
>>> 188: *
>>> service:jmx:protocolname://[host[:port]]/stub/encoded-stub
>>
>> "protocolname" coul
On Wed, 10 May 2023 09:01:16 GMT, Alan Bateman wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> example update
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java
> line 188:
>
>
On Wed, 10 May 2023 08:49:47 GMT, Kevin Walls wrote:
>> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
>> This class is not referenced by other classes or tests.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last rev
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
example update
-
Changes:
- all: htt
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote:
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Putting the example back in RMIConnector, but I was keen to remove "iiop" from
search results here, so with
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
example update
-
Changes:
- all: htt
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the same file, and more memory is req
48 matches
Mail list logo
