Re: RFR: 8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

2023-05-07 Thread Arno Zeller
On Thu, 4 May 2023 09:47:55 GMT, Thomas Stuefe wrote: >> Unless this test is run as root, it needs sudo privileges. If it gets them, >> the test runs fine, but leaves a file with root ownership. So jtreg cannot >> delete it, and you see errors when "make clean" tries to delete it. >> It's bes

Re: RFR: 8306843: JVMTI tag map extremely slow after JDK-8292741 [v2]

2023-05-07 Thread David Holmes
On Mon, 8 May 2023 04:21:01 GMT, Ioi Lam wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove return variable from remove lambda, fix formatting. > > src/hotspot/share/utilities/resourceHash.hpp line 147: >

Re: RFR: 8306843: JVMTI tag map extremely slow after JDK-8292741 [v2]

2023-05-07 Thread Ioi Lam
On Fri, 5 May 2023 12:07:20 GMT, Coleen Phillimore wrote: >> The ResourceHashtable conversion for JDK-8292741 didn't add the resizing >> code. The old hashtable code was tuned for resizing in anticipation of >> large hashtables for JVMTI tags. This patch ports over the old hashtable >> resiz

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v5]

2023-05-07 Thread David Holmes
On Fri, 5 May 2023 21:38:47 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface metho

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v5]

2023-05-07 Thread David Holmes
On Fri, 5 May 2023 21:21:28 GMT, Paul Hohensee wrote: > Afaiu, SMR/TLH keeps a terminated thread's TLS accessible, but doesn't stop > the termination process. Incorrect. A thread cannot complete the termination process if it is contained by a TLH - see ` ThreadsSMRSupport::smr_delete` and the

Re: RFR: JDK-8306441: Segmented heap dump [v4]

2023-05-07 Thread Yi Yang
On Thu, 4 May 2023 08:40:10 GMT, Yi Yang wrote: >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurrent threads >> competitively wr

Re: RFR: 8291555: Implement alternative fast-locking scheme [v78]

2023-05-07 Thread David Holmes
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v4]

2023-05-07 Thread David Holmes
On Fri, 5 May 2023 14:50:30 GMT, Afshin Zafari wrote: >> The `finalize()` method is removed from base classes/interfaces and are >> replaced by a Cleaner callback.. > > Afshin Zafari has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains