On Wed, 22 Mar 2023 15:57:40 GMT, Johannes Bechberger
wrote:
> Fixes the issue by disabling PCDesc cache modifications when in ASGCT.
>
> Tested on my M1 mac.
This pull request has now been integrated.
Changeset: d8af7a60
Author:Johannes Bechberger
Committer: Matthias Baesken
URL:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Wed, 12 Apr 2023 02:08:08 GMT, David Holmes wrote:
>> That seems fine to me, as long as we don't crash. But my understanding is
>> that Generational ZGC will crash if it sees a stale oop. Isn't it possible
>> that the racing read sees junk that looks to Generational ZGC like a stale
>> oo
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Fri, 7 Apr 2023 19:17:46 GMT, Matias Saavedra Silva
wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - more clean up: heap_regions -> heap_region, etc
>> - @matias9927 comments
>
> src/hotspot/share/cds/archiveBuild
On Wed, 12 Apr 2023 04:05:07 GMT, Alex Menkov wrote:
> current logic does not follow their stack references
Okay that needs to be fixed then. Apologies if that is what you already were
doing.
-
PR Comment: https://git.openjdk.org/jdk/pull/13254#issuecomment-1504587109
On Wed, 12 Apr 2023 02:17:14 GMT, David Holmes wrote:
> If an object is only reachable from the stack of a VT and the VT itself is
> not followed then we don't find that object either. But as I said a VT should
> be found via the object it is parked on, or via the scheduler. So is it the
> cas
On Tue, 11 Apr 2023 18:07:41 GMT, Martin Doerr wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
Martin, only concern was that I didn't have a good experience with `s390x`
string in
[past](http
On Sat, 8 Apr 2023 13:24:37 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the l
On Tue, 11 Apr 2023 12:07:32 GMT, Afshin Zafari wrote:
>> The `removal` warnings are suppressed out.
>> Test:
>> `FinalizerInfoTest` and `RunFinalizationTest` are executed locally.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 11 Apr 2023 17:51:39 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 11 Apr 2023 18:54:09 GMT, Alex Menkov wrote:
> The bug is about objects referenced only from stack of unmounted VT are not
> reported by FollowReferences.
> So we need to detect stackChunk object and report references from them.
If an object is only reachable from the stack of a VT and
On Tue, 11 Apr 2023 20:40:14 GMT, Dean Long wrote:
>> Yes. The whole LockStack is not meant to be accessed cross-thread, pretty
>> much like any thread's stack is not meant to be accessed like that
>> (including current stack-locking). So what can go wrong?
>> With the new locking, we could rea
On Sat, 8 Apr 2023 13:24:37 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the l
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - added heap scanning to report unmounted vthreads;
> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
> and carrier thread stack), references are reported with corre
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - added heap scanning to report unmounted vthreads;
> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
> and carrier thread stack), references are reported with corre
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src
On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 19:58:19 GMT, Roman Kennke wrote:
>> The `_base` array is only initialized to nullptr in debug builds. I don't
>> see a release barrier in LockStack::push between the update to _base[] and
>> the update to _top, nor a corresponding acquire barrier when reading.
>> Doesn't
On Tue, 11 Apr 2023 19:35:36 GMT, Dean Long wrote:
>> Given that the race with new lightweight locking is virtually the same as
>> the race
>> with legacy stack locking, please do not put back the 'LockingMode == 2'
>> check
>> which would make `jmm_GetThreadInfo()` calls slower with new lightw
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 15:29:16 GMT, Daniel D. Daugherty
wrote:
>> OK. Given that I haven't looked at the rest of the patch, I leave it up to
>> you and the Reviewers to figure out what to do about this code. Cheers.
>
> Given that the race with new lightweight locking is virtually the same as the
On Tue, 11 Apr 2023 19:33:28 GMT, Roger Riggs wrote:
>>> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> > linux, too.
>>>
>>> Changing os.arch is out of scope for this PR. The best way for that would
>>> someone supporting ppc to develop and propose a PR.
>>
>>
On Tue, 11 Apr 2023 18:37:11 GMT, Glavo wrote:
>>> Would be great if you could support "os.arch = ppc64" for AIX and legacy
>>> linux, too.
>>
>> Changing os.arch is out of scope for this PR.
>> The best way for that would someone supporting ppc to develop and propose a
>> PR.
>
>> > Would be
On Tue, 11 Apr 2023 12:07:32 GMT, Afshin Zafari wrote:
>> The `removal` warnings are suppressed out.
>> Test:
>> `FinalizerInfoTest` and `RunFinalizationTest` are executed locally.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 11 Apr 2023 03:07:04 GMT, David Holmes wrote:
> Seems to me the bug report is asking for unmounted virtual threads to be
> considered roots - but virtual threads are deliberately not roots. Any
> unmounted virtual thread should be reachable from either the scheduler or
> whatever objec
On Tue, 11 Apr 2023 17:51:39 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 59 commits:
- Me
On Tue, 11 Apr 2023 16:58:13 GMT, Roger Riggs wrote:
> > Would be great if you could support "os.arch = ppc64" for AIX and legacy
> > linux, too.
>
> Changing os.arch is out of scope for this PR. The best way for that would
> someone supporting ppc to develop and propose a PR.
It seems that y
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request incrementally with 42 additional
commits since the last revision:
- Merge remote-tracking branch
Please review a cleanup in DocCommentParser to merge blockContent and
inlineContent into a single method to parse "rich content" in a doc comment.
-
Depends on: https://git.openjdk.org/jdk/pull/13362
Commit messages:
- JDK-8305713: DocCommentParser: merge blockContent and inlineCon
On Tue, 11 Apr 2023 18:02:14 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified test to check Architecture is64bits() and isLittleEndian()
>> against Unsafe respective values.
>> Relocate
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
Updated comments
-
Changes:
- all: https://
On Tue, 11 Apr 2023 16:55:42 GMT, Leonid Mesnik wrote:
>> The TestScaffold incorrectly parse options, it should insert wrapper class
>> between VM options and applications classame.
>
> Leonid Mesnik has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Sat, 8 Apr 2023 07:14:30 GMT, Thomas Stuefe wrote:
> This looks like a nice simplification. Will you also combine all mappings at
> OS level to a single one, so that you only need one mmap call?
Now there's a single call to mmap() in
FileMapInfo::map_heap_regions_impl_inner(). This reminds
On Tue, 11 Apr 2023 10:39:39 GMT, Martin Doerr wrote:
>> This should (probably) be correct:
>> Suggestion:
>>
>> case PPC64 -> !OperatingSystem.isAix() &&
>> Architecture.isLittleEndian();
>
> Looks correct, but makes the test pointless for any linux on PPC64.
Will change to compar
On Tue, 11 Apr 2023 16:56:49 GMT, Serguei Spitsyn wrote:
> > Can I please get a second review to close this one out?
>
> Markus, I'm still working on it and close to finish. I have some questions to
> ask. In fact, I gave up to prove this refactoring does not break anything.
> So, we should re
On Tue, 11 Apr 2023 11:41:24 GMT, Glavo wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template
> lin
On Tue, 11 Apr 2023 12:33:32 GMT, Markus Grönlund wrote:
> Can I please get a second review to close this one out?
Markus, I'm still working on it and close to finish. I have some questions to
ask.
In fact, I gave up to prove this refactoring does not break anything.
So, we should rely on testi
> The TestScaffold incorrectly parse options, it should insert wrapper class
> between VM options and applications classame.
Leonid Mesnik has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains eight commits:
- updated after David's commen
On Tue, 11 Apr 2023 14:04:17 GMT, Stefan Karlsson wrote:
>> Hmm you are right. But still - that problem is pre-existing, right? Consider
>> this code in the current stack-locking implementation. If we don't stop the
>> other thread, we may end up following a stack-pointer from the
>> locked-ob
On Sat, 8 Apr 2023 01:11:08 GMT, Jiangli Zhou wrote:
> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol
> problems when statically linking the launcher executable with JDK native
> libraries.
This pull request has now been integrated.
Changeset: ce4b9955
Author:Jiangli Z
On Mon, 10 Apr 2023 19:38:18 GMT, Jiangli Zhou wrote:
>> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol
>> problems when statically linking the launcher executable with JDK native
>> libraries.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
On Mon, 10 Apr 2023 19:38:18 GMT, Jiangli Zhou wrote:
>> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol
>> problems when statically linking the launcher executable with JDK native
>> libraries.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
On Tue, 11 Apr 2023 13:48:15 GMT, Roman Kennke wrote:
>> It looks to me like the code could read racingly read the element just above
>> `_top`, which could contain a stale oop. If the address of the stale oop
>> matches the address of `o` then `contains` would incorrectly return true.
>>
>> D
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote:
> Updated VM internal object allocation C2 intrinsic to post jvmti events when
> needed.
This pull request has now been integrated.
Changeset: 7a5597c3
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/7a5597c34f3b52d
On Tue, 11 Apr 2023 12:15:07 GMT, Stefan Karlsson wrote:
>> The NativeAccess is a left-over from an earlier attempt, and yes I think the
>> start_processing() is the actual barrier. There is a single call-path where
>> we inspect another thread's lock-stack outside of a safepoint (from
>> mana
On Tue, 4 Apr 2023 14:39:19 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> We are adding support to let JFR report on Agents.
>>
>> Design
>>
>> An Agent is a library that uses any instrumentation or profiling APIs. Most
>> agents are started and initialized on the command line, but age
On Tue, 11 Apr 2023 11:47:46 GMT, Roman Kennke wrote:
>> src/hotspot/share/runtime/lockStack.inline.hpp line 111:
>>
>>> 109: int end = to_index(_top);
>>> 110: for (int i = end - 1; i >= 0; i--) {
>>> 111: if (NativeAccess<>::oop_load(&_base[i]) == o) {
>>
>> The use of NativeAccess he
On Tue, 11 Apr 2023 10:57:34 GMT, David Holmes wrote:
> Suppression of warning is fine but the bug synopsis (and so PR title) needs
> to be updated to reflect what is actually happening here. And the bug title
> doesn't really make sense anyway - why is the test location given twice ??
Bug and
> The `removal` warnings are suppressed out.
> Test:
> `FinalizerInfoTest` and `RunFinalizationTest` are executed locally.
Afshin Zafari has updated the pull request incrementally with one additional
commit since the last revision:
Remove the removal warnings for finalize() from
test/hotspot/
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Tue, 11 Apr 2023 11:36:10 GMT, Stefan Karlsson wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> RISCV update
>
> src/hotspot/share/runtime/lockStack.inline.hpp line 111:
>
>> 109: int end = to_index(_top);
>>
On Thu, 6 Apr 2023 11:59:45 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Mon, 10 Apr 2023 19:38:18 GMT, Jiangli Zhou wrote:
>> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol
>> problems when statically linking the launcher executable with JDK native
>> libraries.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
On Tue, 11 Apr 2023 10:20:25 GMT, Afshin Zafari wrote:
> The `removal` warnings are suppressed out.
> Test:
> `FinalizerInfoTest` and `RunFinalizationTest` are executed locally.
Suppression of warning is fine but the bug synopsis (and so PR title) needs to
be updated to reflect what is actually
On Tue, 11 Apr 2023 10:26:02 GMT, ExE Boss wrote:
>> test/jdk/jdk/internal/util/ArchTest.java line 128:
>>
>>> 126: case RISCV64 -> true;
>>> 127: case S390 -> false;
>>> 128: case PPC64 -> true;
>>
>> This is not always true. The PPC64 architecture supports
On Tue, 11 Apr 2023 10:15:27 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> test/jdk/jdk/internal/util/ArchTest.java line 128:
>
>> 126:
The `removal` warnings are suppressed out.
Test:
`FinalizerInfoTest` and `RunFinalizationTest` are executed locally.
-
Commit messages:
- 8305084: Remove finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/
that are used in serviceability/dcmd/gc/
Changes: https://git.openjdk
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
66 matches
Mail list logo
